All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Mostafa Saleh <smostafa@google.com>
Cc: iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
	linux-arm-kernel@lists.infradead.org,
	Robin Murphy <robin.murphy@arm.com>,
	Will Deacon <will@kernel.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Jean-Philippe Brucker <jean-philippe@linaro.org>,
	Joerg Roedel <jroedel@suse.de>, Moritz Fischer <mdf@kernel.org>,
	Moritz Fischer <moritzf@google.com>,
	Michael Shavit <mshavit@google.com>,
	Nicolin Chen <nicolinc@nvidia.com>,
	patches@lists.linux.dev,
	Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
	Zhangfei Gao <zhangfei.gao@linaro.org>
Subject: Re: [PATCH v5 06/17] iommu/arm-smmu-v3: Hold arm_smmu_asid_lock during all of attach_dev
Date: Tue, 13 Feb 2024 12:18:58 -0400	[thread overview]
Message-ID: <20240213161858.GC1088888@nvidia.com> (raw)
In-Reply-To: <ZcuNESWmrC9jZ9lM@google.com>

On Tue, Feb 13, 2024 at 03:38:57PM +0000, Mostafa Saleh wrote:

> This seems a bit theoretical to me also it requires mis-programming as the master
> will issue DMA in detach

iommufd allows VFIO userspace to do this workload as an attack on the
kernel.

Thanks,
Jason

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Mostafa Saleh <smostafa@google.com>
Cc: iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
	linux-arm-kernel@lists.infradead.org,
	Robin Murphy <robin.murphy@arm.com>,
	Will Deacon <will@kernel.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Jean-Philippe Brucker <jean-philippe@linaro.org>,
	Joerg Roedel <jroedel@suse.de>, Moritz Fischer <mdf@kernel.org>,
	Moritz Fischer <moritzf@google.com>,
	Michael Shavit <mshavit@google.com>,
	Nicolin Chen <nicolinc@nvidia.com>,
	patches@lists.linux.dev,
	Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
	Zhangfei Gao <zhangfei.gao@linaro.org>
Subject: Re: [PATCH v5 06/17] iommu/arm-smmu-v3: Hold arm_smmu_asid_lock during all of attach_dev
Date: Tue, 13 Feb 2024 12:18:58 -0400	[thread overview]
Message-ID: <20240213161858.GC1088888@nvidia.com> (raw)
In-Reply-To: <ZcuNESWmrC9jZ9lM@google.com>

On Tue, Feb 13, 2024 at 03:38:57PM +0000, Mostafa Saleh wrote:

> This seems a bit theoretical to me also it requires mis-programming as the master
> will issue DMA in detach

iommufd allows VFIO userspace to do this workload as an attack on the
kernel.

Thanks,
Jason

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2024-02-13 16:19 UTC|newest]

Thread overview: 112+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-06 15:12 [PATCH v5 00/17] Update SMMUv3 to the modern iommu API (part 1/3) Jason Gunthorpe
2024-02-06 15:12 ` Jason Gunthorpe
2024-02-06 15:12 ` [PATCH v5 01/17] iommu/arm-smmu-v3: Make STE programming independent of the callers Jason Gunthorpe
2024-02-06 15:12   ` Jason Gunthorpe
2024-02-15 13:49   ` Will Deacon
2024-02-15 13:49     ` Will Deacon
2024-02-15 16:01     ` Jason Gunthorpe
2024-02-15 16:01       ` Jason Gunthorpe
2024-02-15 18:42       ` Robin Murphy
2024-02-15 18:42         ` Robin Murphy
2024-02-15 20:11         ` Robin Murphy
2024-02-15 20:11           ` Robin Murphy
2024-02-16 16:28           ` Will Deacon
2024-02-16 16:28             ` Will Deacon
2024-02-15 21:17         ` Jason Gunthorpe
2024-02-15 21:17           ` Jason Gunthorpe
2024-02-21 13:49       ` Will Deacon
2024-02-21 13:49         ` Will Deacon
2024-02-21 14:08         ` Jason Gunthorpe
2024-02-21 14:08           ` Jason Gunthorpe
2024-02-21 16:19           ` Michael Shavit
2024-02-21 16:19             ` Michael Shavit
2024-02-21 16:52             ` Michael Shavit
2024-02-21 16:52               ` Michael Shavit
2024-02-21 17:06             ` Jason Gunthorpe
2024-02-21 17:06               ` Jason Gunthorpe
2024-02-22 17:43           ` Will Deacon
2024-02-22 17:43             ` Will Deacon
2024-02-23 15:18             ` Jason Gunthorpe
2024-02-23 15:18               ` Jason Gunthorpe
2024-02-27 12:43               ` Will Deacon
2024-02-27 12:43                 ` Will Deacon
2024-02-29 13:57                 ` Jason Gunthorpe
2024-02-29 13:57                   ` Jason Gunthorpe
2024-02-06 15:12 ` [PATCH v5 02/17] iommu/arm-smmu-v3: Consolidate the STE generation for abort/bypass Jason Gunthorpe
2024-02-06 15:12   ` Jason Gunthorpe
2024-02-15 17:27   ` Robin Murphy
2024-02-15 17:27     ` Robin Murphy
2024-02-22 17:40     ` Will Deacon
2024-02-22 17:40       ` Will Deacon
2024-02-23 18:53     ` Jason Gunthorpe
2024-02-23 18:53       ` Jason Gunthorpe
2024-02-27 10:50       ` Will Deacon
2024-02-27 10:50         ` Will Deacon
2024-02-06 15:12 ` [PATCH v5 03/17] iommu/arm-smmu-v3: Move arm_smmu_rmr_install_bypass_ste() Jason Gunthorpe
2024-02-06 15:12   ` Jason Gunthorpe
2024-02-13 15:37   ` Mostafa Saleh
2024-02-13 15:37     ` Mostafa Saleh
2024-02-13 16:16     ` Jason Gunthorpe
2024-02-13 16:16       ` Jason Gunthorpe
2024-02-13 16:46       ` Mostafa Saleh
2024-02-13 16:46         ` Mostafa Saleh
2024-02-15 19:01     ` Robin Murphy
2024-02-15 19:01       ` Robin Murphy
2024-02-15 21:18       ` Jason Gunthorpe
2024-02-15 21:18         ` Jason Gunthorpe
2024-02-06 15:12 ` [PATCH v5 04/17] iommu/arm-smmu-v3: Move the STE generation for S1 and S2 domains into functions Jason Gunthorpe
2024-02-06 15:12   ` Jason Gunthorpe
2024-02-16 17:12   ` Jason Gunthorpe
2024-02-16 17:12     ` Jason Gunthorpe
2024-02-16 17:39     ` Will Deacon
2024-02-16 17:39       ` Will Deacon
2024-02-16 17:58       ` Jason Gunthorpe
2024-02-16 17:58         ` Jason Gunthorpe
2024-02-06 15:12 ` [PATCH v5 05/17] iommu/arm-smmu-v3: Build the whole STE in arm_smmu_make_s2_domain_ste() Jason Gunthorpe
2024-02-06 15:12   ` Jason Gunthorpe
2024-02-06 15:12 ` [PATCH v5 06/17] iommu/arm-smmu-v3: Hold arm_smmu_asid_lock during all of attach_dev Jason Gunthorpe
2024-02-06 15:12   ` Jason Gunthorpe
2024-02-13 15:38   ` Mostafa Saleh
2024-02-13 15:38     ` Mostafa Saleh
2024-02-13 16:18     ` Jason Gunthorpe [this message]
2024-02-13 16:18       ` Jason Gunthorpe
2024-02-06 15:12 ` [PATCH v5 07/17] iommu/arm-smmu-v3: Compute the STE only once for each master Jason Gunthorpe
2024-02-06 15:12   ` Jason Gunthorpe
2024-02-06 15:12 ` [PATCH v5 08/17] iommu/arm-smmu-v3: Do not change the STE twice during arm_smmu_attach_dev() Jason Gunthorpe
2024-02-06 15:12   ` Jason Gunthorpe
2024-02-13 15:40   ` Mostafa Saleh
2024-02-13 15:40     ` Mostafa Saleh
2024-02-13 16:26     ` Jason Gunthorpe
2024-02-13 16:26       ` Jason Gunthorpe
2024-02-06 15:12 ` [PATCH v5 09/17] iommu/arm-smmu-v3: Put writing the context descriptor in the right order Jason Gunthorpe
2024-02-06 15:12   ` Jason Gunthorpe
2024-02-13 15:42   ` Mostafa Saleh
2024-02-13 15:42     ` Mostafa Saleh
2024-02-13 17:50     ` Jason Gunthorpe
2024-02-13 17:50       ` Jason Gunthorpe
2024-02-06 15:12 ` [PATCH v5 10/17] iommu/arm-smmu-v3: Pass smmu_domain to arm_enable/disable_ats() Jason Gunthorpe
2024-02-06 15:12   ` Jason Gunthorpe
2024-02-13 15:43   ` Mostafa Saleh
2024-02-13 15:43     ` Mostafa Saleh
2024-02-06 15:12 ` [PATCH v5 11/17] iommu/arm-smmu-v3: Remove arm_smmu_master->domain Jason Gunthorpe
2024-02-06 15:12   ` Jason Gunthorpe
2024-02-13 15:45   ` Mostafa Saleh
2024-02-13 15:45     ` Mostafa Saleh
2024-02-13 16:37     ` Jason Gunthorpe
2024-02-13 16:37       ` Jason Gunthorpe
2024-02-13 17:00       ` Mostafa Saleh
2024-02-13 17:00         ` Mostafa Saleh
2024-02-06 15:12 ` [PATCH v5 12/17] iommu/arm-smmu-v3: Check that the RID domain is S1 in SVA Jason Gunthorpe
2024-02-06 15:12   ` Jason Gunthorpe
2024-02-06 15:12 ` [PATCH v5 13/17] iommu/arm-smmu-v3: Add a global static IDENTITY domain Jason Gunthorpe
2024-02-06 15:12   ` Jason Gunthorpe
2024-02-06 15:12 ` [PATCH v5 14/17] iommu/arm-smmu-v3: Add a global static BLOCKED domain Jason Gunthorpe
2024-02-06 15:12   ` Jason Gunthorpe
2024-02-06 15:12 ` [PATCH v5 15/17] iommu/arm-smmu-v3: Use the identity/blocked domain during release Jason Gunthorpe
2024-02-06 15:12   ` Jason Gunthorpe
2024-02-06 15:12 ` [PATCH v5 16/17] iommu/arm-smmu-v3: Pass arm_smmu_domain and arm_smmu_device to finalize Jason Gunthorpe
2024-02-06 15:12   ` Jason Gunthorpe
2024-02-06 15:12 ` [PATCH v5 17/17] iommu/arm-smmu-v3: Convert to domain_alloc_paging() Jason Gunthorpe
2024-02-06 15:12   ` Jason Gunthorpe
2024-02-07  5:27 ` [PATCH v5 00/17] Update SMMUv3 to the modern iommu API (part 1/3) Nicolin Chen
2024-02-07  5:27   ` Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240213161858.GC1088888@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=iommu@lists.linux.dev \
    --cc=jean-philippe@linaro.org \
    --cc=joro@8bytes.org \
    --cc=jroedel@suse.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mdf@kernel.org \
    --cc=moritzf@google.com \
    --cc=mshavit@google.com \
    --cc=nicolinc@nvidia.com \
    --cc=patches@lists.linux.dev \
    --cc=robin.murphy@arm.com \
    --cc=shameerali.kolothum.thodi@huawei.com \
    --cc=smostafa@google.com \
    --cc=will@kernel.org \
    --cc=zhangfei.gao@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.