From: Rob Herring <robh@kernel.org>
To: "Théo Lebrun" <theo.lebrun@bootlin.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Andi Shyti <andi.shyti@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org,
Gregory Clement <gregory.clement@bootlin.com>,
Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Tawfik Bayouk <tawfik.bayouk@mobileye.com>
Subject: Re: [PATCH 01/13] dt-bindings: i2c: nomadik: add timeout-usecs property bindings
Date: Thu, 15 Feb 2024 20:27:04 -0600 [thread overview]
Message-ID: <20240216022704.GB850600-robh@kernel.org> (raw)
In-Reply-To: <20240215-mbly-i2c-v1-1-19a336e91dca@bootlin.com>
On Thu, Feb 15, 2024 at 05:52:08PM +0100, Théo Lebrun wrote:
> Expose I2C device timeout configuration from devicetree. Use µs as time
> unit and express it in the name.
>
> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
> ---
> Documentation/devicetree/bindings/i2c/st,nomadik-i2c.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/st,nomadik-i2c.yaml b/Documentation/devicetree/bindings/i2c/st,nomadik-i2c.yaml
> index 16024415a4a7..e6b95e3765ac 100644
> --- a/Documentation/devicetree/bindings/i2c/st,nomadik-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/st,nomadik-i2c.yaml
> @@ -70,6 +70,10 @@ properties:
> minimum: 1
> maximum: 400000
>
> + timeout-usecs:
Use standard unit suffixes.
We already have at least 2 device specific timeout properties. This one
should be common. That means you need to add it to i2c-controller.yaml
in dtschema. GH PR or patch to devicetree-spec list is fine.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "Théo Lebrun" <theo.lebrun@bootlin.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Andi Shyti <andi.shyti@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org,
Gregory Clement <gregory.clement@bootlin.com>,
Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Tawfik Bayouk <tawfik.bayouk@mobileye.com>
Subject: Re: [PATCH 01/13] dt-bindings: i2c: nomadik: add timeout-usecs property bindings
Date: Thu, 15 Feb 2024 20:27:04 -0600 [thread overview]
Message-ID: <20240216022704.GB850600-robh@kernel.org> (raw)
In-Reply-To: <20240215-mbly-i2c-v1-1-19a336e91dca@bootlin.com>
On Thu, Feb 15, 2024 at 05:52:08PM +0100, Théo Lebrun wrote:
> Expose I2C device timeout configuration from devicetree. Use µs as time
> unit and express it in the name.
>
> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
> ---
> Documentation/devicetree/bindings/i2c/st,nomadik-i2c.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/st,nomadik-i2c.yaml b/Documentation/devicetree/bindings/i2c/st,nomadik-i2c.yaml
> index 16024415a4a7..e6b95e3765ac 100644
> --- a/Documentation/devicetree/bindings/i2c/st,nomadik-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/st,nomadik-i2c.yaml
> @@ -70,6 +70,10 @@ properties:
> minimum: 1
> maximum: 400000
>
> + timeout-usecs:
Use standard unit suffixes.
We already have at least 2 device specific timeout properties. This one
should be common. That means you need to add it to i2c-controller.yaml
in dtschema. GH PR or patch to devicetree-spec list is fine.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-16 2:27 UTC|newest]
Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 16:52 [PATCH 00/13] Add Mobileye EyeQ5 support to the Nomadik I2C controller & use hrtimers for timeouts Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-15 16:52 ` [PATCH 01/13] dt-bindings: i2c: nomadik: add timeout-usecs property bindings Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-16 2:27 ` Rob Herring [this message]
2024-02-16 2:27 ` Rob Herring
2024-02-16 9:16 ` Théo Lebrun
2024-02-16 9:16 ` Théo Lebrun
2024-02-16 9:17 ` Krzysztof Kozlowski
2024-02-16 9:17 ` Krzysztof Kozlowski
2024-02-19 14:06 ` Linus Walleij
2024-02-19 14:06 ` Linus Walleij
2024-02-19 14:29 ` Théo Lebrun
2024-02-19 14:29 ` Théo Lebrun
2024-02-21 16:58 ` Théo Lebrun
2024-02-21 16:58 ` Théo Lebrun
2024-02-21 17:43 ` Wolfram Sang
2024-02-21 17:43 ` Wolfram Sang
2024-02-22 17:14 ` Rob Herring
2024-02-22 17:14 ` Rob Herring
2024-02-22 19:28 ` Wolfram Sang
2024-02-22 19:28 ` Wolfram Sang
2024-02-23 16:34 ` Rob Herring
2024-02-23 16:34 ` Rob Herring
2024-02-26 8:41 ` Wolfram Sang
2024-02-26 8:41 ` Wolfram Sang
2024-02-15 16:52 ` [PATCH 02/13] dt-bindings: i2c: nomadik: add mobileye,eyeq5-i2c bindings and example Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-15 19:26 ` Rob Herring
2024-02-15 19:26 ` Rob Herring
2024-02-16 2:22 ` Rob Herring
2024-02-16 2:22 ` Rob Herring
2024-02-16 10:18 ` Théo Lebrun
2024-02-16 10:18 ` Théo Lebrun
2024-02-16 10:33 ` Krzysztof Kozlowski
2024-02-16 10:33 ` Krzysztof Kozlowski
2024-02-16 10:40 ` Théo Lebrun
2024-02-16 10:40 ` Théo Lebrun
2024-02-17 8:25 ` Krzysztof Kozlowski
2024-02-17 8:25 ` Krzysztof Kozlowski
2024-02-19 13:41 ` Théo Lebrun
2024-02-19 13:41 ` Théo Lebrun
2024-02-20 9:49 ` Krzysztof Kozlowski
2024-02-20 9:49 ` Krzysztof Kozlowski
2024-02-15 16:52 ` [PATCH 03/13] dt-bindings: hwmon: lm75: add label property Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-16 7:41 ` Krzysztof Kozlowski
2024-02-16 7:41 ` Krzysztof Kozlowski
2024-02-16 8:00 ` Krzysztof Kozlowski
2024-02-16 8:00 ` Krzysztof Kozlowski
2024-02-16 10:22 ` Théo Lebrun
2024-02-16 10:22 ` Théo Lebrun
2024-02-24 17:30 ` Guenter Roeck
2024-02-24 17:30 ` Guenter Roeck
2024-02-26 7:43 ` Krzysztof Kozlowski
2024-02-26 7:43 ` Krzysztof Kozlowski
2024-02-15 16:52 ` [PATCH 04/13] i2c: nomadik: rename private struct pointers from dev to priv Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-19 14:12 ` Linus Walleij
2024-02-19 14:12 ` Linus Walleij
2024-02-15 16:52 ` [PATCH 05/13] i2c: nomadik: simplify IRQ masking logic Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-19 14:15 ` Linus Walleij
2024-02-19 14:15 ` Linus Walleij
2024-02-15 16:52 ` [PATCH 06/13] i2c: nomadik: use bitops helpers Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-19 14:16 ` Linus Walleij
2024-02-19 14:16 ` Linus Walleij
2024-02-15 16:52 ` [PATCH 07/13] i2c: nomadik: support short xfer timeouts using waitqueue & hrtimer Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-19 14:19 ` Linus Walleij
2024-02-19 14:19 ` Linus Walleij
2024-02-19 14:31 ` Théo Lebrun
2024-02-19 14:31 ` Théo Lebrun
2024-02-15 16:52 ` [PATCH 08/13] i2c: nomadik: replace jiffies by ktime for FIFO flushing timeout Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-19 14:21 ` Linus Walleij
2024-02-19 14:21 ` Linus Walleij
2024-02-19 14:38 ` Théo Lebrun
2024-02-19 14:38 ` Théo Lebrun
2024-02-19 14:53 ` Linus Walleij
2024-02-19 14:53 ` Linus Walleij
2024-02-15 16:52 ` [PATCH 09/13] i2c: nomadik: fetch timeout-usecs property from devicetree Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-19 14:22 ` Linus Walleij
2024-02-19 14:22 ` Linus Walleij
2024-02-27 12:14 ` Wolfram Sang
2024-02-27 12:14 ` Wolfram Sang
2024-02-27 13:38 ` Théo Lebrun
2024-02-27 13:38 ` Théo Lebrun
2024-02-28 10:49 ` Wolfram Sang
2024-02-28 10:49 ` Wolfram Sang
2024-02-28 13:39 ` Théo Lebrun
2024-02-28 13:39 ` Théo Lebrun
2024-02-29 9:25 ` Wolfram Sang
2024-02-29 9:25 ` Wolfram Sang
2024-02-29 9:31 ` Théo Lebrun
2024-02-29 9:31 ` Théo Lebrun
2024-02-15 16:52 ` [PATCH 10/13] i2c: nomadik: support Mobileye EyeQ5 I2C controller Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-19 14:35 ` Linus Walleij
2024-02-19 14:35 ` Linus Walleij
2024-02-19 14:52 ` Théo Lebrun
2024-02-19 14:52 ` Théo Lebrun
2024-02-19 16:27 ` Théo Lebrun
2024-02-19 16:27 ` Théo Lebrun
2024-02-15 16:52 ` [PATCH 11/13] MIPS: mobileye: eyeq5: add 5 I2C controller nodes Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-15 16:52 ` [PATCH 12/13] MIPS: mobileye: eyeq5: add evaluation board I2C temp sensor Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-16 7:59 ` Krzysztof Kozlowski
2024-02-16 7:59 ` Krzysztof Kozlowski
2024-02-15 16:52 ` [PATCH 13/13] MIPS: mobileye: eyeq5: add resets to I2C controllers Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-16 7:59 ` Krzysztof Kozlowski
2024-02-16 7:59 ` Krzysztof Kozlowski
2024-02-16 9:05 ` Théo Lebrun
2024-02-16 9:05 ` Théo Lebrun
2024-02-16 9:17 ` Krzysztof Kozlowski
2024-02-16 9:17 ` Krzysztof Kozlowski
2024-02-16 10:26 ` Théo Lebrun
2024-02-16 10:26 ` Théo Lebrun
2024-02-19 14:11 ` [PATCH 00/13] Add Mobileye EyeQ5 support to the Nomadik I2C controller & use hrtimers for timeouts Linus Walleij
2024-02-19 14:11 ` Linus Walleij
2024-02-19 14:22 ` Théo Lebrun
2024-02-19 14:22 ` Théo Lebrun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240216022704.GB850600-robh@kernel.org \
--to=robh@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tawfik.bayouk@mobileye.com \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tsbogend@alpha.franken.de \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.