From: Wolfram Sang <wsa@kernel.org>
To: "Théo Lebrun" <theo.lebrun@bootlin.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Andi Shyti <andi.shyti@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org,
Gregory Clement <gregory.clement@bootlin.com>,
Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Tawfik Bayouk <tawfik.bayouk@mobileye.com>
Subject: Re: [PATCH 09/13] i2c: nomadik: fetch timeout-usecs property from devicetree
Date: Tue, 27 Feb 2024 13:14:28 +0100 [thread overview]
Message-ID: <Zd3SJMBp23ybgdsJ@shikoro> (raw)
In-Reply-To: <20240215-mbly-i2c-v1-9-19a336e91dca@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 416 bytes --]
> + /* Slave response timeout */
> + if (!of_property_read_u32(np, "timeout-usecs", &timeout_usecs))
> + priv->timeout_usecs = timeout_usecs;
> + else
> + priv->timeout_usecs = 200 * USEC_PER_MSEC;
I could imagine to add 'transfer_timeout_us' to struct i2c_timings.
Then, you could use 'i2c_parse_fw_timings' to obtain the value. What
values/value range do you use here? I can't find them in the DTS
additions.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: "Théo Lebrun" <theo.lebrun@bootlin.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Andi Shyti <andi.shyti@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org,
Gregory Clement <gregory.clement@bootlin.com>,
Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Tawfik Bayouk <tawfik.bayouk@mobileye.com>
Subject: Re: [PATCH 09/13] i2c: nomadik: fetch timeout-usecs property from devicetree
Date: Tue, 27 Feb 2024 13:14:28 +0100 [thread overview]
Message-ID: <Zd3SJMBp23ybgdsJ@shikoro> (raw)
In-Reply-To: <20240215-mbly-i2c-v1-9-19a336e91dca@bootlin.com>
[-- Attachment #1.1: Type: text/plain, Size: 416 bytes --]
> + /* Slave response timeout */
> + if (!of_property_read_u32(np, "timeout-usecs", &timeout_usecs))
> + priv->timeout_usecs = timeout_usecs;
> + else
> + priv->timeout_usecs = 200 * USEC_PER_MSEC;
I could imagine to add 'transfer_timeout_us' to struct i2c_timings.
Then, you could use 'i2c_parse_fw_timings' to obtain the value. What
values/value range do you use here? I can't find them in the DTS
additions.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-27 12:14 UTC|newest]
Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 16:52 [PATCH 00/13] Add Mobileye EyeQ5 support to the Nomadik I2C controller & use hrtimers for timeouts Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-15 16:52 ` [PATCH 01/13] dt-bindings: i2c: nomadik: add timeout-usecs property bindings Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-16 2:27 ` Rob Herring
2024-02-16 2:27 ` Rob Herring
2024-02-16 9:16 ` Théo Lebrun
2024-02-16 9:16 ` Théo Lebrun
2024-02-16 9:17 ` Krzysztof Kozlowski
2024-02-16 9:17 ` Krzysztof Kozlowski
2024-02-19 14:06 ` Linus Walleij
2024-02-19 14:06 ` Linus Walleij
2024-02-19 14:29 ` Théo Lebrun
2024-02-19 14:29 ` Théo Lebrun
2024-02-21 16:58 ` Théo Lebrun
2024-02-21 16:58 ` Théo Lebrun
2024-02-21 17:43 ` Wolfram Sang
2024-02-21 17:43 ` Wolfram Sang
2024-02-22 17:14 ` Rob Herring
2024-02-22 17:14 ` Rob Herring
2024-02-22 19:28 ` Wolfram Sang
2024-02-22 19:28 ` Wolfram Sang
2024-02-23 16:34 ` Rob Herring
2024-02-23 16:34 ` Rob Herring
2024-02-26 8:41 ` Wolfram Sang
2024-02-26 8:41 ` Wolfram Sang
2024-02-15 16:52 ` [PATCH 02/13] dt-bindings: i2c: nomadik: add mobileye,eyeq5-i2c bindings and example Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-15 19:26 ` Rob Herring
2024-02-15 19:26 ` Rob Herring
2024-02-16 2:22 ` Rob Herring
2024-02-16 2:22 ` Rob Herring
2024-02-16 10:18 ` Théo Lebrun
2024-02-16 10:18 ` Théo Lebrun
2024-02-16 10:33 ` Krzysztof Kozlowski
2024-02-16 10:33 ` Krzysztof Kozlowski
2024-02-16 10:40 ` Théo Lebrun
2024-02-16 10:40 ` Théo Lebrun
2024-02-17 8:25 ` Krzysztof Kozlowski
2024-02-17 8:25 ` Krzysztof Kozlowski
2024-02-19 13:41 ` Théo Lebrun
2024-02-19 13:41 ` Théo Lebrun
2024-02-20 9:49 ` Krzysztof Kozlowski
2024-02-20 9:49 ` Krzysztof Kozlowski
2024-02-15 16:52 ` [PATCH 03/13] dt-bindings: hwmon: lm75: add label property Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-16 7:41 ` Krzysztof Kozlowski
2024-02-16 7:41 ` Krzysztof Kozlowski
2024-02-16 8:00 ` Krzysztof Kozlowski
2024-02-16 8:00 ` Krzysztof Kozlowski
2024-02-16 10:22 ` Théo Lebrun
2024-02-16 10:22 ` Théo Lebrun
2024-02-24 17:30 ` Guenter Roeck
2024-02-24 17:30 ` Guenter Roeck
2024-02-26 7:43 ` Krzysztof Kozlowski
2024-02-26 7:43 ` Krzysztof Kozlowski
2024-02-15 16:52 ` [PATCH 04/13] i2c: nomadik: rename private struct pointers from dev to priv Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-19 14:12 ` Linus Walleij
2024-02-19 14:12 ` Linus Walleij
2024-02-15 16:52 ` [PATCH 05/13] i2c: nomadik: simplify IRQ masking logic Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-19 14:15 ` Linus Walleij
2024-02-19 14:15 ` Linus Walleij
2024-02-15 16:52 ` [PATCH 06/13] i2c: nomadik: use bitops helpers Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-19 14:16 ` Linus Walleij
2024-02-19 14:16 ` Linus Walleij
2024-02-15 16:52 ` [PATCH 07/13] i2c: nomadik: support short xfer timeouts using waitqueue & hrtimer Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-19 14:19 ` Linus Walleij
2024-02-19 14:19 ` Linus Walleij
2024-02-19 14:31 ` Théo Lebrun
2024-02-19 14:31 ` Théo Lebrun
2024-02-15 16:52 ` [PATCH 08/13] i2c: nomadik: replace jiffies by ktime for FIFO flushing timeout Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-19 14:21 ` Linus Walleij
2024-02-19 14:21 ` Linus Walleij
2024-02-19 14:38 ` Théo Lebrun
2024-02-19 14:38 ` Théo Lebrun
2024-02-19 14:53 ` Linus Walleij
2024-02-19 14:53 ` Linus Walleij
2024-02-15 16:52 ` [PATCH 09/13] i2c: nomadik: fetch timeout-usecs property from devicetree Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-19 14:22 ` Linus Walleij
2024-02-19 14:22 ` Linus Walleij
2024-02-27 12:14 ` Wolfram Sang [this message]
2024-02-27 12:14 ` Wolfram Sang
2024-02-27 13:38 ` Théo Lebrun
2024-02-27 13:38 ` Théo Lebrun
2024-02-28 10:49 ` Wolfram Sang
2024-02-28 10:49 ` Wolfram Sang
2024-02-28 13:39 ` Théo Lebrun
2024-02-28 13:39 ` Théo Lebrun
2024-02-29 9:25 ` Wolfram Sang
2024-02-29 9:25 ` Wolfram Sang
2024-02-29 9:31 ` Théo Lebrun
2024-02-29 9:31 ` Théo Lebrun
2024-02-15 16:52 ` [PATCH 10/13] i2c: nomadik: support Mobileye EyeQ5 I2C controller Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-19 14:35 ` Linus Walleij
2024-02-19 14:35 ` Linus Walleij
2024-02-19 14:52 ` Théo Lebrun
2024-02-19 14:52 ` Théo Lebrun
2024-02-19 16:27 ` Théo Lebrun
2024-02-19 16:27 ` Théo Lebrun
2024-02-15 16:52 ` [PATCH 11/13] MIPS: mobileye: eyeq5: add 5 I2C controller nodes Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-15 16:52 ` [PATCH 12/13] MIPS: mobileye: eyeq5: add evaluation board I2C temp sensor Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-16 7:59 ` Krzysztof Kozlowski
2024-02-16 7:59 ` Krzysztof Kozlowski
2024-02-15 16:52 ` [PATCH 13/13] MIPS: mobileye: eyeq5: add resets to I2C controllers Théo Lebrun
2024-02-15 16:52 ` Théo Lebrun
2024-02-16 7:59 ` Krzysztof Kozlowski
2024-02-16 7:59 ` Krzysztof Kozlowski
2024-02-16 9:05 ` Théo Lebrun
2024-02-16 9:05 ` Théo Lebrun
2024-02-16 9:17 ` Krzysztof Kozlowski
2024-02-16 9:17 ` Krzysztof Kozlowski
2024-02-16 10:26 ` Théo Lebrun
2024-02-16 10:26 ` Théo Lebrun
2024-02-19 14:11 ` [PATCH 00/13] Add Mobileye EyeQ5 support to the Nomadik I2C controller & use hrtimers for timeouts Linus Walleij
2024-02-19 14:11 ` Linus Walleij
2024-02-19 14:22 ` Théo Lebrun
2024-02-19 14:22 ` Théo Lebrun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zd3SJMBp23ybgdsJ@shikoro \
--to=wsa@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tawfik.bayouk@mobileye.com \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tsbogend@alpha.franken.de \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.