All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: William Zhang <william.zhang@broadcom.com>
Cc: Linux MTD List <linux-mtd@lists.infradead.org>,
	Linux ARM List <linux-arm-kernel@lists.infradead.org>,
	Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>,
	f.fainelli@gmail.com, kursad.oney@broadcom.com,
	joel.peshkin@broadcom.com, anand.gore@broadcom.com,
	dregan@mail.com, kamal.dasu@broadcom.com,
	tomer.yacoby@broadcom.com, dan.beygelman@broadcom.com,
	David Regan <dregan@broadcom.com>,
	linux-kernel@vger.kernel.org,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Brian Norris <computersforpeace@gmail.com>,
	Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH v5 09/12] mtd: rawnand: brcmnand: Add support for getting ecc setting from strap
Date: Tue, 20 Feb 2024 10:58:24 +0100	[thread overview]
Message-ID: <20240220105824.76556c51@xps-13> (raw)
In-Reply-To: <20240207202257.271784-10-william.zhang@broadcom.com>

Hi William,

william.zhang@broadcom.com wrote on Wed,  7 Feb 2024 12:22:54 -0800:

> BCMBCA broadband SoC based board design does not specify ecc setting in
> dts but rather use the SoC NAND strap info to obtain the ecc strength
> and spare area size setting. Add brcm,nand-ecc-use-strap dts propety for
> this purpose and update driver to support this option.
> 
> The generic nand ecc settings still take precedence over this flag. For

And this sentence can also be dropped. Please mention they cannot be
used at the same time.

> example, if nand-ecc-strength is set in the dts, the driver ignores the
> strap setting and falls back to original behavior. This makes sure that
> the existing BCMBCA board dts still works the old way even the strap
> flag is set in the BCMBCA chip dtsi.

I think I already said this was a bad idea IMHO :-)

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: William Zhang <william.zhang@broadcom.com>
Cc: Linux MTD List <linux-mtd@lists.infradead.org>,
	Linux ARM List <linux-arm-kernel@lists.infradead.org>,
	Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>,
	f.fainelli@gmail.com, kursad.oney@broadcom.com,
	joel.peshkin@broadcom.com, anand.gore@broadcom.com,
	dregan@mail.com, kamal.dasu@broadcom.com,
	tomer.yacoby@broadcom.com, dan.beygelman@broadcom.com,
	David Regan <dregan@broadcom.com>,
	linux-kernel@vger.kernel.org,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Brian Norris <computersforpeace@gmail.com>,
	Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH v5 09/12] mtd: rawnand: brcmnand: Add support for getting ecc setting from strap
Date: Tue, 20 Feb 2024 10:58:24 +0100	[thread overview]
Message-ID: <20240220105824.76556c51@xps-13> (raw)
In-Reply-To: <20240207202257.271784-10-william.zhang@broadcom.com>

Hi William,

william.zhang@broadcom.com wrote on Wed,  7 Feb 2024 12:22:54 -0800:

> BCMBCA broadband SoC based board design does not specify ecc setting in
> dts but rather use the SoC NAND strap info to obtain the ecc strength
> and spare area size setting. Add brcm,nand-ecc-use-strap dts propety for
> this purpose and update driver to support this option.
> 
> The generic nand ecc settings still take precedence over this flag. For

And this sentence can also be dropped. Please mention they cannot be
used at the same time.

> example, if nand-ecc-strength is set in the dts, the driver ignores the
> strap setting and falls back to original behavior. This makes sure that
> the existing BCMBCA board dts still works the old way even the strap
> flag is set in the BCMBCA chip dtsi.

I think I already said this was a bad idea IMHO :-)

Thanks,
Miquèl

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: William Zhang <william.zhang@broadcom.com>
Cc: Linux MTD List <linux-mtd@lists.infradead.org>,
	Linux ARM List <linux-arm-kernel@lists.infradead.org>,
	Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>,
	f.fainelli@gmail.com, kursad.oney@broadcom.com,
	joel.peshkin@broadcom.com, anand.gore@broadcom.com,
	dregan@mail.com, kamal.dasu@broadcom.com,
	tomer.yacoby@broadcom.com, dan.beygelman@broadcom.com,
	David Regan <dregan@broadcom.com>,
	linux-kernel@vger.kernel.org,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Brian Norris <computersforpeace@gmail.com>,
	Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH v5 09/12] mtd: rawnand: brcmnand: Add support for getting ecc setting from strap
Date: Tue, 20 Feb 2024 10:58:24 +0100	[thread overview]
Message-ID: <20240220105824.76556c51@xps-13> (raw)
In-Reply-To: <20240207202257.271784-10-william.zhang@broadcom.com>

Hi William,

william.zhang@broadcom.com wrote on Wed,  7 Feb 2024 12:22:54 -0800:

> BCMBCA broadband SoC based board design does not specify ecc setting in
> dts but rather use the SoC NAND strap info to obtain the ecc strength
> and spare area size setting. Add brcm,nand-ecc-use-strap dts propety for
> this purpose and update driver to support this option.
> 
> The generic nand ecc settings still take precedence over this flag. For

And this sentence can also be dropped. Please mention they cannot be
used at the same time.

> example, if nand-ecc-strength is set in the dts, the driver ignores the
> strap setting and falls back to original behavior. This makes sure that
> the existing BCMBCA board dts still works the old way even the strap
> flag is set in the BCMBCA chip dtsi.

I think I already said this was a bad idea IMHO :-)

Thanks,
Miquèl

  parent reply	other threads:[~2024-02-20  9:58 UTC|newest]

Thread overview: 102+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-07 20:22 [PATCH v5 00/12] mtd: rawnand: brcmnand: driver and doc updates William Zhang
2024-02-07 20:22 ` William Zhang
2024-02-07 20:22 ` William Zhang
2024-02-07 20:22 ` [PATCH v5 01/12] dt-bindings: mtd: brcmnand: Updates for bcmbca SoCs William Zhang
2024-02-07 20:22   ` William Zhang
2024-02-07 20:22   ` William Zhang
2024-02-22  0:34   ` Florian Fainelli
2024-02-22  0:34     ` Florian Fainelli
2024-02-22  0:34     ` Florian Fainelli
2024-02-07 20:22 ` [PATCH v5 02/12] dt-bindings: mtd: brcmnand: Add WP pin connection property William Zhang
2024-02-07 20:22   ` William Zhang
2024-02-07 20:22   ` William Zhang
2024-02-09 17:34   ` Conor Dooley
2024-02-09 17:34     ` Conor Dooley
2024-02-09 17:34     ` Conor Dooley
2024-02-22  0:35   ` Florian Fainelli
2024-02-22  0:35     ` Florian Fainelli
2024-02-22  0:35     ` Florian Fainelli
2024-02-07 20:22 ` [PATCH v5 03/12] dt-bindings: mtd: brcmnand: Add ecc strap property William Zhang
2024-02-07 20:22   ` William Zhang
2024-02-07 20:22   ` William Zhang
2024-02-09 17:42   ` Conor Dooley
2024-02-09 17:42     ` Conor Dooley
2024-02-09 17:42     ` Conor Dooley
2024-02-20  9:56   ` Miquel Raynal
2024-02-20  9:56     ` Miquel Raynal
2024-02-20  9:56     ` Miquel Raynal
2024-02-07 20:22 ` [PATCH v5 04/12] ARM: dts: broadcom: bcmbca: Add NAND controller node William Zhang
2024-02-07 20:22   ` William Zhang
2024-02-07 20:22   ` William Zhang
2024-02-22  0:39   ` Florian Fainelli
2024-02-22  0:39     ` Florian Fainelli
2024-02-22  0:39     ` Florian Fainelli
2024-02-22  7:01     ` William Zhang
2024-02-22  7:01       ` William Zhang
2024-02-22  7:01       ` William Zhang
2024-02-07 20:22 ` [PATCH v5 05/12] arm64: " William Zhang
2024-02-07 20:22   ` William Zhang
2024-02-07 20:22   ` William Zhang
2024-02-22  8:27   ` Rafał Miłecki
2024-02-22  8:27     ` Rafał Miłecki
2024-02-22  8:27     ` Rafał Miłecki
2024-02-22 16:21     ` William Zhang
2024-02-22 16:21       ` William Zhang
2024-02-22 16:21       ` William Zhang
2024-02-07 20:22 ` [PATCH v5 06/12] arm64: dts: broadcom: bcmbca: Update router boards William Zhang
2024-02-07 20:22   ` William Zhang
2024-02-07 20:22   ` William Zhang
2024-02-22  0:37   ` Florian Fainelli
2024-02-22  0:37     ` Florian Fainelli
2024-02-22  0:37     ` Florian Fainelli
2024-02-22  0:40     ` Florian Fainelli
2024-02-22  0:40       ` Florian Fainelli
2024-02-22  0:40       ` Florian Fainelli
2024-02-22  7:02       ` William Zhang
2024-02-22  7:02         ` William Zhang
2024-02-22  7:02         ` William Zhang
2024-02-07 20:22 ` [PATCH v5 07/12] mtd: rawnand: brcmnand: Rename bcm63138 nand driver William Zhang
2024-02-07 20:22   ` William Zhang
2024-02-07 20:22   ` William Zhang
2024-02-07 20:22 ` [PATCH v5 08/12] mtd: rawnand: brcmnand: Add BCMBCA read data bus interface William Zhang
2024-02-07 20:22   ` William Zhang
2024-02-07 20:22   ` William Zhang
2024-02-07 20:22 ` [PATCH v5 09/12] mtd: rawnand: brcmnand: Add support for getting ecc setting from strap William Zhang
2024-02-07 20:22   ` William Zhang
2024-02-07 20:22   ` William Zhang
2024-02-20  9:53   ` Miquel Raynal
2024-02-20  9:53     ` Miquel Raynal
2024-02-20  9:53     ` Miquel Raynal
2024-02-23  3:35     ` William Zhang
2024-02-23  3:35       ` William Zhang
2024-02-23  3:35       ` William Zhang
2024-02-20  9:58   ` Miquel Raynal [this message]
2024-02-20  9:58     ` Miquel Raynal
2024-02-20  9:58     ` Miquel Raynal
2024-02-07 20:22 ` [PATCH v5 10/12] mtd: rawnand: brcmnand: Support write protection setting from dts William Zhang
2024-02-07 20:22   ` William Zhang
2024-02-07 20:22   ` William Zhang
2024-02-07 20:22 ` [PATCH v5 11/12] mtd: rawnand: brcmnand: exec_op helper functions return type fixes William Zhang
2024-02-07 20:22   ` William Zhang
2024-02-07 20:22   ` William Zhang
2024-02-20 10:01   ` Miquel Raynal
2024-02-20 10:01     ` Miquel Raynal
2024-02-20 10:01     ` Miquel Raynal
2024-02-20 10:02   ` Miquel Raynal
2024-02-20 10:02     ` Miquel Raynal
2024-02-20 10:02     ` Miquel Raynal
2024-02-21  1:11     ` William Zhang
2024-02-21  1:11       ` William Zhang
2024-02-21  1:11       ` William Zhang
2024-02-21  6:16     ` Dan Carpenter
2024-02-21  6:16       ` Dan Carpenter
2024-02-21  6:16       ` Dan Carpenter
2024-02-21  8:32       ` Miquel Raynal
2024-02-21  8:32         ` Miquel Raynal
2024-02-21  8:32         ` Miquel Raynal
2024-02-21 16:01         ` Florian Fainelli
2024-02-21 16:01           ` Florian Fainelli
2024-02-21 16:01           ` Florian Fainelli
2024-02-07 20:22 ` [PATCH v5 12/12] mtd: rawnand: brcmnand: update log level messages William Zhang
2024-02-07 20:22   ` William Zhang
2024-02-07 20:22   ` William Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240220105824.76556c51@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=anand.gore@broadcom.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=computersforpeace@gmail.com \
    --cc=dan.beygelman@broadcom.com \
    --cc=dregan@broadcom.com \
    --cc=dregan@mail.com \
    --cc=f.fainelli@gmail.com \
    --cc=joel.peshkin@broadcom.com \
    --cc=kamal.dasu@broadcom.com \
    --cc=kursad.oney@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=tomer.yacoby@broadcom.com \
    --cc=vigneshr@ti.com \
    --cc=william.zhang@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.