From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Louis Peens <louis.peens@corigine.com>,
David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, Fei Qin <fei.qin@corigine.com>,
netdev@vger.kernel.org, oss-drivers@corigine.com
Subject: Re: [PATCH net-next v2 1/4] devlink: add two info version tags
Date: Wed, 28 Feb 2024 20:32:35 -0800 [thread overview]
Message-ID: <20240228203235.22b5f122@kernel.org> (raw)
In-Reply-To: <Zd8js1wsTCxSLYxy@nanopsycho>
On Wed, 28 Feb 2024 13:14:43 +0100 Jiri Pirko wrote:
> >+/* Part number for entire product */
> >+#define DEVLINK_INFO_VERSION_GENERIC_PART_NUMBER "part_number"
>
> /* Part number, identifier of board design */
> #define DEVLINK_INFO_VERSION_GENERIC_BOARD_ID "board.id"
>
> Isn't this what you are looking for?
My memory is fading but AFAIR when I added the other IDs, back in my
Netronome days, the expectation was that they would be combined
together to form the part number.
Not sure why they need a separate one now, maybe they lost the docs,
maybe requirements changed. Would be good to know... :)
> "part_number" without domain (boards/asic/fw) does not look correct to
> me. "Product" sounds very odd.
I believe Part Number is what PCI VPD calls it.
In addition to Jiri's questions:
> +/* Model of the board */
> +#define DEVLINK_INFO_VERSION_GENERIC_BOARD_MODEL "board.model"
What's the difference between this and:
board.id
--------
Unique identifier of the board design.
? One is AMDA the other one is code name?
You gotta provide more guidance how the two differ...
next prev parent reply other threads:[~2024-02-29 4:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 7:51 [PATCH net-next v2 0/4] nfp: series of minor driver improvements Louis Peens
2024-02-28 7:51 ` [PATCH net-next v2 1/4] devlink: add two info version tags Louis Peens
2024-02-28 12:14 ` Jiri Pirko
2024-02-29 4:32 ` Jakub Kicinski [this message]
2024-03-07 8:17 ` Louis Peens
2024-03-07 8:40 ` Jiri Pirko
2024-03-07 11:06 ` Louis Peens
2024-03-07 11:32 ` Jiri Pirko
2024-03-08 0:59 ` Jakub Kicinski
2024-02-28 7:51 ` [PATCH net-next v2 2/4] nfp: update devlink device info output Louis Peens
2024-02-28 12:16 ` Jiri Pirko
2024-02-29 4:34 ` Jakub Kicinski
2024-03-07 8:22 ` Louis Peens
2024-02-28 7:51 ` [PATCH net-next v2 3/4] dim: introduce a specific dim profile for better latency Louis Peens
2024-02-28 7:51 ` [PATCH net-next v2 4/4] nfp: use new dim profiles " Louis Peens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240228203235.22b5f122@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=fei.qin@corigine.com \
--cc=jiri@resnulli.us \
--cc=louis.peens@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.