All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Louis Peens <louis.peens@corigine.com>
Cc: Jiri Pirko <jiri@resnulli.us>, David Miller <davem@davemloft.net>,
	Paolo Abeni <pabeni@redhat.com>, Fei Qin <fei.qin@corigine.com>,
	netdev@vger.kernel.org, oss-drivers@corigine.com
Subject: Re: [PATCH net-next v2 1/4] devlink: add two info version tags
Date: Thu, 7 Mar 2024 16:59:17 -0800	[thread overview]
Message-ID: <20240307165917.70acd8f1@kernel.org> (raw)
In-Reply-To: <Zeml4L6EUmlCHU37@nanopsycho>

On Thu, 7 Mar 2024 12:32:48 +0100 Jiri Pirko wrote:
> >I don't know if it is specific to us, that's the thing, maybe it is,
> >maybe it isn't. What I do know in our case is that "part_number" and
> >"board.id" is not the same thing, so we would prefer to have both visible.
> >I cannot comment if that is the case for others, if the concensus is
> >that others will find this helpful we don't mind adding it to devlink,
> >as we've done from v1 to v2 - exact naming disussion aside.
> >
> >Updated proposal after this comment, V3 would then be:
> >1) Keep "board.model" (the codename) local like it currently exist
> >in-tree.
> >2) Do still add "part_number" to devlink, but call it "board.part_number".
> >Looking at the existing options it probably does fit the closest with
> >board, it's not "fw", and I don't think it's "asic" either.
> >
> >Does this sound like the right track?  
> 
> Okay.

+1 

  reply	other threads:[~2024-03-08  0:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-28  7:51 [PATCH net-next v2 0/4] nfp: series of minor driver improvements Louis Peens
2024-02-28  7:51 ` [PATCH net-next v2 1/4] devlink: add two info version tags Louis Peens
2024-02-28 12:14   ` Jiri Pirko
2024-02-29  4:32     ` Jakub Kicinski
2024-03-07  8:17       ` Louis Peens
2024-03-07  8:40         ` Jiri Pirko
2024-03-07 11:06           ` Louis Peens
2024-03-07 11:32             ` Jiri Pirko
2024-03-08  0:59               ` Jakub Kicinski [this message]
2024-02-28  7:51 ` [PATCH net-next v2 2/4] nfp: update devlink device info output Louis Peens
2024-02-28 12:16   ` Jiri Pirko
2024-02-29  4:34   ` Jakub Kicinski
2024-03-07  8:22     ` Louis Peens
2024-02-28  7:51 ` [PATCH net-next v2 3/4] dim: introduce a specific dim profile for better latency Louis Peens
2024-02-28  7:51 ` [PATCH net-next v2 4/4] nfp: use new dim profiles " Louis Peens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240307165917.70acd8f1@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=fei.qin@corigine.com \
    --cc=jiri@resnulli.us \
    --cc=louis.peens@corigine.com \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@corigine.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.