From: Jakub Kicinski <kuba@kernel.org>
To: Louis Peens <louis.peens@corigine.com>
Cc: David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, Fei Qin <fei.qin@corigine.com>,
netdev@vger.kernel.org, oss-drivers@corigine.com
Subject: Re: [PATCH net-next v2 2/4] nfp: update devlink device info output
Date: Wed, 28 Feb 2024 20:34:58 -0800 [thread overview]
Message-ID: <20240228203458.4a7234f5@kernel.org> (raw)
In-Reply-To: <20240228075140.12085-3-louis.peens@corigine.com>
On Wed, 28 Feb 2024 09:51:38 +0200 Louis Peens wrote:
> + * - ``part_number``
> + - fixed
> + - Part number of the entire product
Belongs in the previous patch..
> * - ``fw.bundle_id``
> - stored, running
> - Firmware bundle id
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_devlink.c b/drivers/net/ethernet/netronome/nfp/nfp_devlink.c
> index 635d33c0d6d3..5b41338d55c4 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_devlink.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_devlink.c
> @@ -159,7 +159,8 @@ static const struct nfp_devlink_versions_simple {
> { DEVLINK_INFO_VERSION_GENERIC_BOARD_ID, "assembly.partno", },
> { DEVLINK_INFO_VERSION_GENERIC_BOARD_REV, "assembly.revision", },
> { DEVLINK_INFO_VERSION_GENERIC_BOARD_MANUFACTURE, "assembly.vendor", },
> - { "board.model", /* code name */ "assembly.model", },
> + { DEVLINK_INFO_VERSION_GENERIC_BOARD_MODEL, "assembly.model", },
Ah, it is the code name. I don't understand why you're trying to make
this generic. I never seen other vendors report code names for boards.
next prev parent reply other threads:[~2024-02-29 4:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 7:51 [PATCH net-next v2 0/4] nfp: series of minor driver improvements Louis Peens
2024-02-28 7:51 ` [PATCH net-next v2 1/4] devlink: add two info version tags Louis Peens
2024-02-28 12:14 ` Jiri Pirko
2024-02-29 4:32 ` Jakub Kicinski
2024-03-07 8:17 ` Louis Peens
2024-03-07 8:40 ` Jiri Pirko
2024-03-07 11:06 ` Louis Peens
2024-03-07 11:32 ` Jiri Pirko
2024-03-08 0:59 ` Jakub Kicinski
2024-02-28 7:51 ` [PATCH net-next v2 2/4] nfp: update devlink device info output Louis Peens
2024-02-28 12:16 ` Jiri Pirko
2024-02-29 4:34 ` Jakub Kicinski [this message]
2024-03-07 8:22 ` Louis Peens
2024-02-28 7:51 ` [PATCH net-next v2 3/4] dim: introduce a specific dim profile for better latency Louis Peens
2024-02-28 7:51 ` [PATCH net-next v2 4/4] nfp: use new dim profiles " Louis Peens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240228203458.4a7234f5@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=fei.qin@corigine.com \
--cc=louis.peens@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.