From: Simon Horman <horms@kernel.org>
To: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
Cc: andrew@lunn.ch, jiri@resnulli.us, michal.wilczynski@intel.com,
netdev@vger.kernel.org, lukasz.czapnik@intel.com,
victor.raj@intel.com, kuba@kernel.org,
anthony.l.nguyen@intel.com, Jiri Pirko <jiri@nvidia.com>,
przemyslaw.kitszel@intel.com, intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v7 1/6] devlink: extend devlink_param *set pointer
Date: Mon, 18 Mar 2024 20:02:18 +0000 [thread overview]
Message-ID: <20240318200218.GB185808@kernel.org> (raw)
In-Reply-To: <20240308113919.11787-2-mateusz.polchlopek@intel.com>
On Fri, Mar 08, 2024 at 06:39:14AM -0500, Mateusz Polchlopek wrote:
> Extend devlink_param *set function pointer to take extack as a param.
> Sometimes it is needed to pass information to the end user from set
> function. It is more proper to use for that netlink instead of passing
> message to dmesg.
>
> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
> Signed-off-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
Hi Mateusz,
FWIIW, I think there are several (new?) users of this callback
present in net-next now which will also need to be updated.
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
anthony.l.nguyen@intel.com, kuba@kernel.org, jiri@resnulli.us,
przemyslaw.kitszel@intel.com, andrew@lunn.ch,
victor.raj@intel.com, michal.wilczynski@intel.com,
lukasz.czapnik@intel.com, Jiri Pirko <jiri@nvidia.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v7 1/6] devlink: extend devlink_param *set pointer
Date: Mon, 18 Mar 2024 20:02:18 +0000 [thread overview]
Message-ID: <20240318200218.GB185808@kernel.org> (raw)
In-Reply-To: <20240308113919.11787-2-mateusz.polchlopek@intel.com>
On Fri, Mar 08, 2024 at 06:39:14AM -0500, Mateusz Polchlopek wrote:
> Extend devlink_param *set function pointer to take extack as a param.
> Sometimes it is needed to pass information to the end user from set
> function. It is more proper to use for that netlink instead of passing
> message to dmesg.
>
> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
> Signed-off-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
Hi Mateusz,
FWIIW, I think there are several (new?) users of this callback
present in net-next now which will also need to be updated.
next prev parent reply other threads:[~2024-03-18 20:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 11:39 [Intel-wired-lan] [PATCH iwl-next v7 0/6] ice: Support 5 layer Tx scheduler topology Mateusz Polchlopek
2024-03-08 11:39 ` Mateusz Polchlopek
2024-03-08 11:39 ` [Intel-wired-lan] [PATCH iwl-next v7 1/6] devlink: extend devlink_param *set pointer Mateusz Polchlopek
2024-03-08 11:39 ` Mateusz Polchlopek
2024-03-18 20:02 ` Simon Horman [this message]
2024-03-18 20:02 ` Simon Horman
2024-03-19 11:41 ` Mateusz Polchlopek
2024-03-19 11:41 ` Mateusz Polchlopek
2024-03-08 11:39 ` [Intel-wired-lan] [PATCH iwl-next v7 2/6] ice: Support 5 layer topology Mateusz Polchlopek
2024-03-08 11:39 ` Mateusz Polchlopek
2024-03-08 11:39 ` [Intel-wired-lan] [PATCH iwl-next v7 3/6] ice: Adjust the VSI/Aggregator layers Mateusz Polchlopek
2024-03-08 11:39 ` Mateusz Polchlopek
2024-03-08 11:39 ` [Intel-wired-lan] [PATCH iwl-next v7 4/6] ice: Enable switching default Tx scheduler topology Mateusz Polchlopek
2024-03-08 11:39 ` Mateusz Polchlopek
2024-03-08 11:39 ` [Intel-wired-lan] [PATCH iwl-next v7 5/6] ice: Add tx_scheduling_layers devlink param Mateusz Polchlopek
2024-03-08 11:39 ` Mateusz Polchlopek
2024-03-08 11:39 ` [Intel-wired-lan] [PATCH iwl-next v7 6/6] ice: Document tx_scheduling_layers parameter Mateusz Polchlopek
2024-03-08 11:39 ` Mateusz Polchlopek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240318200218.GB185808@kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=lukasz.czapnik@intel.com \
--cc=mateusz.polchlopek@intel.com \
--cc=michal.wilczynski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=victor.raj@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.