All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v2 2/4] mtd: Replace module_init with subsys_initcall
Date: Tue, 19 Mar 2024 10:53:09 +0100	[thread overview]
Message-ID: <20240319105309.7cdfe106@xps-13> (raw)
In-Reply-To: <4e3fbff7-6edc-4196-bc72-1095f14d0dfa@linaro.org>

Hi,

krzysztof.kozlowski at linaro.org wrote on Tue, 19 Mar 2024 10:51:00 +0100:

> On 19/03/2024 10:34, Manojkiran Eda wrote:
> > While engaged in development on the espi kernel device driver[1],
> > I noticed that the espi flash driver, utilizing the mtd subsystem,
> > appears to initialize before the mtdcore subsystem registers the  
> 
> NAK
> 
> You incorrectly ordered your call, so now to fix this you incorrectly
> re-order rest of kernel. No. Fix your code to handle modules, probe
> deferrals and device links.

Agreed. You shall not need this. Maybe just moving the driver to the
right location (spi) might fix it.

Thanks,
Miqu?l

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Manojkiran Eda <manojkiran.eda@gmail.com>,
	patrick.rudolph@9elements.com, chiawei_wang@aspeedtech.com,
	ryan_chen@aspeedtech.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	joel@jms.id.au, andrew@codeconstruct.com.au, richard@nod.at,
	vigneshr@ti.com, jk@codeconstruct.com.au,
	openbmc@lists.ozlabs.org
Subject: Re: [PATCH v2 2/4] mtd: Replace module_init with subsys_initcall
Date: Tue, 19 Mar 2024 10:53:09 +0100	[thread overview]
Message-ID: <20240319105309.7cdfe106@xps-13> (raw)
In-Reply-To: <4e3fbff7-6edc-4196-bc72-1095f14d0dfa@linaro.org>

Hi,

krzysztof.kozlowski@linaro.org wrote on Tue, 19 Mar 2024 10:51:00 +0100:

> On 19/03/2024 10:34, Manojkiran Eda wrote:
> > While engaged in development on the espi kernel device driver[1],
> > I noticed that the espi flash driver, utilizing the mtd subsystem,
> > appears to initialize before the mtdcore subsystem registers the  
> 
> NAK
> 
> You incorrectly ordered your call, so now to fix this you incorrectly
> re-order rest of kernel. No. Fix your code to handle modules, probe
> deferrals and device links.

Agreed. You shall not need this. Maybe just moving the driver to the
right location (spi) might fix it.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org,
	ryan_chen@aspeedtech.com, vigneshr@ti.com,
	linux-aspeed@lists.ozlabs.org, richard@nod.at,
	chiawei_wang@aspeedtech.com, linux-kernel@vger.kernel.org,
	joel@jms.id.au, robh+dt@kernel.org,
	linux-mtd@lists.infradead.org, patrick.rudolph@9elements.com,
	krzysztof.kozlowski+dt@linaro.org, jk@codeconstruct.com.au,
	openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
	Manojkiran Eda <manojkiran.eda@gmail.com>
Subject: Re: [PATCH v2 2/4] mtd: Replace module_init with subsys_initcall
Date: Tue, 19 Mar 2024 10:53:09 +0100	[thread overview]
Message-ID: <20240319105309.7cdfe106@xps-13> (raw)
In-Reply-To: <4e3fbff7-6edc-4196-bc72-1095f14d0dfa@linaro.org>

Hi,

krzysztof.kozlowski@linaro.org wrote on Tue, 19 Mar 2024 10:51:00 +0100:

> On 19/03/2024 10:34, Manojkiran Eda wrote:
> > While engaged in development on the espi kernel device driver[1],
> > I noticed that the espi flash driver, utilizing the mtd subsystem,
> > appears to initialize before the mtdcore subsystem registers the  
> 
> NAK
> 
> You incorrectly ordered your call, so now to fix this you incorrectly
> re-order rest of kernel. No. Fix your code to handle modules, probe
> deferrals and device links.

Agreed. You shall not need this. Maybe just moving the driver to the
right location (spi) might fix it.

Thanks,
Miquèl

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Manojkiran Eda <manojkiran.eda@gmail.com>,
	patrick.rudolph@9elements.com, chiawei_wang@aspeedtech.com,
	ryan_chen@aspeedtech.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	joel@jms.id.au, andrew@codeconstruct.com.au, richard@nod.at,
	vigneshr@ti.com, jk@codeconstruct.com.au,
	openbmc@lists.ozlabs.org
Subject: Re: [PATCH v2 2/4] mtd: Replace module_init with subsys_initcall
Date: Tue, 19 Mar 2024 10:53:09 +0100	[thread overview]
Message-ID: <20240319105309.7cdfe106@xps-13> (raw)
In-Reply-To: <4e3fbff7-6edc-4196-bc72-1095f14d0dfa@linaro.org>

Hi,

krzysztof.kozlowski@linaro.org wrote on Tue, 19 Mar 2024 10:51:00 +0100:

> On 19/03/2024 10:34, Manojkiran Eda wrote:
> > While engaged in development on the espi kernel device driver[1],
> > I noticed that the espi flash driver, utilizing the mtd subsystem,
> > appears to initialize before the mtdcore subsystem registers the  
> 
> NAK
> 
> You incorrectly ordered your call, so now to fix this you incorrectly
> re-order rest of kernel. No. Fix your code to handle modules, probe
> deferrals and device links.

Agreed. You shall not need this. Maybe just moving the driver to the
right location (spi) might fix it.

Thanks,
Miquèl

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Manojkiran Eda <manojkiran.eda@gmail.com>,
	patrick.rudolph@9elements.com, chiawei_wang@aspeedtech.com,
	ryan_chen@aspeedtech.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	joel@jms.id.au, andrew@codeconstruct.com.au, richard@nod.at,
	vigneshr@ti.com, jk@codeconstruct.com.au,
	openbmc@lists.ozlabs.org
Subject: Re: [PATCH v2 2/4] mtd: Replace module_init with subsys_initcall
Date: Tue, 19 Mar 2024 10:53:09 +0100	[thread overview]
Message-ID: <20240319105309.7cdfe106@xps-13> (raw)
In-Reply-To: <4e3fbff7-6edc-4196-bc72-1095f14d0dfa@linaro.org>

Hi,

krzysztof.kozlowski@linaro.org wrote on Tue, 19 Mar 2024 10:51:00 +0100:

> On 19/03/2024 10:34, Manojkiran Eda wrote:
> > While engaged in development on the espi kernel device driver[1],
> > I noticed that the espi flash driver, utilizing the mtd subsystem,
> > appears to initialize before the mtdcore subsystem registers the  
> 
> NAK
> 
> You incorrectly ordered your call, so now to fix this you incorrectly
> re-order rest of kernel. No. Fix your code to handle modules, probe
> deferrals and device links.

Agreed. You shall not need this. Maybe just moving the driver to the
right location (spi) might fix it.

Thanks,
Miquèl

  reply	other threads:[~2024-03-19  9:53 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-19  9:34 [PATCH v2 0/4] Add eSPI device driver (flash channel) Manojkiran Eda
2024-03-19  9:35 ` Manojkiran Eda
2024-03-19  9:34 ` Manojkiran Eda
2024-03-19  9:34 ` Manojkiran Eda
2024-03-19  9:34 ` Manojkiran Eda
2024-03-19  9:34 ` [PATCH v2 1/4] " Manojkiran Eda
2024-03-19  9:35   ` Manojkiran Eda
2024-03-19  9:34   ` Manojkiran Eda
2024-03-19  9:34   ` Manojkiran Eda
2024-03-19  9:34   ` Manojkiran Eda
2024-03-19  9:49   ` Krzysztof Kozlowski
2024-03-19  9:49     ` Krzysztof Kozlowski
2024-03-19  9:49     ` Krzysztof Kozlowski
2024-03-19  9:49     ` Krzysztof Kozlowski
2024-03-19  9:34 ` [PATCH v2 2/4] mtd: Replace module_init with subsys_initcall Manojkiran Eda
2024-03-19  9:35   ` Manojkiran Eda
2024-03-19  9:34   ` Manojkiran Eda
2024-03-19  9:34   ` Manojkiran Eda
2024-03-19  9:34   ` Manojkiran Eda
2024-03-19  9:51   ` Krzysztof Kozlowski
2024-03-19  9:51     ` Krzysztof Kozlowski
2024-03-19  9:51     ` Krzysztof Kozlowski
2024-03-19  9:51     ` Krzysztof Kozlowski
2024-03-19  9:53     ` Miquel Raynal [this message]
2024-03-19  9:53       ` Miquel Raynal
2024-03-19  9:53       ` Miquel Raynal
2024-03-19  9:53       ` Miquel Raynal
2024-03-19  9:53       ` Miquel Raynal
2024-03-19  9:34 ` [PATCH v2 3/4] ARM: dts: aspeed: Add eSPI node Manojkiran Eda
2024-03-19  9:35   ` Manojkiran Eda
2024-03-19  9:34   ` Manojkiran Eda
2024-03-19  9:34   ` Manojkiran Eda
2024-03-19  9:34   ` Manojkiran Eda
2024-03-19  9:50   ` Krzysztof Kozlowski
2024-03-19  9:50     ` Krzysztof Kozlowski
2024-03-19  9:50     ` Krzysztof Kozlowski
2024-03-19  9:50     ` Krzysztof Kozlowski
2024-03-19  9:34 ` [PATCH v2 4/4] dt-bindings: aspeed: Add eSPI controller Manojkiran Eda
2024-03-19  9:35   ` Manojkiran Eda
2024-03-19  9:34   ` Manojkiran Eda
2024-03-19  9:34   ` Manojkiran Eda
2024-03-19  9:34   ` Manojkiran Eda
2024-03-19  9:56   ` Krzysztof Kozlowski
2024-03-19  9:56     ` Krzysztof Kozlowski
2024-03-19  9:56     ` Krzysztof Kozlowski
2024-03-19  9:56     ` Krzysztof Kozlowski
2024-03-20  9:59     ` Manojkiran Eda
2024-03-20  9:59       ` Manojkiran Eda
2024-03-20 14:44       ` Krzysztof Kozlowski
2024-03-20 14:44         ` Krzysztof Kozlowski
2024-03-20 14:44         ` Krzysztof Kozlowski
2024-03-20 14:44         ` Krzysztof Kozlowski
2024-03-28 11:33         ` Manojkiran Eda
2024-03-28 11:33           ` Manojkiran Eda
2024-03-28 11:33           ` Manojkiran Eda
2024-03-28 11:33           ` Manojkiran Eda
2024-03-28 11:33           ` Manojkiran Eda
2024-03-30 18:36           ` Krzysztof Kozlowski
2024-03-30 18:36             ` Krzysztof Kozlowski
2024-03-30 18:36             ` Krzysztof Kozlowski
2024-03-30 18:36             ` Krzysztof Kozlowski
2024-03-20 15:40       ` Rob Herring
2024-03-20 15:40         ` Rob Herring
2024-03-20 15:40         ` Rob Herring
2024-03-20 15:40         ` Rob Herring
2024-03-20 15:40         ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240319105309.7cdfe106@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.