* [PATCH] phycore_pcl063: Drop leading zero from USB vendor number
@ 2024-03-25 13:52 Fabio Estevam
2024-03-25 14:01 ` Marek Vasut
2024-03-30 19:44 ` Fabio Estevam
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2024-03-25 13:52 UTC (permalink / raw)
To: martyn.welch; +Cc: parthitce, marex, u-boot, y.moog, w.egorov, Fabio Estevam
CONFIG_USB_GADGET_VENDOR_NUM is a 16-bit number, so remove
the leading zero.
Reported-by: Marek Vasut <marex@denx.de>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
configs/phycore_pcl063_defconfig | 2 +-
configs/phycore_pcl063_ull_defconfig | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/configs/phycore_pcl063_defconfig b/configs/phycore_pcl063_defconfig
index 6b00df1cffb3..017054a8e12b 100644
--- a/configs/phycore_pcl063_defconfig
+++ b/configs/phycore_pcl063_defconfig
@@ -63,7 +63,7 @@ CONFIG_USB=y
CONFIG_SPL_USB_HOST=y
CONFIG_USB_GADGET=y
CONFIG_USB_GADGET_MANUFACTURER="Phytec"
-CONFIG_USB_GADGET_VENDOR_NUM=0x01b67
+CONFIG_USB_GADGET_VENDOR_NUM=0x1b67
CONFIG_USB_GADGET_PRODUCT_NUM=0x4fff
CONFIG_CI_UDC=y
CONFIG_USB_GADGET_DOWNLOAD=y
diff --git a/configs/phycore_pcl063_ull_defconfig b/configs/phycore_pcl063_ull_defconfig
index 6195fcfb73df..b3da43a5bf1e 100644
--- a/configs/phycore_pcl063_ull_defconfig
+++ b/configs/phycore_pcl063_ull_defconfig
@@ -54,7 +54,7 @@ CONFIG_USB=y
CONFIG_SPL_USB_HOST=y
CONFIG_USB_GADGET=y
CONFIG_USB_GADGET_MANUFACTURER="Phytec"
-CONFIG_USB_GADGET_VENDOR_NUM=0x01b67
+CONFIG_USB_GADGET_VENDOR_NUM=0x1b67
CONFIG_USB_GADGET_PRODUCT_NUM=0x4fff
CONFIG_CI_UDC=y
CONFIG_USB_GADGET_DOWNLOAD=y
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] phycore_pcl063: Drop leading zero from USB vendor number
2024-03-25 13:52 [PATCH] phycore_pcl063: Drop leading zero from USB vendor number Fabio Estevam
@ 2024-03-25 14:01 ` Marek Vasut
2024-03-30 19:44 ` Fabio Estevam
1 sibling, 0 replies; 3+ messages in thread
From: Marek Vasut @ 2024-03-25 14:01 UTC (permalink / raw)
To: Fabio Estevam, martyn.welch
Cc: parthitce, u-boot, y.moog, w.egorov, Masahiro Yamada
On 3/25/24 2:52 PM, Fabio Estevam wrote:
> CONFIG_USB_GADGET_VENDOR_NUM is a 16-bit number, so remove
> the leading zero.
>
> Reported-by: Marek Vasut <marex@denx.de>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> configs/phycore_pcl063_defconfig | 2 +-
> configs/phycore_pcl063_ull_defconfig | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configs/phycore_pcl063_defconfig b/configs/phycore_pcl063_defconfig
> index 6b00df1cffb3..017054a8e12b 100644
> --- a/configs/phycore_pcl063_defconfig
> +++ b/configs/phycore_pcl063_defconfig
> @@ -63,7 +63,7 @@ CONFIG_USB=y
> CONFIG_SPL_USB_HOST=y
> CONFIG_USB_GADGET=y
> CONFIG_USB_GADGET_MANUFACTURER="Phytec"
> -CONFIG_USB_GADGET_VENDOR_NUM=0x01b67
> +CONFIG_USB_GADGET_VENDOR_NUM=0x1b67
> CONFIG_USB_GADGET_PRODUCT_NUM=0x4fff
> CONFIG_CI_UDC=y
> CONFIG_USB_GADGET_DOWNLOAD=y
> diff --git a/configs/phycore_pcl063_ull_defconfig b/configs/phycore_pcl063_ull_defconfig
> index 6195fcfb73df..b3da43a5bf1e 100644
> --- a/configs/phycore_pcl063_ull_defconfig
> +++ b/configs/phycore_pcl063_ull_defconfig
> @@ -54,7 +54,7 @@ CONFIG_USB=y
> CONFIG_SPL_USB_HOST=y
> CONFIG_USB_GADGET=y
> CONFIG_USB_GADGET_MANUFACTURER="Phytec"
> -CONFIG_USB_GADGET_VENDOR_NUM=0x01b67
> +CONFIG_USB_GADGET_VENDOR_NUM=0x1b67
Reviewed-by: Marek Vasut <marex@denx.de>
+CC Yamada-san , can Kconfig somehow sanitize 16bit numbers like this ?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] phycore_pcl063: Drop leading zero from USB vendor number
2024-03-25 13:52 [PATCH] phycore_pcl063: Drop leading zero from USB vendor number Fabio Estevam
2024-03-25 14:01 ` Marek Vasut
@ 2024-03-30 19:44 ` Fabio Estevam
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2024-03-30 19:44 UTC (permalink / raw)
To: martyn.welch; +Cc: parthitce, marex, u-boot, y.moog, w.egorov
On Mon, Mar 25, 2024 at 10:52 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> CONFIG_USB_GADGET_VENDOR_NUM is a 16-bit number, so remove
> the leading zero.
>
> Reported-by: Marek Vasut <marex@denx.de>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx/next, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-30 19:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-25 13:52 [PATCH] phycore_pcl063: Drop leading zero from USB vendor number Fabio Estevam
2024-03-25 14:01 ` Marek Vasut
2024-03-30 19:44 ` Fabio Estevam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.