From: Simon Horman <horms@kernel.org>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: Jiri Pirko <jiri@resnulli.us>,
netdev@vger.kernel.org,
Wojciech Drewek <wojciech.drewek@intel.com>,
intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [iwl-next v1 3/3] ice: hold devlink lock for whole init/cleanup
Date: Tue, 26 Mar 2024 11:20:23 +0000 [thread overview]
Message-ID: <20240326112023.GL403975@kernel.org> (raw)
In-Reply-To: <20240325213433.829161-4-michal.swiatkowski@linux.intel.com>
On Mon, Mar 25, 2024 at 10:34:33PM +0100, Michal Swiatkowski wrote:
> Simplify devlink lock code in driver by taking it for whole init/cleanup
> path. Instead of calling devlink functions that taking lock call the
> lockless versions.
>
> Suggested-by: Jiri Pirko <jiri@resnulli.us>
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Jiri Pirko <jiri@resnulli.us>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Wojciech Drewek <wojciech.drewek@intel.com>
Subject: Re: [iwl-next v1 3/3] ice: hold devlink lock for whole init/cleanup
Date: Tue, 26 Mar 2024 11:20:23 +0000 [thread overview]
Message-ID: <20240326112023.GL403975@kernel.org> (raw)
In-Reply-To: <20240325213433.829161-4-michal.swiatkowski@linux.intel.com>
On Mon, Mar 25, 2024 at 10:34:33PM +0100, Michal Swiatkowski wrote:
> Simplify devlink lock code in driver by taking it for whole init/cleanup
> path. Instead of calling devlink functions that taking lock call the
> lockless versions.
>
> Suggested-by: Jiri Pirko <jiri@resnulli.us>
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-03-26 11:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 21:34 [Intel-wired-lan] [iwl-next v1 0/3] ice: devlink cleanup Michal Swiatkowski
2024-03-25 21:34 ` Michal Swiatkowski
2024-03-25 21:34 ` [Intel-wired-lan] [iwl-next v1 1/3] ice: move ice_devlink.[ch] to devlink folder Michal Swiatkowski
2024-03-25 21:34 ` Michal Swiatkowski
2024-03-26 11:19 ` [Intel-wired-lan] " Simon Horman
2024-03-26 11:19 ` Simon Horman
2024-03-28 10:48 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-03-28 10:48 ` Pucha, HimasekharX Reddy
2024-03-25 21:34 ` [Intel-wired-lan] [iwl-next v1 2/3] ice: move devlink port code to a separate file Michal Swiatkowski
2024-03-25 21:34 ` Michal Swiatkowski
2024-03-26 11:20 ` [Intel-wired-lan] " Simon Horman
2024-03-26 11:20 ` Simon Horman
2024-03-28 10:50 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-03-28 10:50 ` Pucha, HimasekharX Reddy
2024-03-25 21:34 ` [Intel-wired-lan] [iwl-next v1 3/3] ice: hold devlink lock for whole init/cleanup Michal Swiatkowski
2024-03-25 21:34 ` Michal Swiatkowski
2024-03-26 11:20 ` Simon Horman [this message]
2024-03-26 11:20 ` Simon Horman
2024-03-28 10:51 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-03-28 10:51 ` Pucha, HimasekharX Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240326112023.GL403975@kernel.org \
--to=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jiri@resnulli.us \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.