From: Oleg Nesterov <oleg@redhat.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Jiri Olsa <olsajiri@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
bpf@vger.kernel.org, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Borislav Petkov (AMD)" <bp@alien8.de>,
x86@kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCHv2 1/3] uprobe: Add uretprobe syscall to speed up return probe
Date: Thu, 4 Apr 2024 18:11:09 +0200 [thread overview]
Message-ID: <20240404161108.GG7153@redhat.com> (raw)
In-Reply-To: <20240405005405.9bcbe5072d2f32967501edb3@kernel.org>
On 04/05, Masami Hiramatsu wrote:
>
> Can we make this syscall and uprobe behavior clearer? As you said, if
> the application use sigreturn or longjump, it may skip returns and
> shadow stack entries are left in the kernel. In such cases, can uretprobe
> detect it properly, or just crash the process (or process runs wrongly)?
Please see the comment in handle_trampoline(), it tries to detect this case.
This patch should not make any difference.
Oleg.
next prev parent reply other threads:[~2024-04-04 16:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 9:32 [PATCHv2 0/3] uprobe: uretprobe speed up Jiri Olsa
2024-04-02 9:33 ` [PATCHv2 1/3] uprobe: Add uretprobe syscall to speed up return probe Jiri Olsa
2024-04-03 1:07 ` Masami Hiramatsu
2024-04-03 9:47 ` Jiri Olsa
2024-04-03 13:56 ` Oleg Nesterov
2024-04-03 14:09 ` Masami Hiramatsu
2024-04-03 14:49 ` Oleg Nesterov
2024-04-03 16:58 ` Andrii Nakryiko
2024-04-04 0:58 ` Masami Hiramatsu
2024-04-04 2:00 ` Andrii Nakryiko
2024-04-04 11:58 ` Jiri Olsa
2024-04-04 16:06 ` Masami Hiramatsu
2024-04-04 15:54 ` Masami Hiramatsu
2024-04-04 16:11 ` Oleg Nesterov [this message]
2024-04-05 1:22 ` Masami Hiramatsu
2024-04-05 8:56 ` Jiri Olsa
2024-04-05 11:02 ` Oleg Nesterov
2024-04-06 3:05 ` Masami Hiramatsu
2024-04-06 17:55 ` Oleg Nesterov
2024-04-08 3:54 ` Masami Hiramatsu
2024-04-08 16:02 ` Jiri Olsa
2024-04-08 16:22 ` Oleg Nesterov
2024-04-09 12:06 ` Jiri Olsa
2024-04-09 0:34 ` Masami Hiramatsu
2024-04-09 7:57 ` Jiri Olsa
2024-04-08 3:16 ` Masami Hiramatsu
2024-04-15 8:25 ` Jiri Olsa
2024-04-18 18:34 ` Andrii Nakryiko
2024-04-02 9:33 ` [PATCHv2 bpf-next 2/3] selftests/bpf: Add uretprobe test for regs integrity Jiri Olsa
2024-04-02 9:33 ` [PATCHv2 bpf-next 3/3] selftests/bpf: Add uretprobe test for regs changes Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240404161108.GG7153@redhat.com \
--to=oleg@redhat.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=olsajiri@gmail.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=songliubraving@fb.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.