From: Heiko Carstens <hca@linux.ibm.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: akpm@linux-foundation.org, Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
x86@kernel.org, linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, surenb@google.com,
linux-mm@kvack.org
Subject: Re: [PATCH v2 6/7] s390: mm: accelerate pagefault when badaccess
Date: Sun, 7 Apr 2024 19:19:52 +0200 [thread overview]
Message-ID: <20240407171952.5958-B-hca@linux.ibm.com> (raw)
In-Reply-To: <20240403083805.1818160-7-wangkefeng.wang@huawei.com>
On Wed, Apr 03, 2024 at 04:38:04PM +0800, Kefeng Wang wrote:
> The vm_flags of vma already checked under per-VMA lock, if it is a
> bad access, directly handle error, no need to retry with mmap_lock
> again. Since the page faut is handled under per-VMA lock, count it
> as a vma lock event with VMA_LOCK_SUCCESS.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> arch/s390/mm/fault.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/s390/mm/fault.c b/arch/s390/mm/fault.c
> index c421dd44ffbe..162ca2576fd4 100644
> --- a/arch/s390/mm/fault.c
> +++ b/arch/s390/mm/fault.c
> @@ -325,7 +325,8 @@ static void do_exception(struct pt_regs *regs, int access)
> goto lock_mmap;
> if (!(vma->vm_flags & access)) {
> vma_end_read(vma);
> - goto lock_mmap;
> + count_vm_vma_lock_event(VMA_LOCK_SUCCESS);
> + return handle_fault_error_nolock(regs, SEGV_ACCERR);
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Carstens <hca@linux.ibm.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: akpm@linux-foundation.org, Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
x86@kernel.org, linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, surenb@google.com,
linux-mm@kvack.org
Subject: Re: [PATCH v2 6/7] s390: mm: accelerate pagefault when badaccess
Date: Sun, 7 Apr 2024 19:19:52 +0200 [thread overview]
Message-ID: <20240407171952.5958-B-hca@linux.ibm.com> (raw)
In-Reply-To: <20240403083805.1818160-7-wangkefeng.wang@huawei.com>
On Wed, Apr 03, 2024 at 04:38:04PM +0800, Kefeng Wang wrote:
> The vm_flags of vma already checked under per-VMA lock, if it is a
> bad access, directly handle error, no need to retry with mmap_lock
> again. Since the page faut is handled under per-VMA lock, count it
> as a vma lock event with VMA_LOCK_SUCCESS.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> arch/s390/mm/fault.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/s390/mm/fault.c b/arch/s390/mm/fault.c
> index c421dd44ffbe..162ca2576fd4 100644
> --- a/arch/s390/mm/fault.c
> +++ b/arch/s390/mm/fault.c
> @@ -325,7 +325,8 @@ static void do_exception(struct pt_regs *regs, int access)
> goto lock_mmap;
> if (!(vma->vm_flags & access)) {
> vma_end_read(vma);
> - goto lock_mmap;
> + count_vm_vma_lock_event(VMA_LOCK_SUCCESS);
> + return handle_fault_error_nolock(regs, SEGV_ACCERR);
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Carstens <hca@linux.ibm.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-mm@kvack.org, linux-riscv@lists.infradead.org,
Will Deacon <will@kernel.org>,
Alexander Gordeev <agordeev@linux.ibm.com>,
linux-s390@vger.kernel.org, x86@kernel.org,
Russell King <linux@armlinux.org.uk>,
Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Nicholas Piggin <npiggin@gmail.com>,
Andy Lutomirski <luto@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
surenb@google.com, linux-arm-kernel@lists.infradead.org,
Palmer Dabbelt <palmer@dabbelt.com>,
akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 6/7] s390: mm: accelerate pagefault when badaccess
Date: Sun, 7 Apr 2024 19:19:52 +0200 [thread overview]
Message-ID: <20240407171952.5958-B-hca@linux.ibm.com> (raw)
In-Reply-To: <20240403083805.1818160-7-wangkefeng.wang@huawei.com>
On Wed, Apr 03, 2024 at 04:38:04PM +0800, Kefeng Wang wrote:
> The vm_flags of vma already checked under per-VMA lock, if it is a
> bad access, directly handle error, no need to retry with mmap_lock
> again. Since the page faut is handled under per-VMA lock, count it
> as a vma lock event with VMA_LOCK_SUCCESS.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> arch/s390/mm/fault.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/s390/mm/fault.c b/arch/s390/mm/fault.c
> index c421dd44ffbe..162ca2576fd4 100644
> --- a/arch/s390/mm/fault.c
> +++ b/arch/s390/mm/fault.c
> @@ -325,7 +325,8 @@ static void do_exception(struct pt_regs *regs, int access)
> goto lock_mmap;
> if (!(vma->vm_flags & access)) {
> vma_end_read(vma);
> - goto lock_mmap;
> + count_vm_vma_lock_event(VMA_LOCK_SUCCESS);
> + return handle_fault_error_nolock(regs, SEGV_ACCERR);
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Carstens <hca@linux.ibm.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: akpm@linux-foundation.org, Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
x86@kernel.org, linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, surenb@google.com,
linux-mm@kvack.org
Subject: Re: [PATCH v2 6/7] s390: mm: accelerate pagefault when badaccess
Date: Sun, 7 Apr 2024 19:19:52 +0200 [thread overview]
Message-ID: <20240407171952.5958-B-hca@linux.ibm.com> (raw)
In-Reply-To: <20240403083805.1818160-7-wangkefeng.wang@huawei.com>
On Wed, Apr 03, 2024 at 04:38:04PM +0800, Kefeng Wang wrote:
> The vm_flags of vma already checked under per-VMA lock, if it is a
> bad access, directly handle error, no need to retry with mmap_lock
> again. Since the page faut is handled under per-VMA lock, count it
> as a vma lock event with VMA_LOCK_SUCCESS.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> arch/s390/mm/fault.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/s390/mm/fault.c b/arch/s390/mm/fault.c
> index c421dd44ffbe..162ca2576fd4 100644
> --- a/arch/s390/mm/fault.c
> +++ b/arch/s390/mm/fault.c
> @@ -325,7 +325,8 @@ static void do_exception(struct pt_regs *regs, int access)
> goto lock_mmap;
> if (!(vma->vm_flags & access)) {
> vma_end_read(vma);
> - goto lock_mmap;
> + count_vm_vma_lock_event(VMA_LOCK_SUCCESS);
> + return handle_fault_error_nolock(regs, SEGV_ACCERR);
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-07 17:20 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 8:37 [PATCH v2 0/7] arch/mm/fault: accelerate pagefault when badaccess Kefeng Wang
2024-04-03 8:37 ` Kefeng Wang
2024-04-03 8:37 ` Kefeng Wang
2024-04-03 8:37 ` Kefeng Wang
2024-04-03 8:37 ` [PATCH v2 1/7] arm64: mm: cleanup __do_page_fault() Kefeng Wang
2024-04-03 8:37 ` Kefeng Wang
2024-04-03 8:37 ` Kefeng Wang
2024-04-03 8:37 ` Kefeng Wang
2024-04-09 11:14 ` Catalin Marinas
2024-04-09 11:14 ` Catalin Marinas
2024-04-09 11:14 ` Catalin Marinas
2024-04-09 11:14 ` Catalin Marinas
2024-04-03 8:38 ` [PATCH v2 2/7] arm64: mm: accelerate pagefault when VM_FAULT_BADACCESS Kefeng Wang
2024-04-03 8:38 ` Kefeng Wang
2024-04-03 8:38 ` Kefeng Wang
2024-04-03 8:38 ` Kefeng Wang
2024-04-09 11:15 ` Catalin Marinas
2024-04-09 11:15 ` Catalin Marinas
2024-04-09 11:15 ` Catalin Marinas
2024-04-09 11:15 ` Catalin Marinas
2024-04-03 8:38 ` [PATCH v2 3/7] arm: " Kefeng Wang
2024-04-03 8:38 ` Kefeng Wang
2024-04-03 8:38 ` Kefeng Wang
2024-04-03 8:38 ` Kefeng Wang
2024-04-03 8:38 ` [PATCH v2 4/7] powerpc: mm: accelerate pagefault when badaccess Kefeng Wang
2024-04-03 8:38 ` Kefeng Wang
2024-04-03 8:38 ` Kefeng Wang
2024-04-03 8:38 ` Kefeng Wang
2024-04-09 8:56 ` Michael Ellerman
2024-04-09 8:56 ` Michael Ellerman
2024-04-09 8:56 ` Michael Ellerman
2024-04-09 8:56 ` Michael Ellerman
2024-04-03 8:38 ` [PATCH v2 5/7] riscv: " Kefeng Wang
2024-04-03 8:38 ` Kefeng Wang
2024-04-03 8:38 ` Kefeng Wang
2024-04-03 8:38 ` Kefeng Wang
2024-04-10 7:32 ` Alexandre Ghiti
2024-04-10 7:32 ` Alexandre Ghiti
2024-04-10 7:32 ` Alexandre Ghiti
2024-04-10 7:32 ` Alexandre Ghiti
2024-04-10 8:07 ` Kefeng Wang
2024-04-10 8:07 ` Kefeng Wang
2024-04-10 8:07 ` Kefeng Wang
2024-04-10 8:07 ` Kefeng Wang
2024-04-10 17:28 ` Alexandre Ghiti
2024-04-10 17:28 ` Alexandre Ghiti
2024-04-10 17:28 ` Alexandre Ghiti
2024-04-10 17:28 ` Alexandre Ghiti
2024-04-11 1:17 ` Kefeng Wang
2024-04-11 1:17 ` Kefeng Wang
2024-04-11 1:17 ` Kefeng Wang
2024-04-11 1:17 ` Kefeng Wang
2024-04-03 8:38 ` [PATCH v2 6/7] s390: " Kefeng Wang
2024-04-03 8:38 ` Kefeng Wang
2024-04-03 8:38 ` Kefeng Wang
2024-04-03 8:38 ` Kefeng Wang
2024-04-07 17:19 ` Heiko Carstens [this message]
2024-04-07 17:19 ` Heiko Carstens
2024-04-07 17:19 ` Heiko Carstens
2024-04-07 17:19 ` Heiko Carstens
2024-04-03 8:38 ` [PATCH v2 7/7] x86: " Kefeng Wang
2024-04-03 8:38 ` Kefeng Wang
2024-04-03 8:38 ` Kefeng Wang
2024-04-03 8:38 ` Kefeng Wang
2024-04-03 20:45 ` [PATCH v2 0/7] arch/mm/fault: " Andrew Morton
2024-04-03 20:45 ` Andrew Morton
2024-04-03 20:45 ` Andrew Morton
2024-04-03 20:45 ` Andrew Morton
2024-04-07 7:49 ` Kefeng Wang
2024-04-07 7:49 ` Kefeng Wang
2024-04-07 7:49 ` Kefeng Wang
2024-04-07 7:49 ` Kefeng Wang
2024-04-07 17:19 ` Heiko Carstens
2024-04-07 17:19 ` Heiko Carstens
2024-04-07 17:19 ` Heiko Carstens
2024-04-07 17:19 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240407171952.5958-B-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=aou@eecs.berkeley.edu \
--cc=catalin.marinas@arm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=dave.hansen@linux.intel.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=surenb@google.com \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.