Re: [LTP] [PATCH 1/1] libswap: Change TWARN message to TINFO

[Petr Vorel <pvorel@suse.cz>]

Hi,

> This is hit on systems with 64kb page size (e.g. on aarch64 with
> CONFIG_ARM64_64K_PAGES=y or on ppc64le with CONFIG_PAGE_SIZE_64KB=y).
> Using TINFO causes test not "failing" with non-zero exit code.

Also, sometimes we use:
tst_res(TINFO, "WARNING: ...",
e.g. TWARN which would still keep the test exiting 0 (I know, i bit strange).

Maybe we would need some specific TWARN_NOFAIL, which would print as TWARN
(=> more visible) but test exit code would be 0.

Kind regards,
Petr

> Fixes: f987ffff5 ("libswap: add two methods to create swapfile")
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  libs/libltpswap/libswap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/libs/libltpswap/libswap.c b/libs/libltpswap/libswap.c
> index 313a15f24..6d4184ef9 100644
> --- a/libs/libltpswap/libswap.c
> +++ b/libs/libltpswap/libswap.c
> @@ -160,7 +160,7 @@ int make_swapfile_(const char *file, const int lineno,

>  	/* To guarantee at least one page can be swapped out */
>  	if (blk_size * blocks < pg_size) {
> -		tst_res(TWARN, "Swapfile size is less than the system page size. "
> +		tst_res(TINFO, "Swapfile size is less than the system page size. "
>  			"Using page size (%lu bytes) instead of block size (%lu bytes).",
>  			(unsigned long)pg_size, blk_size);
>  		blk_size = pg_size;

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp