From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] libswap: Change TWARN message to TINFO
Date: Wed, 17 Apr 2024 20:38:32 +0200 [thread overview]
Message-ID: <20240417183832.GD35911@pevik> (raw)
In-Reply-To: <Zh_R31-342b-1Alm@yuki>
> Hi!
> > Changing it to {SAFE_,}MAKE_SWAPFILE_SIZE() on all places would mean we don't need
> > {SAFE_,}MAKE_SWAPFILE_BLKS() at all. Therefore I think this check should be
> > suppressed to TINFO. Other option is to use high enough value (more blocks)
> > (not sure if using really small swap file makes sense anyway).
> I do not think that we should use too small swap file even for the case
> where we try to detect if swapfiles are supported. Currently it seems
> that kernel accepts swapfiles smaller than page size, but it may also
> start rejecting them with EINVAL in the future.
> So I would keep the warning and rather tried to fix all the parts where
> we attempt to create a swapfile smaller than page size.
+1, setting "changes requested", I'll send v2 with higher number of blocks to
fix this.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-04-17 18:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 9:02 [LTP] [PATCH 1/1] libswap: Change TWARN message to TINFO Petr Vorel
2024-04-17 9:03 ` Andrea Cervesato via ltp
2024-04-17 9:10 ` Petr Vorel
2024-04-17 10:02 ` Cyril Hrubis
2024-04-17 10:06 ` Petr Vorel
2024-04-17 10:31 ` Cyril Hrubis
2024-04-17 12:24 ` Petr Vorel
2024-04-17 13:37 ` Petr Vorel
2024-04-17 13:42 ` Cyril Hrubis
2024-04-17 18:38 ` Petr Vorel [this message]
2024-04-18 5:30 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240417183832.GD35911@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.