All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] libswap: Change TWARN message to TINFO
Date: Wed, 17 Apr 2024 12:06:11 +0200	[thread overview]
Message-ID: <20240417100611.GA713385@pevik> (raw)
In-Reply-To: <Zh-eIg51K9UtdQuj@yuki>

> Hi!
> > This is hit on systems with 64kb page size (e.g. on aarch64 with
> > CONFIG_ARM64_64K_PAGES=y or on ppc64le with CONFIG_PAGE_SIZE_64KB=y).
> > Using TINFO causes test not "failing" with non-zero exit code.

> > Fixes: f987ffff5 ("libswap: add two methods to create swapfile")
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> >  libs/libltpswap/libswap.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)

> > diff --git a/libs/libltpswap/libswap.c b/libs/libltpswap/libswap.c
> > index 313a15f24..6d4184ef9 100644
> > --- a/libs/libltpswap/libswap.c
> > +++ b/libs/libltpswap/libswap.c
> > @@ -160,7 +160,7 @@ int make_swapfile_(const char *file, const int lineno,

> >  	/* To guarantee at least one page can be swapped out */
> >  	if (blk_size * blocks < pg_size) {
> > -		tst_res(TWARN, "Swapfile size is less than the system page size. "
> > +		tst_res(TINFO, "Swapfile size is less than the system page size. "
> >  			"Using page size (%lu bytes) instead of block size (%lu bytes).",
> >  			(unsigned long)pg_size, blk_size);

> This looks like we are working around a test bug, which test is
> triggering this condition?

All swap tests: swapoff0[12], swapon0[1-3]

https://lore.kernel.org/ltp/CAEemH2ev62JxH7-DA5Sc2LjMKrquYqt927ATHZefNPAOiXb5qA@mail.gmail.com/

Kind regards,
Petr

> >  		blk_size = pg_size;
> > -- 
> > 2.43.0

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-04-17 10:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-17  9:02 [LTP] [PATCH 1/1] libswap: Change TWARN message to TINFO Petr Vorel
2024-04-17  9:03 ` Andrea Cervesato via ltp
2024-04-17  9:10 ` Petr Vorel
2024-04-17 10:02 ` Cyril Hrubis
2024-04-17 10:06   ` Petr Vorel [this message]
2024-04-17 10:31     ` Cyril Hrubis
2024-04-17 12:24       ` Petr Vorel
2024-04-17 13:37         ` Petr Vorel
2024-04-17 13:42           ` Cyril Hrubis
2024-04-17 18:38             ` Petr Vorel
2024-04-18  5:30               ` Li Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240417100611.GA713385@pevik \
    --to=pvorel@suse.cz \
    --cc=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.