From: Sean Anderson <sean.anderson@linux.dev>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-phy@lists.infradead.org
Cc: Vinod Koul <vkoul@kernel.org>,
linux-kernel@vger.kernel.org, Michal Simek <michal.simek@amd.com>,
linux-arm-kernel@lists.infradead.org,
Kishon Vijay Abraham I <kishon@kernel.org>,
Sean Anderson <sean.anderson@linux.dev>
Subject: [PATCH 2/3] phy: zynqmp: Don't wait for PLL lock on nonzero PCIe lanes
Date: Mon, 22 Apr 2024 14:58:02 -0400 [thread overview]
Message-ID: <20240422185803.3575319-3-sean.anderson@linux.dev> (raw)
In-Reply-To: <20240422185803.3575319-1-sean.anderson@linux.dev>
Similarly to DisplayPort, nonzero PCIe lanes never achieve PLL lock [1].
Don't wait for them.
Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
---
Maybe it's actually that only the final lane configured locks? I haven't
tested this out.
drivers/phy/xilinx/phy-zynqmp.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/phy/xilinx/phy-zynqmp.c b/drivers/phy/xilinx/phy-zynqmp.c
index b507ed4c3053..08c88dcd7799 100644
--- a/drivers/phy/xilinx/phy-zynqmp.c
+++ b/drivers/phy/xilinx/phy-zynqmp.c
@@ -624,11 +624,13 @@ static int xpsgtr_phy_power_on(struct phy *phy)
if (!xpsgtr_phy_init_required(gtr_phy))
return ret;
/*
- * Wait for the PLL to lock. For DP, only wait on DP0 to avoid
- * cumulating waits for both lanes. The user is expected to initialize
- * lane 0 last.
+ * Wait for the PLL to lock. For DP and PCIe, only wait on instance 0
+ * to avoid cumulative waits for both lanes. The user is expected to
+ * initialize lane 0 last.
*/
- if (gtr_phy->protocol != ICM_PROTOCOL_DP || !gtr_phy->instance)
+ if ((gtr_phy->protocol != ICM_PROTOCOL_DP &&
+ gtr_phy->protocol != ICM_PROTOCOL_PCIE) ||
+ !gtr_phy->instance)
ret = xpsgtr_wait_pll_lock(phy);
return ret;
--
2.35.1.1320.gc452695387.dirty
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Sean Anderson <sean.anderson@linux.dev>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-phy@lists.infradead.org
Cc: Vinod Koul <vkoul@kernel.org>,
linux-kernel@vger.kernel.org, Michal Simek <michal.simek@amd.com>,
linux-arm-kernel@lists.infradead.org,
Kishon Vijay Abraham I <kishon@kernel.org>,
Sean Anderson <sean.anderson@linux.dev>
Subject: [PATCH 2/3] phy: zynqmp: Don't wait for PLL lock on nonzero PCIe lanes
Date: Mon, 22 Apr 2024 14:58:02 -0400 [thread overview]
Message-ID: <20240422185803.3575319-3-sean.anderson@linux.dev> (raw)
In-Reply-To: <20240422185803.3575319-1-sean.anderson@linux.dev>
Similarly to DisplayPort, nonzero PCIe lanes never achieve PLL lock [1].
Don't wait for them.
Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
---
Maybe it's actually that only the final lane configured locks? I haven't
tested this out.
drivers/phy/xilinx/phy-zynqmp.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/phy/xilinx/phy-zynqmp.c b/drivers/phy/xilinx/phy-zynqmp.c
index b507ed4c3053..08c88dcd7799 100644
--- a/drivers/phy/xilinx/phy-zynqmp.c
+++ b/drivers/phy/xilinx/phy-zynqmp.c
@@ -624,11 +624,13 @@ static int xpsgtr_phy_power_on(struct phy *phy)
if (!xpsgtr_phy_init_required(gtr_phy))
return ret;
/*
- * Wait for the PLL to lock. For DP, only wait on DP0 to avoid
- * cumulating waits for both lanes. The user is expected to initialize
- * lane 0 last.
+ * Wait for the PLL to lock. For DP and PCIe, only wait on instance 0
+ * to avoid cumulative waits for both lanes. The user is expected to
+ * initialize lane 0 last.
*/
- if (gtr_phy->protocol != ICM_PROTOCOL_DP || !gtr_phy->instance)
+ if ((gtr_phy->protocol != ICM_PROTOCOL_DP &&
+ gtr_phy->protocol != ICM_PROTOCOL_PCIE) ||
+ !gtr_phy->instance)
ret = xpsgtr_wait_pll_lock(phy);
return ret;
--
2.35.1.1320.gc452695387.dirty
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Sean Anderson <sean.anderson@linux.dev>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-phy@lists.infradead.org
Cc: Vinod Koul <vkoul@kernel.org>,
linux-kernel@vger.kernel.org, Michal Simek <michal.simek@amd.com>,
linux-arm-kernel@lists.infradead.org,
Kishon Vijay Abraham I <kishon@kernel.org>,
Sean Anderson <sean.anderson@linux.dev>
Subject: [PATCH 2/3] phy: zynqmp: Don't wait for PLL lock on nonzero PCIe lanes
Date: Mon, 22 Apr 2024 14:58:02 -0400 [thread overview]
Message-ID: <20240422185803.3575319-3-sean.anderson@linux.dev> (raw)
In-Reply-To: <20240422185803.3575319-1-sean.anderson@linux.dev>
Similarly to DisplayPort, nonzero PCIe lanes never achieve PLL lock [1].
Don't wait for them.
Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
---
Maybe it's actually that only the final lane configured locks? I haven't
tested this out.
drivers/phy/xilinx/phy-zynqmp.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/phy/xilinx/phy-zynqmp.c b/drivers/phy/xilinx/phy-zynqmp.c
index b507ed4c3053..08c88dcd7799 100644
--- a/drivers/phy/xilinx/phy-zynqmp.c
+++ b/drivers/phy/xilinx/phy-zynqmp.c
@@ -624,11 +624,13 @@ static int xpsgtr_phy_power_on(struct phy *phy)
if (!xpsgtr_phy_init_required(gtr_phy))
return ret;
/*
- * Wait for the PLL to lock. For DP, only wait on DP0 to avoid
- * cumulating waits for both lanes. The user is expected to initialize
- * lane 0 last.
+ * Wait for the PLL to lock. For DP and PCIe, only wait on instance 0
+ * to avoid cumulative waits for both lanes. The user is expected to
+ * initialize lane 0 last.
*/
- if (gtr_phy->protocol != ICM_PROTOCOL_DP || !gtr_phy->instance)
+ if ((gtr_phy->protocol != ICM_PROTOCOL_DP &&
+ gtr_phy->protocol != ICM_PROTOCOL_PCIE) ||
+ !gtr_phy->instance)
ret = xpsgtr_wait_pll_lock(phy);
return ret;
--
2.35.1.1320.gc452695387.dirty
next prev parent reply other threads:[~2024-04-22 18:58 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 18:58 [PATCH 0/3] phy: zynqmp: A PCIe fix and debugfs support Sean Anderson
2024-04-22 18:58 ` Sean Anderson
2024-04-22 18:58 ` Sean Anderson
2024-04-22 18:58 ` [PATCH 1/3] phy: zynqmp: Store instance instead of type Sean Anderson
2024-04-22 18:58 ` Sean Anderson
2024-04-22 18:58 ` Sean Anderson
2024-04-23 6:25 ` Michal Simek
2024-04-23 6:25 ` Michal Simek
2024-04-23 6:25 ` Michal Simek
2024-04-23 15:02 ` Sean Anderson
2024-04-23 15:02 ` Sean Anderson
2024-04-23 15:02 ` Sean Anderson
2024-04-24 6:38 ` Michal Simek
2024-04-24 6:38 ` Michal Simek
2024-04-24 6:38 ` Michal Simek
2024-04-25 15:28 ` Sean Anderson
2024-04-25 15:28 ` Sean Anderson
2024-04-25 15:28 ` Sean Anderson
2024-04-22 18:58 ` Sean Anderson [this message]
2024-04-22 18:58 ` [PATCH 2/3] phy: zynqmp: Don't wait for PLL lock on nonzero PCIe lanes Sean Anderson
2024-04-22 18:58 ` Sean Anderson
2024-04-23 6:25 ` Michal Simek
2024-04-23 6:25 ` Michal Simek
2024-04-23 6:25 ` Michal Simek
2024-04-23 15:03 ` Sean Anderson
2024-04-23 15:03 ` Sean Anderson
2024-04-23 15:03 ` Sean Anderson
2024-04-22 18:58 ` [PATCH 3/3] phy: zynqmp: Add debugfs support Sean Anderson
2024-04-22 18:58 ` Sean Anderson
2024-04-22 18:58 ` Sean Anderson
2024-05-04 11:58 ` Vinod Koul
2024-05-04 11:58 ` Vinod Koul
2024-05-04 11:58 ` Vinod Koul
2024-05-06 14:51 ` Sean Anderson
2024-05-06 14:51 ` Sean Anderson
2024-05-06 14:51 ` Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240422185803.3575319-3-sean.anderson@linux.dev \
--to=sean.anderson@linux.dev \
--cc=kishon@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=michal.simek@amd.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.