From: Simon Horman <horms@kernel.org>
To: Marcin Szycik <marcin.szycik@linux.intel.com>
Cc: Wojciech Drewek <wojciech.drewek@intel.com>,
netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: remove correct filters during eswitch release
Date: Fri, 26 Apr 2024 19:29:45 +0100 [thread overview]
Message-ID: <20240426182945.GC516117@kernel.org> (raw)
In-Reply-To: <20240423143632.45086-1-marcin.szycik@linux.intel.com>
On Tue, Apr 23, 2024 at 04:36:32PM +0200, Marcin Szycik wrote:
> From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
>
> ice_clear_dflt_vsi() is only removing default rule. Both default RX and
> TX rule should be removed during release.
>
> If it isn't switching to switchdev, second time results in error, because
> TX filter is already there.
>
> Fix it by removing the correct set of rules.
>
> Fixes: 50d62022f455 ("ice: default Tx rule instead of to queue")
> Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> ---
> It is targetting iwl-next with fix, because the broken patch isn't yet
> in net repo.
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Marcin Szycik <marcin.szycik@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
Wojciech Drewek <wojciech.drewek@intel.com>
Subject: Re: [PATCH iwl-next] ice: remove correct filters during eswitch release
Date: Fri, 26 Apr 2024 19:29:45 +0100 [thread overview]
Message-ID: <20240426182945.GC516117@kernel.org> (raw)
In-Reply-To: <20240423143632.45086-1-marcin.szycik@linux.intel.com>
On Tue, Apr 23, 2024 at 04:36:32PM +0200, Marcin Szycik wrote:
> From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
>
> ice_clear_dflt_vsi() is only removing default rule. Both default RX and
> TX rule should be removed during release.
>
> If it isn't switching to switchdev, second time results in error, because
> TX filter is already there.
>
> Fix it by removing the correct set of rules.
>
> Fixes: 50d62022f455 ("ice: default Tx rule instead of to queue")
> Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> ---
> It is targetting iwl-next with fix, because the broken patch isn't yet
> in net repo.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-04-26 18:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 14:36 [Intel-wired-lan] [PATCH iwl-next] ice: remove correct filters during eswitch release Marcin Szycik
2024-04-23 14:36 ` Marcin Szycik
2024-04-26 18:29 ` Simon Horman [this message]
2024-04-26 18:29 ` Simon Horman
2024-05-07 7:10 ` [Intel-wired-lan] " Buvaneswaran, Sujai
2024-05-07 7:10 ` Buvaneswaran, Sujai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240426182945.GC516117@kernel.org \
--to=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=marcin.szycik@linux.intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.