Re: [PATCH v2 10/14] PCI: dw-rockchip: Add explicit rockchip,rk3588-pcie compatible

[Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>]

On Tue, Apr 30, 2024 at 02:01:07PM +0200, Niklas Cassel wrote:
> The rockchip-dw-pcie.yaml device tree binding already defines
> rockchip,rk3588-pcie as a supported compatible string.
> 
> Add an explicit rockchip,rk3588-pcie entry to make it easier to find the
> driver that implements this compatible string.
> 
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
> ---
>  drivers/pci/controller/dwc/pcie-dw-rockchip.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> index f985539fb00a..f38d267e4e64 100644
> --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> @@ -400,6 +400,10 @@ static const struct of_device_id rockchip_pcie_of_match[] = {
>  		.compatible = "rockchip,rk3568-pcie",
>  		.data = &rockchip_pcie_rc_of_data,
>  	},
> +	{
> +		.compatible = "rockchip,rk3588-pcie",
> +		.data = &rockchip_pcie_rc_of_data,

This is not required. In fact, it is encouraged to just use fallback compatible
in DT and not add new entries in driver.

- Mani

-- 
மணிவண்ணன் சதாசிவம்