All of lore.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Evan Green <evan@rivosinc.com>
Cc: "Jesse Taube" <jesse@rivosinc.com>,
	linux-riscv@lists.infradead.org,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Conor Dooley" <conor.dooley@microchip.com>,
	"Charlie Jenkins" <charlie@rivosinc.com>,
	"Andrew Jones" <ajones@ventanamicro.com>,
	"Clément Léger" <cleger@rivosinc.com>,
	"Xiao Wang" <xiao.w.wang@intel.com>,
	"Andy Chiu" <andy.chiu@sifive.com>,
	"Costa Shulyupin" <costa.shul@redhat.com>,
	"Björn Töpel" <bjorn@rivosinc.com>,
	"Ben Dooks" <ben.dooks@codethink.co.uk>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	"Alexandre Ghiti" <alexghiti@rivosinc.com>,
	"Erick Archer" <erick.archer@gmx.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v0] RISCV: Report vector unaligned accesses hwprobe
Date: Wed, 5 Jun 2024 17:34:51 +0100	[thread overview]
Message-ID: <20240605-swipe-giant-2f9659fbf430@spud> (raw)
In-Reply-To: <20240605-bullfight-ivory-b0151ad2b987@spud>


[-- Attachment #1.1: Type: text/plain, Size: 916 bytes --]

> On Wed, Jun 05, 2024 at 08:54:21AM -0700, Evan Green wrote:
> > On Tue, Jun 4, 2024 at 9:25 AM Jesse Taube <jesse@rivosinc.com> wrote:
> > What value should be returned when V is not enabled in the kernel, or
> > V is not supported in the hardware? Currently in the code it would be
> > UNKNOWN, right? Is that what we want, or is it worth differentiating
> > "no support for V" from "I don't know the speed of misaligned loads"?
> > Maybe UNKNOWN is the right value, as there are other values to tell
> > you V is not enabled.
> 
> I think UNKNOWN is fine for !V, assuming identical definitions as scalar.

I dunno, maybe we should set it to UNSUPPORTED in that case, but there's
probably some funny behaviour around the v prctl we might need to be
aware of. If the system has vector, we should probably figure out the
actual speed is, but not report it while vector is disabled from the
prctl?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Evan Green <evan@rivosinc.com>
Cc: "Jesse Taube" <jesse@rivosinc.com>,
	linux-riscv@lists.infradead.org,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Conor Dooley" <conor.dooley@microchip.com>,
	"Charlie Jenkins" <charlie@rivosinc.com>,
	"Andrew Jones" <ajones@ventanamicro.com>,
	"Clément Léger" <cleger@rivosinc.com>,
	"Xiao Wang" <xiao.w.wang@intel.com>,
	"Andy Chiu" <andy.chiu@sifive.com>,
	"Costa Shulyupin" <costa.shul@redhat.com>,
	"Björn Töpel" <bjorn@rivosinc.com>,
	"Ben Dooks" <ben.dooks@codethink.co.uk>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	"Alexandre Ghiti" <alexghiti@rivosinc.com>,
	"Erick Archer" <erick.archer@gmx.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v0] RISCV: Report vector unaligned accesses hwprobe
Date: Wed, 5 Jun 2024 17:34:51 +0100	[thread overview]
Message-ID: <20240605-swipe-giant-2f9659fbf430@spud> (raw)
In-Reply-To: <20240605-bullfight-ivory-b0151ad2b987@spud>

[-- Attachment #1: Type: text/plain, Size: 916 bytes --]

> On Wed, Jun 05, 2024 at 08:54:21AM -0700, Evan Green wrote:
> > On Tue, Jun 4, 2024 at 9:25 AM Jesse Taube <jesse@rivosinc.com> wrote:
> > What value should be returned when V is not enabled in the kernel, or
> > V is not supported in the hardware? Currently in the code it would be
> > UNKNOWN, right? Is that what we want, or is it worth differentiating
> > "no support for V" from "I don't know the speed of misaligned loads"?
> > Maybe UNKNOWN is the right value, as there are other values to tell
> > you V is not enabled.
> 
> I think UNKNOWN is fine for !V, assuming identical definitions as scalar.

I dunno, maybe we should set it to UNSUPPORTED in that case, but there's
probably some funny behaviour around the v prctl we might need to be
aware of. If the system has vector, we should probably figure out the
actual speed is, but not report it while vector is disabled from the
prctl?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2024-06-05 16:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-04 16:24 [RFC PATCH v0] RISCV: Report vector unaligned accesses hwprobe Jesse Taube
2024-06-04 16:24 ` Jesse Taube
2024-06-04 16:42 ` Jesse Taube
2024-06-04 16:42   ` Jesse Taube
2024-06-05  7:55   ` Clément Léger
2024-06-05  7:55     ` Clément Léger
2024-06-05 15:45   ` Conor Dooley
2024-06-05 15:45     ` Conor Dooley
2024-06-05 15:54 ` Evan Green
2024-06-05 15:54   ` Evan Green
2024-06-05 16:19   ` Jesse Taube
2024-06-05 16:19     ` Jesse Taube
2024-06-05 16:23   ` Conor Dooley
2024-06-05 16:23     ` Conor Dooley
2024-06-05 16:34     ` Conor Dooley [this message]
2024-06-05 16:34       ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240605-swipe-giant-2f9659fbf430@spud \
    --to=conor@kernel.org \
    --cc=ajones@ventanamicro.com \
    --cc=alexghiti@rivosinc.com \
    --cc=andy.chiu@sifive.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=ben.dooks@codethink.co.uk \
    --cc=bjorn@rivosinc.com \
    --cc=charlie@rivosinc.com \
    --cc=cleger@rivosinc.com \
    --cc=conor.dooley@microchip.com \
    --cc=costa.shul@redhat.com \
    --cc=erick.archer@gmx.com \
    --cc=evan@rivosinc.com \
    --cc=gustavoars@kernel.org \
    --cc=jesse@rivosinc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=xiao.w.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.