From: Simon Horman <horms@kernel.org>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Tomer Maimon <tmaimon77@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Eric Dumazet <edumazet@google.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Sagar Cheluvegowda <quic_scheluve@quicinc.com>,
Florian Fainelli <f.fainelli@gmail.com>,
openbmc@lists.ozlabs.org, Russell King <linux@armlinux.org.uk>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Jose Abreu <joabreu@synopsys.com>,
Abhishek Chauhan <quic_abchauha@quicinc.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Halaney <ahalaney@redhat.com>,
Jose Abreu <Jose.Abreu@synopsys.com>,
devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Mengyuan Lou <mengyuanlou@net-swift.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net-next v2 07/10] net: pcs: xpcs: Add Synopsys DW xPCS platform device driver
Date: Wed, 5 Jun 2024 18:48:17 +0100 [thread overview]
Message-ID: <20240605174817.GQ791188@kernel.org> (raw)
In-Reply-To: <20240602143636.5839-8-fancer.lancer@gmail.com>
On Sun, Jun 02, 2024 at 05:36:21PM +0300, Serge Semin wrote:
...
> diff --git a/drivers/net/pcs/pcs-xpcs-plat.c b/drivers/net/pcs/pcs-xpcs-plat.c
...
> +const struct dev_pm_ops xpcs_plat_pm_ops = {
> + SET_RUNTIME_PM_OPS(xpcs_plat_pm_runtime_suspend,
> + xpcs_plat_pm_runtime_resume,
> + NULL)
> +};
nit: xpcs_plat_pm_ops only seems to be used in this file.
If so it should probably be static.
Flagged by Sparse.
...
> +static struct platform_driver xpcs_plat_driver = {
> + .probe = xpcs_plat_probe,
> + .driver = {
> + .name = "dwxpcs",
> + .pm = &xpcs_plat_pm_ops,
> + .of_match_table = xpcs_of_ids,
> + },
> +};
> +module_platform_driver(xpcs_plat_driver);
...
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Jose Abreu <Jose.Abreu@synopsys.com>,
Vladimir Oltean <olteanv@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Sagar Cheluvegowda <quic_scheluve@quicinc.com>,
Abhishek Chauhan <quic_abchauha@quicinc.com>,
Andrew Halaney <ahalaney@redhat.com>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Mengyuan Lou <mengyuanlou@net-swift.com>,
Tomer Maimon <tmaimon77@gmail.com>,
openbmc@lists.ozlabs.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 07/10] net: pcs: xpcs: Add Synopsys DW xPCS platform device driver
Date: Wed, 5 Jun 2024 18:48:17 +0100 [thread overview]
Message-ID: <20240605174817.GQ791188@kernel.org> (raw)
In-Reply-To: <20240602143636.5839-8-fancer.lancer@gmail.com>
On Sun, Jun 02, 2024 at 05:36:21PM +0300, Serge Semin wrote:
...
> diff --git a/drivers/net/pcs/pcs-xpcs-plat.c b/drivers/net/pcs/pcs-xpcs-plat.c
...
> +const struct dev_pm_ops xpcs_plat_pm_ops = {
> + SET_RUNTIME_PM_OPS(xpcs_plat_pm_runtime_suspend,
> + xpcs_plat_pm_runtime_resume,
> + NULL)
> +};
nit: xpcs_plat_pm_ops only seems to be used in this file.
If so it should probably be static.
Flagged by Sparse.
...
> +static struct platform_driver xpcs_plat_driver = {
> + .probe = xpcs_plat_probe,
> + .driver = {
> + .name = "dwxpcs",
> + .pm = &xpcs_plat_pm_ops,
> + .of_match_table = xpcs_of_ids,
> + },
> +};
> +module_platform_driver(xpcs_plat_driver);
...
next prev parent reply other threads:[~2024-06-05 17:49 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-02 14:36 [PATCH net-next v2 00/10] net: pcs: xpcs: Add memory-mapped device support Serge Semin
2024-06-02 14:36 ` Serge Semin
2024-06-02 14:36 ` [PATCH net-next v2 01/10] net: pcs: xpcs: Move native device ID macro to linux/pcs/pcs-xpcs.h Serge Semin
2024-06-02 14:36 ` Serge Semin
2024-06-02 14:36 ` [PATCH net-next v2 02/10] net: pcs: xpcs: Split up xpcs_create() body to sub-functions Serge Semin
2024-06-02 14:36 ` Serge Semin
2024-06-02 14:36 ` [PATCH net-next v2 03/10] net: pcs: xpcs: Convert xpcs_id to dw_xpcs_desc Serge Semin
2024-06-02 14:36 ` Serge Semin
2024-06-02 14:36 ` [PATCH net-next v2 04/10] net: pcs: xpcs: Convert xpcs_compat to dw_xpcs_compat Serge Semin
2024-06-02 14:36 ` Serge Semin
2024-06-05 19:15 ` Abhishek Chauhan (ABC)
2024-06-06 10:11 ` Serge Semin
2024-06-06 10:11 ` Serge Semin
2024-06-02 14:36 ` [PATCH net-next v2 05/10] net: pcs: xpcs: Introduce DW XPCS info structure Serge Semin
2024-06-02 14:36 ` Serge Semin
2024-06-02 14:36 ` [PATCH net-next v2 06/10] dt-bindings: net: Add Synopsys DW xPCS bindings Serge Semin
2024-06-02 14:36 ` Serge Semin
2024-06-05 23:29 ` Rob Herring
2024-06-05 23:29 ` Rob Herring
2024-06-06 9:54 ` Serge Semin
2024-06-06 9:54 ` Serge Semin
2024-06-10 21:49 ` Rob Herring
2024-06-10 21:49 ` Rob Herring
2024-06-11 10:45 ` Serge Semin
2024-06-11 10:45 ` Serge Semin
2024-06-13 15:41 ` Rob Herring
2024-06-13 15:41 ` Rob Herring
2024-06-13 20:19 ` Serge Semin
2024-06-13 20:19 ` Serge Semin
2024-06-02 14:36 ` [PATCH net-next v2 07/10] net: pcs: xpcs: Add Synopsys DW xPCS platform device driver Serge Semin
2024-06-02 14:36 ` Serge Semin
2024-06-05 17:48 ` Simon Horman [this message]
2024-06-05 17:48 ` Simon Horman
2024-06-06 10:14 ` Serge Semin
2024-06-06 10:14 ` Serge Semin
2024-06-02 14:36 ` [PATCH net-next v2 08/10] net: pcs: xpcs: Add fwnode-based descriptor creation method Serge Semin
2024-06-02 14:36 ` Serge Semin
2024-06-05 17:49 ` Simon Horman
2024-06-05 17:49 ` Simon Horman
2024-06-06 10:24 ` Serge Semin
2024-06-06 10:24 ` Serge Semin
2024-06-02 14:36 ` [PATCH net-next v2 09/10] net: stmmac: Create DW XPCS device with particular address Serge Semin
2024-06-02 14:36 ` Serge Semin
2024-06-02 14:36 ` [PATCH net-next v2 10/10] net: stmmac: Add DW XPCS specified via "pcs-handle" support Serge Semin
2024-06-02 14:36 ` Serge Semin
2024-06-03 8:54 ` Serge Semin
2024-06-03 8:54 ` Serge Semin
2024-06-03 8:54 ` Serge Semin
2024-06-03 9:03 ` Russell King (Oracle)
2024-06-03 9:03 ` Russell King (Oracle)
2024-06-03 9:03 ` Russell King (Oracle)
2024-06-04 9:04 ` Serge Semin
2024-06-04 9:04 ` Serge Semin
2024-06-04 9:04 ` Serge Semin
2024-06-04 9:29 ` Russell King (Oracle)
2024-06-04 9:29 ` Russell King (Oracle)
2024-06-04 9:29 ` Russell King (Oracle)
2024-06-04 10:46 ` Serge Semin
2024-06-04 10:46 ` Serge Semin
2024-06-04 10:46 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240605174817.GQ791188@kernel.org \
--to=horms@kernel.org \
--cc=Jose.Abreu@synopsys.com \
--cc=ahalaney@redhat.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=fancer.lancer@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jiawenwu@trustnetic.com \
--cc=joabreu@synopsys.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=openbmc@lists.ozlabs.org \
--cc=pabeni@redhat.com \
--cc=quic_abchauha@quicinc.com \
--cc=quic_scheluve@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=tmaimon77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.