From: Lee Jones <lee@kernel.org>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Chen-Yu Tsai <wens@csie.org>, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sunxi@lists.linux.dev,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Ryan Walklin <ryan@testtoast.com>,
Chris Morgan <macroalpha82@gmail.com>
Subject: Re: [PATCH v2 2/5] regulator: axp20x: AXP717: fix LDO supply rails and off-by-ones
Date: Fri, 14 Jun 2024 09:12:24 +0100 [thread overview]
Message-ID: <20240614081224.GD2561462@google.com> (raw)
In-Reply-To: <f685b49a-36b1-46c9-a0a3-734bca8bd968@arm.com>
On Wed, 12 Jun 2024, Andre Przywara wrote:
> Hi Broonie,
>
> On 18/04/2024 01:07, Andre Przywara wrote:
> > The X-Powers AXP717 PMIC has separate input supply pins for each group
> > of LDOs, so they are not all using the same DCDC1 input, as described
> > currently.
> >
> > Replace the "supply" member of each LDO description with the respective
> > group supply name, so that the supply dependencies can be correctly
> > described in the devicetree.
> >
> > Also fix two off-by-ones in the regulator macros, after some double
> > checking the numbers against the datasheet. This uncovered a bug in the
> > datasheet: add a comment to document this.
> >
> > Fixes: d2ac3df75c3a ("regulator: axp20x: add support for the AXP717")
> > Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>
> Can you please take (at least) this one patch as a fix for 6.10? Applies
> cleanly on top of v6.10-rc3. The changes are not super-critical, but worth
> fixing nevertheless.
FWIW, I have no idea what's going on with this set now.
Once all of the necessary patches have been expedited, please gather
together what's left and I'll take them via MFD.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-06-14 8:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 0:07 [PATCH v2 0/5] regulator: Fix AXP717 PMIC support Andre Przywara
2024-04-18 0:07 ` [PATCH v2 1/5] mfd: axp20x: AXP717: Fix missing IRQ status registers range Andre Przywara
2024-04-23 0:16 ` John Watts
2024-05-02 9:39 ` Lee Jones
2024-06-12 15:07 ` Andre Przywara
2024-06-12 15:25 ` Lee Jones
2024-06-12 15:34 ` Andre Przywara
2024-06-12 15:48 ` Lee Jones
2024-06-13 9:48 ` Andre Przywara
2024-06-13 12:04 ` Lee Jones
2024-04-18 0:07 ` [PATCH v2 2/5] regulator: axp20x: AXP717: fix LDO supply rails and off-by-ones Andre Przywara
2024-04-23 0:09 ` John Watts
2024-06-12 14:40 ` Andre Przywara
2024-06-14 8:12 ` Lee Jones [this message]
2024-06-14 10:01 ` Andre Przywara
2024-04-18 0:07 ` [PATCH v2 3/5] dt-bindings: mfd: x-powers,axp152: add boost regulator Andre Przywara
2024-05-02 9:39 ` Lee Jones
2024-04-18 0:07 ` [PATCH v2 4/5] mfd: axp20x: AXP717: Add support for " Andre Przywara
2024-05-02 9:39 ` Lee Jones
2024-05-22 18:54 ` Chris Morgan
2024-04-18 0:07 ` [PATCH v2 5/5] regulator: axp20x: AXP717: Add " Andre Przywara
2024-04-23 5:19 ` [PATCH v2 0/5] regulator: Fix AXP717 PMIC support Mark Brown
2024-05-02 9:38 ` Lee Jones
2024-05-06 15:29 ` Mark Brown
2024-04-28 8:41 ` Ryan Walklin
2024-05-02 9:37 ` Lee Jones
2024-05-06 15:26 ` Mark Brown
2024-05-06 15:29 ` Mark Brown
2024-06-14 9:24 ` (subset) " Mark Brown
2024-08-01 15:22 ` Chen-Yu Tsai
2024-08-05 14:21 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240614081224.GD2561462@google.com \
--to=lee@kernel.org \
--cc=andre.przywara@arm.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=macroalpha82@gmail.com \
--cc=robh@kernel.org \
--cc=ryan@testtoast.com \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.