All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Andre Przywara <andre.przywara@arm.com>,
	Mark Brown <broonie@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-sunxi@lists.linux.dev,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	Ryan Walklin <ryan@testtoast.com>,
	Chris Morgan <macroalpha82@gmail.com>
Subject: Re: [PATCH v2 0/5] regulator: Fix AXP717 PMIC support
Date: Mon, 5 Aug 2024 15:21:49 +0100	[thread overview]
Message-ID: <20240805142149.GD1019230@google.com> (raw)
In-Reply-To: <CAGb2v64DLez_FwH=Na=swQ30BdZa8JPaueFkM=ozjU56=f1DXQ@mail.gmail.com>

On Thu, 01 Aug 2024, Chen-Yu Tsai wrote:

> Hi,
> 
> On Thu, Apr 18, 2024 at 8:07 AM Andre Przywara <andre.przywara@arm.com> wrote:
> >
> > This is v2 of the fixes to the AXP717 PMIC support series. Lee put the
> > original patches in an immutable branch already, so these here go on top.
> > Patch 1 is new in v2, and adds the IRQ status and acknowledge registers
> > to the writable range. Thanks to Chris for pointing this out.
> > Patch 2 contains fixes to the regulator descriptions: the LDOs had the
> > wrong supply source, and two numbers were wrong. The datasheet describes
> > the voltage ranges and register values differently from what our macros
> > expect, in a way that literally begs for off-by-ones, so here you go.
> > Also there is an actual wrong number in the datasheet, add a comment to
> > document this.
> > I don't know if that's still feasible, but those two patches would be a
> > good candidate to squash into the patches that they fix.
> >
> > The other three patches add the "boost" regulator, which is meant to
> > provide the 5V USB VBUS power when operating from the battery. It's the
> > usual trinity of binding/mfd/regulator patches.
> > Again this could be squashed into the respective patches from the
> > original series, if people agree.
> >
> > Please have a look and test!
> >
> > Based on mfd/ib-mfd-regulator-6.10, as detailed below.
> >
> > Cheers,
> > Andre
> >
> > Changelog v1 .. v2:
> > - add tags
> > - add patch to add missing IRQ ack register range
> > - add comment to document bug in datasheet
> >
> > Andre Przywara (5):
> >   mfd: axp20x: AXP717: Fix missing IRQ status registers range
> >   regulator: axp20x: AXP717: fix LDO supply rails and off-by-ones
> >   dt-bindings: mfd: x-powers,axp152: add boost regulator
> >   mfd: axp20x: AXP717: Add support for boost regulator
> >   regulator: axp20x: AXP717: Add boost regulator
> 
> The latter three patches still haven't been merged.
> 
> Andre, can you resend them for Lee or Mark to merge? Otherwise I
> can't take the RG35XXSP DT patches.

Right, please rebase and resubmit.  I've lost all context now.

-- 
Lee Jones [李琼斯]

      reply	other threads:[~2024-08-05 14:21 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18  0:07 [PATCH v2 0/5] regulator: Fix AXP717 PMIC support Andre Przywara
2024-04-18  0:07 ` [PATCH v2 1/5] mfd: axp20x: AXP717: Fix missing IRQ status registers range Andre Przywara
2024-04-23  0:16   ` John Watts
2024-05-02  9:39   ` Lee Jones
2024-06-12 15:07     ` Andre Przywara
2024-06-12 15:25       ` Lee Jones
2024-06-12 15:34         ` Andre Przywara
2024-06-12 15:48           ` Lee Jones
2024-06-13  9:48             ` Andre Przywara
2024-06-13 12:04               ` Lee Jones
2024-04-18  0:07 ` [PATCH v2 2/5] regulator: axp20x: AXP717: fix LDO supply rails and off-by-ones Andre Przywara
2024-04-23  0:09   ` John Watts
2024-06-12 14:40   ` Andre Przywara
2024-06-14  8:12     ` Lee Jones
2024-06-14 10:01       ` Andre Przywara
2024-04-18  0:07 ` [PATCH v2 3/5] dt-bindings: mfd: x-powers,axp152: add boost regulator Andre Przywara
2024-05-02  9:39   ` Lee Jones
2024-04-18  0:07 ` [PATCH v2 4/5] mfd: axp20x: AXP717: Add support for " Andre Przywara
2024-05-02  9:39   ` Lee Jones
2024-05-22 18:54   ` Chris Morgan
2024-04-18  0:07 ` [PATCH v2 5/5] regulator: axp20x: AXP717: Add " Andre Przywara
2024-04-23  5:19 ` [PATCH v2 0/5] regulator: Fix AXP717 PMIC support Mark Brown
2024-05-02  9:38   ` Lee Jones
2024-05-06 15:29     ` Mark Brown
2024-04-28  8:41 ` Ryan Walklin
2024-05-02  9:37   ` Lee Jones
2024-05-06 15:26 ` Mark Brown
2024-05-06 15:29 ` Mark Brown
2024-06-14  9:24 ` (subset) " Mark Brown
2024-08-01 15:22 ` Chen-Yu Tsai
2024-08-05 14:21   ` Lee Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240805142149.GD1019230@google.com \
    --to=lee@kernel.org \
    --cc=andre.przywara@arm.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=macroalpha82@gmail.com \
    --cc=ryan@testtoast.com \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.