All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Konstantin Taranov <kotaranov@microsoft.com>
Cc: RDMA mailing list <linux-rdma@vger.kernel.org>
Subject: Open-coded get_netdev implementation in MANA IB
Date: Mon, 17 Jun 2024 14:56:22 +0300	[thread overview]
Message-ID: <20240617115622.GC6805@unreal> (raw)

Hi,

I looked again on the patch 3b73eb3a4acd ("RDMA/mana_ib: Introduce mana_ib_get_netdev helper function")
and wonder if it is correct thing to do.

All new drivers shouldn't open-code get_netdev() and use the helpers ib_device_get_netdev() and
ib_device_set_netdev() instead of storing netdev in the driver.

Can you please convert MANA IB driver to proper API usage?

Thanks

             reply	other threads:[~2024-06-17 11:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-17 11:56 Leon Romanovsky [this message]
2024-06-17 12:11 ` Open-coded get_netdev implementation in MANA IB Konstantin Taranov
2024-06-17 12:38   ` Leon Romanovsky
2024-06-19 14:14     ` Konstantin Taranov
2024-06-21 18:10       ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240617115622.GC6805@unreal \
    --to=leon@kernel.org \
    --cc=kotaranov@microsoft.com \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.