All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Konstantin Taranov <kotaranov@microsoft.com>
Cc: RDMA mailing list <linux-rdma@vger.kernel.org>
Subject: Re: Open-coded get_netdev implementation in MANA IB
Date: Fri, 21 Jun 2024 21:10:33 +0300	[thread overview]
Message-ID: <20240621181033.GQ4025@unreal> (raw)
In-Reply-To: <PAXPR83MB05590EC3282ADD96AFFB149CB4CF2@PAXPR83MB0559.EURPRD83.prod.outlook.com>

On Wed, Jun 19, 2024 at 02:14:15PM +0000, Konstantin Taranov wrote:
> > Yes, the thing is that probably we were supposed to move to
> > ib_device_get_netdev() and don't invest time in mana_ib_get_netdev()
> > helper at all.
> > 
> > > I sure can fix it and use ib_device_get_netdev api.
> > >
> > > Should I send it to the rdma-next on the top of the latest commit?
> > 
> > Yes, please.
> > 
> 
> Hi Leon,
> 
> While preparing the patch, I realized that ib_device_get_netdev is not public
> and it is defined in core_priv.h. Should I move the declaration and export the symbol?

Let's keep it as is for now. I will try to return to this task after we
find a way to remove .get_netdev() callback from the drivers.

Sorry for wasting your time.

Thanks

> 
> Thanks

      reply	other threads:[~2024-06-21 18:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-17 11:56 Open-coded get_netdev implementation in MANA IB Leon Romanovsky
2024-06-17 12:11 ` Konstantin Taranov
2024-06-17 12:38   ` Leon Romanovsky
2024-06-19 14:14     ` Konstantin Taranov
2024-06-21 18:10       ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240621181033.GQ4025@unreal \
    --to=leon@kernel.org \
    --cc=kotaranov@microsoft.com \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.