From: Leon Romanovsky <leon@kernel.org>
To: Konstantin Taranov <kotaranov@microsoft.com>
Cc: RDMA mailing list <linux-rdma@vger.kernel.org>
Subject: Re: Open-coded get_netdev implementation in MANA IB
Date: Mon, 17 Jun 2024 15:38:24 +0300 [thread overview]
Message-ID: <20240617123824.GD6805@unreal> (raw)
In-Reply-To: <PAXPR83MB05592C30E6FEAE52F8B53E32B4CD2@PAXPR83MB0559.EURPRD83.prod.outlook.com>
On Mon, Jun 17, 2024 at 12:11:50PM +0000, Konstantin Taranov wrote:
> > Hi,
> >
> > I looked again on the patch 3b73eb3a4acd ("RDMA/mana_ib: Introduce
> > mana_ib_get_netdev helper function") and wonder if it is correct thing to do.
> >
> > All new drivers shouldn't open-code get_netdev() and use the helpers
> > ib_device_get_netdev() and
> > ib_device_set_netdev() instead of storing netdev in the driver.
> >
> > Can you please convert MANA IB driver to proper API usage?
>
> Hi Leon,
>
> This helper was introduced to remove a boiler plate code which was getting
> the netdev from gc->mana.driver_data.
Yes, the thing is that probably we were supposed to move to
ib_device_get_netdev() and don't invest time in mana_ib_get_netdev()
helper at all.
> I sure can fix it and use ib_device_get_netdev api.
>
> Should I send it to the rdma-next on the top of the latest commit?
Yes, please.
>
> Thanks
>
> >
> > Thanks
next prev parent reply other threads:[~2024-06-17 12:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 11:56 Open-coded get_netdev implementation in MANA IB Leon Romanovsky
2024-06-17 12:11 ` Konstantin Taranov
2024-06-17 12:38 ` Leon Romanovsky [this message]
2024-06-19 14:14 ` Konstantin Taranov
2024-06-21 18:10 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240617123824.GD6805@unreal \
--to=leon@kernel.org \
--cc=kotaranov@microsoft.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.