From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: "Aniket ." <aniketmaurya@google.com>
Cc: Jeremy Kerr <jk@codeconstruct.com.au>,
Joel Stanley <joel@jms.id.au>,
Billy Tsai <billy_tsai@aspeedtech.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] i3c: dw: Add optional apb clock
Date: Sun, 23 Jun 2024 00:27:25 +0200 [thread overview]
Message-ID: <202406222227157424f82d@mail.local> (raw)
In-Reply-To: <CAMmmMt21TAH3Vp8axtY9PoM0K6gzQqtMiHTaNGXKPW3J2DJF-Q@mail.gmail.com>
On 20/06/2024 11:42:25+0530, Aniket . wrote:
> Hey,
> > > > ret = clk_prepare_enable(master->core_clk);
> >
> > It could be worth having a look at devm_clk_get_optional_enabled
> Do we want to use *_enabled clock apis for both core_clk and pclk?
Yes
>
> Thanks,
> Aniket
>
> --
> linux-i3c mailing list
> linux-i3c@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-i3c
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: "Aniket ." <aniketmaurya@google.com>
Cc: Jeremy Kerr <jk@codeconstruct.com.au>,
Joel Stanley <joel@jms.id.au>,
Billy Tsai <billy_tsai@aspeedtech.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] i3c: dw: Add optional apb clock
Date: Sun, 23 Jun 2024 00:27:25 +0200 [thread overview]
Message-ID: <202406222227157424f82d@mail.local> (raw)
In-Reply-To: <CAMmmMt21TAH3Vp8axtY9PoM0K6gzQqtMiHTaNGXKPW3J2DJF-Q@mail.gmail.com>
On 20/06/2024 11:42:25+0530, Aniket . wrote:
> Hey,
> > > > ret = clk_prepare_enable(master->core_clk);
> >
> > It could be worth having a look at devm_clk_get_optional_enabled
> Do we want to use *_enabled clock apis for both core_clk and pclk?
Yes
>
> Thanks,
> Aniket
>
> --
> linux-i3c mailing list
> linux-i3c@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-i3c
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2024-06-22 22:27 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 17:15 [PATCH 0/2] i3c: dw: Add APB clk Aniket
2024-06-11 17:15 ` Aniket
2024-06-11 17:15 ` [PATCH 1/2] dt-bindings: i3c: dw: Add clock binding Aniket
2024-06-11 17:15 ` Aniket
2024-06-11 18:10 ` Conor Dooley
2024-06-11 18:10 ` Conor Dooley
2024-06-11 18:33 ` Rob Herring (Arm)
2024-06-11 18:33 ` Rob Herring (Arm)
2024-06-11 17:16 ` [PATCH 2/2] i3c: dw: Add optional apb clock Aniket
2024-06-11 17:16 ` Aniket
2024-06-18 20:05 ` Alexandre Belloni
2024-06-18 20:05 ` Alexandre Belloni
2024-06-18 20:09 ` Alexandre Belloni
2024-06-18 20:09 ` Alexandre Belloni
2024-06-20 6:12 ` Aniket .
2024-06-20 6:12 ` Aniket .
2024-06-22 22:27 ` Alexandre Belloni [this message]
2024-06-22 22:27 ` Alexandre Belloni
2024-06-24 5:28 ` [PATCH v2 0/3] i3c: dw: Add apb clk Aniket
2024-06-24 5:28 ` Aniket
2024-06-24 5:28 ` [PATCH v2 1/3] dt-bindings: i3c: dw: Add apb clock binding Aniket
2024-06-24 5:28 ` Aniket
2024-06-25 5:54 ` Krzysztof Kozlowski
2024-06-25 5:54 ` Krzysztof Kozlowski
2024-06-25 6:59 ` Aniket .
2024-06-25 6:59 ` Aniket .
2024-06-24 5:28 ` [PATCH v2 2/3] i3c: dw: Add optional apb clock Aniket
2024-06-24 5:28 ` Aniket
2024-06-24 5:28 ` [PATCH v2 3/3] i3c: dw: Use new *_enabled clk APIs Aniket
2024-06-24 5:28 ` Aniket
2024-06-24 5:50 ` [PATCH v2 0/3] i3c: dw: Add apb clk Krzysztof Kozlowski
2024-06-24 5:50 ` Krzysztof Kozlowski
2024-06-24 8:48 ` Aniket .
2024-06-24 8:48 ` Aniket .
2024-06-27 22:12 ` Alexandre Belloni
2024-06-27 22:12 ` Alexandre Belloni
2024-06-28 15:01 ` Aniket .
2024-06-28 15:01 ` Aniket .
2024-06-28 15:38 ` [PATCH v3 " Aniket
2024-06-28 15:38 ` Aniket
2024-07-02 15:46 ` Alexandre Belloni
2024-07-02 15:46 ` Alexandre Belloni
2024-06-28 15:45 ` [PATCH v3 1/3] dt-bindings: i3c: dw: Add apb clock binding Aniket
2024-06-28 15:45 ` Aniket
2024-06-28 16:30 ` Conor Dooley
2024-06-28 16:30 ` Conor Dooley
2024-07-01 3:39 ` Aniket .
2024-07-01 3:39 ` Aniket .
2024-06-28 15:46 ` [PATCH v3 2/3] i3c: dw: Use new *_enabled clk API Aniket
2024-06-28 15:46 ` Aniket
2024-06-28 15:46 ` [PATCH v3 3/3] i3c: dw: Add optional apb clock Aniket
2024-06-28 15:46 ` Aniket
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202406222227157424f82d@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=aniketmaurya@google.com \
--cc=billy_tsai@aspeedtech.com \
--cc=devicetree@vger.kernel.org \
--cc=jk@codeconstruct.com.au \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.