All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Aniket <aniketmaurya@google.com>
Cc: Jeremy Kerr <jk@codeconstruct.com.au>,
	Joel Stanley <joel@jms.id.au>,
	Billy Tsai <billy_tsai@aspeedtech.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 0/3] i3c: dw: Add apb clk
Date: Fri, 28 Jun 2024 00:12:25 +0200	[thread overview]
Message-ID: <20240627221225e3517e4e@mail.local> (raw)
In-Reply-To: <20240624052851.1030799-1-aniketmaurya@google.com>

On 24/06/2024 05:28:48+0000, Aniket wrote:
> These patches add APB clk aka pclk to the dw i3c driver
> and the binding doc. Also move to _enabled clk_get APIs.
> 
> Aniket (3):
>   dt-bindings: i3c: dw: Add apb clock binding
>   i3c: dw: Add optional apb clock
>   i3c: dw: Use new *_enabled clk APIs

You should reorder your patches to have 3/3 before 2/3, else you
introduce code that you immediately remove.

> 
>  .../bindings/i3c/snps,dw-i3c-master.yaml          | 11 ++++++++++-
>  drivers/i3c/master/dw-i3c-master.c                | 15 +++++----------
>  drivers/i3c/master/dw-i3c-master.h                |  1 +
>  3 files changed, 16 insertions(+), 11 deletions(-)
> 
> -- 
> 2.45.2.741.gdbec12cfda-goog
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Aniket <aniketmaurya@google.com>
Cc: Jeremy Kerr <jk@codeconstruct.com.au>,
	Joel Stanley <joel@jms.id.au>,
	Billy Tsai <billy_tsai@aspeedtech.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 0/3] i3c: dw: Add apb clk
Date: Fri, 28 Jun 2024 00:12:25 +0200	[thread overview]
Message-ID: <20240627221225e3517e4e@mail.local> (raw)
In-Reply-To: <20240624052851.1030799-1-aniketmaurya@google.com>

On 24/06/2024 05:28:48+0000, Aniket wrote:
> These patches add APB clk aka pclk to the dw i3c driver
> and the binding doc. Also move to _enabled clk_get APIs.
> 
> Aniket (3):
>   dt-bindings: i3c: dw: Add apb clock binding
>   i3c: dw: Add optional apb clock
>   i3c: dw: Use new *_enabled clk APIs

You should reorder your patches to have 3/3 before 2/3, else you
introduce code that you immediately remove.

> 
>  .../bindings/i3c/snps,dw-i3c-master.yaml          | 11 ++++++++++-
>  drivers/i3c/master/dw-i3c-master.c                | 15 +++++----------
>  drivers/i3c/master/dw-i3c-master.h                |  1 +
>  3 files changed, 16 insertions(+), 11 deletions(-)
> 
> -- 
> 2.45.2.741.gdbec12cfda-goog
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2024-06-27 22:12 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-11 17:15 [PATCH 0/2] i3c: dw: Add APB clk Aniket
2024-06-11 17:15 ` Aniket
2024-06-11 17:15 ` [PATCH 1/2] dt-bindings: i3c: dw: Add clock binding Aniket
2024-06-11 17:15   ` Aniket
2024-06-11 18:10   ` Conor Dooley
2024-06-11 18:10     ` Conor Dooley
2024-06-11 18:33   ` Rob Herring (Arm)
2024-06-11 18:33     ` Rob Herring (Arm)
2024-06-11 17:16 ` [PATCH 2/2] i3c: dw: Add optional apb clock Aniket
2024-06-11 17:16   ` Aniket
2024-06-18 20:05   ` Alexandre Belloni
2024-06-18 20:05     ` Alexandre Belloni
2024-06-18 20:09     ` Alexandre Belloni
2024-06-18 20:09       ` Alexandre Belloni
2024-06-20  6:12       ` Aniket .
2024-06-20  6:12         ` Aniket .
2024-06-22 22:27         ` Alexandre Belloni
2024-06-22 22:27           ` Alexandre Belloni
2024-06-24  5:28 ` [PATCH v2 0/3] i3c: dw: Add apb clk Aniket
2024-06-24  5:28   ` Aniket
2024-06-24  5:28   ` [PATCH v2 1/3] dt-bindings: i3c: dw: Add apb clock binding Aniket
2024-06-24  5:28     ` Aniket
2024-06-25  5:54     ` Krzysztof Kozlowski
2024-06-25  5:54       ` Krzysztof Kozlowski
2024-06-25  6:59       ` Aniket .
2024-06-25  6:59         ` Aniket .
2024-06-24  5:28   ` [PATCH v2 2/3] i3c: dw: Add optional apb clock Aniket
2024-06-24  5:28     ` Aniket
2024-06-24  5:28   ` [PATCH v2 3/3] i3c: dw: Use new *_enabled clk APIs Aniket
2024-06-24  5:28     ` Aniket
2024-06-24  5:50   ` [PATCH v2 0/3] i3c: dw: Add apb clk Krzysztof Kozlowski
2024-06-24  5:50     ` Krzysztof Kozlowski
2024-06-24  8:48     ` Aniket .
2024-06-24  8:48       ` Aniket .
2024-06-27 22:12   ` Alexandre Belloni [this message]
2024-06-27 22:12     ` Alexandre Belloni
2024-06-28 15:01     ` Aniket .
2024-06-28 15:01       ` Aniket .
2024-06-28 15:38   ` [PATCH v3 " Aniket
2024-06-28 15:38     ` Aniket
2024-07-02 15:46     ` Alexandre Belloni
2024-07-02 15:46       ` Alexandre Belloni
2024-06-28 15:45   ` [PATCH v3 1/3] dt-bindings: i3c: dw: Add apb clock binding Aniket
2024-06-28 15:45     ` Aniket
2024-06-28 16:30     ` Conor Dooley
2024-06-28 16:30       ` Conor Dooley
2024-07-01  3:39       ` Aniket .
2024-07-01  3:39         ` Aniket .
2024-06-28 15:46   ` [PATCH v3 2/3] i3c: dw: Use new *_enabled clk API Aniket
2024-06-28 15:46     ` Aniket
2024-06-28 15:46   ` [PATCH v3 3/3] i3c: dw: Add optional apb clock Aniket
2024-06-28 15:46     ` Aniket

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240627221225e3517e4e@mail.local \
    --to=alexandre.belloni@bootlin.com \
    --cc=aniketmaurya@google.com \
    --cc=billy_tsai@aspeedtech.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jk@codeconstruct.com.au \
    --cc=joel@jms.id.au \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.