All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>
Cc: dan.carpenter@linaro.org, Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Vladimir Zapolskiy <vz@mleia.com>, Arnd Bergmann <arnd@arndb.de>,
	Yangtao Li <frank.li@vivo.com>, Li Zetao <lizetao1@huawei.com>,
	linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: rawnand: lpx32xx: Fix dma_request_chan() error checks
Date: Fri, 5 Jul 2024 13:32:01 +0200	[thread overview]
Message-ID: <20240705133201.023cf3c7@xps-13> (raw)
In-Reply-To: <20240705093851.18107-1-piotr.wojtaszczyk@timesys.com>

Hi Piotr,

piotr.wojtaszczyk@timesys.com wrote on Fri,  5 Jul 2024 11:38:47 +0200:

> The dma_request_chan() returns error pointer in case of error, while
> dma_request_channel() returns NULL in case of error therefore different
> error checks are needed for the two.
> 
> Fixes: 7326d3fb1ee3 ("mtd: rawnand: lpx32xx: Request DMA channels
> using DT entries")

Pleae don't split the commit title over two lines.

Missing: Cc: stable.

> Signed-off-by: Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>
Cc: dan.carpenter@linaro.org, Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Vladimir Zapolskiy <vz@mleia.com>, Arnd Bergmann <arnd@arndb.de>,
	Yangtao Li <frank.li@vivo.com>, Li Zetao <lizetao1@huawei.com>,
	linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: rawnand: lpx32xx: Fix dma_request_chan() error checks
Date: Fri, 5 Jul 2024 13:32:01 +0200	[thread overview]
Message-ID: <20240705133201.023cf3c7@xps-13> (raw)
In-Reply-To: <20240705093851.18107-1-piotr.wojtaszczyk@timesys.com>

Hi Piotr,

piotr.wojtaszczyk@timesys.com wrote on Fri,  5 Jul 2024 11:38:47 +0200:

> The dma_request_chan() returns error pointer in case of error, while
> dma_request_channel() returns NULL in case of error therefore different
> error checks are needed for the two.
> 
> Fixes: 7326d3fb1ee3 ("mtd: rawnand: lpx32xx: Request DMA channels
> using DT entries")

Pleae don't split the commit title over two lines.

Missing: Cc: stable.

> Signed-off-by: Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>

Thanks,
Miquèl


  reply	other threads:[~2024-07-05 11:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-05  9:38 [PATCH] mtd: rawnand: lpx32xx: Fix dma_request_chan() error checks Piotr Wojtaszczyk
2024-07-05  9:38 ` Piotr Wojtaszczyk
2024-07-05 11:32 ` Miquel Raynal [this message]
2024-07-05 11:32   ` Miquel Raynal
2024-07-05 15:26 ` Markus Elfring
2024-07-05 15:26   ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240705133201.023cf3c7@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=arnd@arndb.de \
    --cc=dan.carpenter@linaro.org \
    --cc=frank.li@vivo.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=lizetao1@huawei.com \
    --cc=piotr.wojtaszczyk@timesys.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.