All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>,
	linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	Arnd Bergmann <arnd@arndb.de>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Vladimir Zapolskiy <vz@mleia.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Li Zetao <lizetao1@huawei.com>, Yangtao Li <frank.li@vivo.com>
Subject: Re: [PATCH] mtd: rawnand: lpx32xx: Fix dma_request_chan() error checks
Date: Fri, 5 Jul 2024 17:26:15 +0200	[thread overview]
Message-ID: <e3dc918e-07df-4fd1-b69a-9650a246ff7c@web.de> (raw)
In-Reply-To: <20240705093851.18107-1-piotr.wojtaszczyk@timesys.com>

…
> dma_request_channel() returns NULL in case of error …

* I find this information not relevant here because such a function
  is not called at the affected source code places.

* Please improve such a change description with imperative wordings.
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc6#n94


> Fixes: 7326d3fb1ee3 ("mtd: rawnand: lpx32xx: Request DMA channels
> using DT entries")

Please omit a line break from the tag summary.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc6#n145

Regards,
Markus

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>,
	linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	Arnd Bergmann <arnd@arndb.de>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Vladimir Zapolskiy <vz@mleia.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Li Zetao <lizetao1@huawei.com>, Yangtao Li <frank.li@vivo.com>
Subject: Re: [PATCH] mtd: rawnand: lpx32xx: Fix dma_request_chan() error checks
Date: Fri, 5 Jul 2024 17:26:15 +0200	[thread overview]
Message-ID: <e3dc918e-07df-4fd1-b69a-9650a246ff7c@web.de> (raw)
In-Reply-To: <20240705093851.18107-1-piotr.wojtaszczyk@timesys.com>

…
> dma_request_channel() returns NULL in case of error …

* I find this information not relevant here because such a function
  is not called at the affected source code places.

* Please improve such a change description with imperative wordings.
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc6#n94


> Fixes: 7326d3fb1ee3 ("mtd: rawnand: lpx32xx: Request DMA channels
> using DT entries")

Please omit a line break from the tag summary.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc6#n145

Regards,
Markus


  parent reply	other threads:[~2024-07-05 15:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-05  9:38 [PATCH] mtd: rawnand: lpx32xx: Fix dma_request_chan() error checks Piotr Wojtaszczyk
2024-07-05  9:38 ` Piotr Wojtaszczyk
2024-07-05 11:32 ` Miquel Raynal
2024-07-05 11:32   ` Miquel Raynal
2024-07-05 15:26 ` Markus Elfring [this message]
2024-07-05 15:26   ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3dc918e-07df-4fd1-b69a-9650a246ff7c@web.de \
    --to=markus.elfring@web.de \
    --cc=arnd@arndb.de \
    --cc=dan.carpenter@linaro.org \
    --cc=frank.li@vivo.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=lizetao1@huawei.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=piotr.wojtaszczyk@timesys.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.