[Buildroot] [PATCH 1/1] configs/stm32mp157c_dk2: bump Linux to 6.9

[Buildroot] [PATCH 1/1] configs/stm32mp157c_dk2: bump Linux to 6.9

[Raphael Gallais-Pou]

Base config on latest kernel version available.

Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com>
---
 configs/stm32mp157c_dk2_defconfig | 20 ++------------------
 1 file changed, 2 insertions(+), 18 deletions(-)

diff --git a/configs/stm32mp157c_dk2_defconfig b/configs/stm32mp157c_dk2_defconfig
index c48705b2fb..0e26042b90 100644
--- a/configs/stm32mp157c_dk2_defconfig
+++ b/configs/stm32mp157c_dk2_defconfig
@@ -1,31 +1,17 @@
-# Architecture
 BR2_arm=y
 BR2_cortex_a7=y
-
-# Linux headers same as kernel, a 5.13 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_13=y
-
-# System configuration
 BR2_ROOTFS_OVERLAY="board/stmicroelectronics/stm32mp157c-dk2/overlay/"
 BR2_ROOTFS_POST_IMAGE_SCRIPT="board/stmicroelectronics/common/stm32mp157/post-image.sh"
-
-# Kernel
 BR2_LINUX_KERNEL=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.13"
 BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
 BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/stmicroelectronics/stm32mp157c-dk2/linux.config"
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
-BR2_LINUX_KERNEL_INTREE_DTS_NAME="stm32mp157c-dk2"
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="st/stm32mp157c-dk2"
 BR2_LINUX_KERNEL_INSTALL_TARGET=y
-
-# Filesystem
 BR2_TARGET_ROOTFS_EXT2=y
 BR2_TARGET_ROOTFS_EXT2_4=y
 BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
 # BR2_TARGET_ROOTFS_TAR is not set
-
-# Bootloaders
 BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
 BR2_TARGET_ARM_TRUSTED_FIRMWARE_LATEST_LTS_2_8_VERSION=y
 BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="stm32mp1"
@@ -41,13 +27,11 @@ BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
 BR2_TARGET_UBOOT_CUSTOM_VERSION=y
 BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2023.04"
 BR2_TARGET_UBOOT_BOARD_DEFCONFIG="stm32mp15_trusted"
-# BR2_TARGET_UBOOT_FORMAT_BIN is not set
 BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
 BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
+# BR2_TARGET_UBOOT_FORMAT_BIN is not set
 BR2_TARGET_UBOOT_FORMAT_DTB=y
 BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
 BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot-nodtb.bin"
 BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="DEVICE_TREE=stm32mp157c-dk2"
-
-# Additional tools
 BR2_PACKAGE_HOST_GENIMAGE=y
-- 
2.45.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] configs/stm32mp157c_dk2: bump Linux to 6.9

[Thomas Petazzoni via buildroot]

Hello Raphael,

Thanks for your patch. See below a review.

On Fri, 12 Jul 2024 20:27:12 +0200
Raphael Gallais-Pou <rgallaispou@gmail.com> wrote:

> Base config on latest kernel version available.
> 
> Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com>
> ---
>  configs/stm32mp157c_dk2_defconfig | 20 ++------------------
>  1 file changed, 2 insertions(+), 18 deletions(-)
> 
> diff --git a/configs/stm32mp157c_dk2_defconfig b/configs/stm32mp157c_dk2_defconfig
> index c48705b2fb..0e26042b90 100644
> --- a/configs/stm32mp157c_dk2_defconfig
> +++ b/configs/stm32mp157c_dk2_defconfig
> @@ -1,31 +1,17 @@
> -# Architecture
>  BR2_arm=y
>  BR2_cortex_a7=y
> -
> -# Linux headers same as kernel, a 5.13 series
> -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_13=y

Please keep the comments and this option (but updated). It seems like
you did a "make savedefconfig", without really worrying about what
changed.

> -
> -# System configuration
>  BR2_ROOTFS_OVERLAY="board/stmicroelectronics/stm32mp157c-dk2/overlay/"
>  BR2_ROOTFS_POST_IMAGE_SCRIPT="board/stmicroelectronics/common/stm32mp157/post-image.sh"
> -
> -# Kernel
>  BR2_LINUX_KERNEL=y
> -BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> -BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.13"

We need to keep an explicit kernel version, so that it doesn't
automatically uses the "latest".

I believe it would also make sense to update TF-A and U-Boot at the
same time.

Could you fix up those details, and submit an updated version?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] configs/stm32mp157c_dk2: bump Linux to 6.9

[Raphaël Gallais-Pou]

Le 12/07/2024 à 21:11, Thomas Petazzoni a écrit :
> Hello Raphael,
> 
> Thanks for your patch. See below a review.
> 
> On Fri, 12 Jul 2024 20:27:12 +0200
> Raphael Gallais-Pou <rgallaispou@gmail.com> wrote:
> 
>> Base config on latest kernel version available.
>>
>> Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com>
>> ---
>>   configs/stm32mp157c_dk2_defconfig | 20 ++------------------
>>   1 file changed, 2 insertions(+), 18 deletions(-)
>>
>> diff --git a/configs/stm32mp157c_dk2_defconfig b/configs/stm32mp157c_dk2_defconfig
>> index c48705b2fb..0e26042b90 100644
>> --- a/configs/stm32mp157c_dk2_defconfig
>> +++ b/configs/stm32mp157c_dk2_defconfig
>> @@ -1,31 +1,17 @@
>> -# Architecture
>>   BR2_arm=y
>>   BR2_cortex_a7=y
>> -
>> -# Linux headers same as kernel, a 5.13 series
>> -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_13=y
> 
> Please keep the comments and this option (but updated). It seems like
> you did a "make savedefconfig", without really worrying about what
> changed.
> 
Hi Thomas,

Thanks for the quick review.

Indeed, this is exactly what I did. I (wrongly) did not compared with 
similar changes even though this was my first contribution to Buildroot.

My bad.

>> -
>> -# System configuration
>>   BR2_ROOTFS_OVERLAY="board/stmicroelectronics/stm32mp157c-dk2/overlay/"
>>   BR2_ROOTFS_POST_IMAGE_SCRIPT="board/stmicroelectronics/common/stm32mp157/post-image.sh"
>> -
>> -# Kernel
>>   BR2_LINUX_KERNEL=y
>> -BR2_LINUX_KERNEL_CUSTOM_VERSION=y
>> -BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.13"
> 
> We need to keep an explicit kernel version, so that it doesn't
> automatically uses the "latest".

Makes sense in order not to introduce systematic uncontrolled breaks in 
the swarm of boards.

> 
> I believe it would also make sense to update TF-A and U-Boot at the
> same time.
> 
> Could you fix up those details, and submit an updated version?

Yes, I'll do some testing before and then send a v2.

Thanks,
Raphaël
> 
> Thanks a lot!
> 
> Thomas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot