All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/qt6/qt6opcua: new package
@ 2024-07-17 19:48 Andreas Naumann
  2024-07-17 20:59 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 3+ messages in thread
From: Andreas Naumann @ 2024-07-17 19:48 UTC (permalink / raw)
  To: buildroot
  Cc: Andreas Naumann, Jesse Van Gavere, Samuel Martin,
	Roy Kollen Svendsen, Thomas Petazzoni

Add qt6 version of qtopcua from git as it's not contained in the
official qt release submodule directory.

Fulfill the mandatory dependency on qt6base, and qt6base-network in
particular, as well as the need for host tool qopcuaxmldatatypes2cpp
which is provided by host-qt6opcua.
For host-qt6opcua set the dependency on host-qt6base-network as well.

Existence of the optional dependency openssl enables
FEATURE_open62541_security. (This has changed from qt5opcua where
mbedtls was supported.)

Signed-off-by: Andreas Naumann <anaumann@ultratronik.de>
---
 package/qt6/Config.in              |  1 +
 package/qt6/qt6opcua/Config.in     | 14 +++++++++
 package/qt6/qt6opcua/qt6opcua.hash |  9 ++++++
 package/qt6/qt6opcua/qt6opcua.mk   | 46 ++++++++++++++++++++++++++++++
 4 files changed, 70 insertions(+)
 create mode 100644 package/qt6/qt6opcua/Config.in
 create mode 100644 package/qt6/qt6opcua/qt6opcua.hash
 create mode 100644 package/qt6/qt6opcua/qt6opcua.mk

diff --git a/package/qt6/Config.in b/package/qt6/Config.in
index e84806d5e4..29c1c25c7f 100644
--- a/package/qt6/Config.in
+++ b/package/qt6/Config.in
@@ -48,6 +48,7 @@ source "package/qt6/qt6core5compat/Config.in"
 source "package/qt6/qt6declarative/Config.in"
 source "package/qt6/qt6languageserver/Config.in"
 source "package/qt6/qt6mqtt/Config.in"
+source "package/qt6/qt6opcua/Config.in"
 source "package/qt6/qt6serialbus/Config.in"
 source "package/qt6/qt6serialport/Config.in"
 source "package/qt6/qt6shadertools/Config.in"
diff --git a/package/qt6/qt6opcua/Config.in b/package/qt6/qt6opcua/Config.in
new file mode 100644
index 0000000000..84a51f544f
--- /dev/null
+++ b/package/qt6/qt6opcua/Config.in
@@ -0,0 +1,14 @@
+config BR2_PACKAGE_QT6OPCUA
+	bool "qt6opcua"
+	select BR2_PACKAGE_QT6BASE_NETWORK
+        # qt6opcuda needs host-qt6opcua, and host-qt6opcua needs
+        # network support in qt6base.
+	select BR2_PACKAGE_HOST_QT6BASE_NETWORK
+
+	help
+	  Qt is a cross-platform application and UI framework for
+	  developers using C++.
+
+	  This package corresponds to the qt6opcua module.
+
+	  https://doc.qt.io/qt-6/qtopcua-index.html
diff --git a/package/qt6/qt6opcua/qt6opcua.hash b/package/qt6/qt6opcua/qt6opcua.hash
new file mode 100644
index 0000000000..cf54bef98e
--- /dev/null
+++ b/package/qt6/qt6opcua/qt6opcua.hash
@@ -0,0 +1,9 @@
+sha256  653597e2926ddb512f078bab1e5d2a059202ba1bc1f68ff0b4a0e053ab1272b2  qt6opcua-6.7.2-git4.tar.gz
+
+# Hashes for license files:
+sha256  9f0490f18656c6f2435bd14f603ef0c96434d1825615363dce43abb42ed1dcce  LICENSES/BSD-3-Clause.txt
+sha256  110535522396708cea37c72a802c5e7e81391139f5f7985631c93ef242b206a4  LICENSES/GFDL-1.3-no-invariants-only.txt
+sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  LICENSES/GPL-2.0-only.txt
+sha256  8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903  LICENSES/GPL-3.0-only.txt
+sha256  da7eabb7bafdf7d3ae5e9f223aa5bdc1eece45ac569dc21b3b037520b4464768  LICENSES/LGPL-3.0-only.txt
+sha256  40678d338ce53cd93f8b22b281a2ecbcaa3ee65ce60b25ffb0c462b0530846b2  LICENSES/Qt-GPL-exception-1.0.txt
diff --git a/package/qt6/qt6opcua/qt6opcua.mk b/package/qt6/qt6opcua/qt6opcua.mk
new file mode 100644
index 0000000000..d8bd492233
--- /dev/null
+++ b/package/qt6/qt6opcua/qt6opcua.mk
@@ -0,0 +1,46 @@
+################################################################################
+#
+# qt6opcua
+#
+################################################################################
+
+QT6OPCUA_VERSION = $(QT6_VERSION)
+QT6OPCUA_SITE = $(QT6_GIT)/qt/qtopcua.git
+QT6OPCUA_SITE_METHOD = git
+QT6OPCUA_INSTALL_STAGING = YES
+QT6OPCUA_SUPPORTS_IN_SOURCE_BUILD = NO
+
+QT6OPCUA_CMAKE_BACKEND = ninja
+
+QT6OPCUA_LICENSE = \
+	GPL-2.0 or GPL-3.0 or LGPL-3.0, \
+	GPL-3.0 WITH Qt-GPL-exception-1.0 (tools), \
+	GFDL-1.3 no invariants (docs), \
+	BSD-3-Clause (examples + buildsystem)
+
+QT6OPCUA_LICENSE_FILES = \
+	LICENSES/BSD-3-Clause.txt \
+	LICENSES/GFDL-1.3-no-invariants-only.txt \
+	LICENSES/GPL-2.0-only.txt \
+	LICENSES/GPL-3.0-only.txt \
+	LICENSES/LGPL-3.0-only.txt \
+	LICENSES/Qt-GPL-exception-1.0.txt
+
+QT6OPCUA_CONF_OPTS = \
+	-DQT_HOST_PATH=$(HOST_DIR) \
+	-DBUILD_WITH_PCH=OFF
+
+HOST_QT6OPCUA_CONF_OPTS = \
+	-DQT_HOST_PATH=$(HOST_DIR) \
+	-DBUILD_WITH_PCH=OFF
+
+QT6OPCUA_DEPENDENCIES = \
+	qt6base \
+	host-qt6opcua
+
+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+QT6OPCUA_DEPENDENCIES += openssl
+endif
+
+$(eval $(cmake-package))
+$(eval $(host-cmake-package))
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/qt6/qt6opcua: new package
  2024-07-17 19:48 [Buildroot] [PATCH 1/1] package/qt6/qt6opcua: new package Andreas Naumann
@ 2024-07-17 20:59 ` Thomas Petazzoni via buildroot
  2024-07-22  8:12   ` Andreas Naumann
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-07-17 20:59 UTC (permalink / raw)
  To: Andreas Naumann
  Cc: Jesse Van Gavere, Samuel Martin, Roy Kollen Svendsen, buildroot

Hello Andreas,

On Wed, 17 Jul 2024 21:48:08 +0200
Andreas Naumann <anaumann@ultratronik.de> wrote:

> Add qt6 version of qtopcua from git as it's not contained in the
> official qt release submodule directory.
> 
> Fulfill the mandatory dependency on qt6base, and qt6base-network in
> particular, as well as the need for host tool qopcuaxmldatatypes2cpp
> which is provided by host-qt6opcua.
> For host-qt6opcua set the dependency on host-qt6base-network as well.
> 
> Existence of the optional dependency openssl enables
> FEATURE_open62541_security. (This has changed from qt5opcua where
> mbedtls was supported.)
> 
> Signed-off-by: Andreas Naumann <anaumann@ultratronik.de>

Thanks applied, with minor changes, see below.

> ---
>  package/qt6/Config.in              |  1 +
>  package/qt6/qt6opcua/Config.in     | 14 +++++++++
>  package/qt6/qt6opcua/qt6opcua.hash |  9 ++++++
>  package/qt6/qt6opcua/qt6opcua.mk   | 46 ++++++++++++++++++++++++++++++
>  4 files changed, 70 insertions(+)

Entry in DEVELOPERS file missing.



>  create mode 100644 package/qt6/qt6opcua/Config.in
>  create mode 100644 package/qt6/qt6opcua/qt6opcua.hash
>  create mode 100644 package/qt6/qt6opcua/qt6opcua.mk
> 
> diff --git a/package/qt6/Config.in b/package/qt6/Config.in
> index e84806d5e4..29c1c25c7f 100644
> --- a/package/qt6/Config.in
> +++ b/package/qt6/Config.in
> @@ -48,6 +48,7 @@ source "package/qt6/qt6core5compat/Config.in"
>  source "package/qt6/qt6declarative/Config.in"
>  source "package/qt6/qt6languageserver/Config.in"
>  source "package/qt6/qt6mqtt/Config.in"
> +source "package/qt6/qt6opcua/Config.in"
>  source "package/qt6/qt6serialbus/Config.in"
>  source "package/qt6/qt6serialport/Config.in"
>  source "package/qt6/qt6shadertools/Config.in"
> diff --git a/package/qt6/qt6opcua/Config.in b/package/qt6/qt6opcua/Config.in
> new file mode 100644
> index 0000000000..84a51f544f
> --- /dev/null
> +++ b/package/qt6/qt6opcua/Config.in
> @@ -0,0 +1,14 @@
> +config BR2_PACKAGE_QT6OPCUA
> +	bool "qt6opcua"
> +	select BR2_PACKAGE_QT6BASE_NETWORK
> +        # qt6opcuda needs host-qt6opcua, and host-qt6opcua needs
> +        # network support in qt6base.

Dang, I realize now the indentation here is with spaces, it should have
been with tabs. I'll fix that up.


> +QT6OPCUA_LICENSE = \
> +	GPL-2.0 or GPL-3.0 or LGPL-3.0, \
> +	GPL-3.0 WITH Qt-GPL-exception-1.0 (tools), \

The tools are also under "GPL-2.0 or GPL-3.0 or LGPL-3.0" as far I can
see, so I dropped this line.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/qt6/qt6opcua: new package
  2024-07-17 20:59 ` Thomas Petazzoni via buildroot
@ 2024-07-22  8:12   ` Andreas Naumann
  0 siblings, 0 replies; 3+ messages in thread
From: Andreas Naumann @ 2024-07-22  8:12 UTC (permalink / raw)
  To: Thomas Petazzoni, Andreas Naumann
  Cc: Jesse Van Gavere, Samuel Martin, Roy Kollen Svendsen, buildroot

Hi Thomas,

On 17.07.24 22:59, Thomas Petazzoni via buildroot wrote:
> Hello Andreas,
...
> 
> Thanks applied, with minor changes, see below.

Thanks for applying and fixing.

> 
>> ---
>>  package/qt6/Config.in              |  1 +
>>  package/qt6/qt6opcua/Config.in     | 14 +++++++++
>>  package/qt6/qt6opcua/qt6opcua.hash |  9 ++++++
>>  package/qt6/qt6opcua/qt6opcua.mk   | 46 ++++++++++++++++++++++++++++++
>>  4 files changed, 70 insertions(+)
> 
> Entry in DEVELOPERS file missing.

ok.

> 
> 
> 
>>  create mode 100644 package/qt6/qt6opcua/Config.in
>>  create mode 100644 package/qt6/qt6opcua/qt6opcua.hash
>>  create mode 100644 package/qt6/qt6opcua/qt6opcua.mk
>>
>> diff --git a/package/qt6/Config.in b/package/qt6/Config.in
>> index e84806d5e4..29c1c25c7f 100644
>> --- a/package/qt6/Config.in
>> +++ b/package/qt6/Config.in
>> @@ -48,6 +48,7 @@ source "package/qt6/qt6core5compat/Config.in"
>>  source "package/qt6/qt6declarative/Config.in"
>>  source "package/qt6/qt6languageserver/Config.in"
>>  source "package/qt6/qt6mqtt/Config.in"
>> +source "package/qt6/qt6opcua/Config.in"
>>  source "package/qt6/qt6serialbus/Config.in"
>>  source "package/qt6/qt6serialport/Config.in"
>>  source "package/qt6/qt6shadertools/Config.in"
>> diff --git a/package/qt6/qt6opcua/Config.in b/package/qt6/qt6opcua/Config.in
>> new file mode 100644
>> index 0000000000..84a51f544f
>> --- /dev/null
>> +++ b/package/qt6/qt6opcua/Config.in
>> @@ -0,0 +1,14 @@
>> +config BR2_PACKAGE_QT6OPCUA
>> +	bool "qt6opcua"
>> +	select BR2_PACKAGE_QT6BASE_NETWORK
>> +        # qt6opcuda needs host-qt6opcua, and host-qt6opcua needs
>> +        # network support in qt6base.
> 
> Dang, I realize now the indentation here is with spaces, it should have
> been with tabs. I'll fix that up.

Damn, i was using some copypasta and was relying on check-package to
complain.

> 
> 
>> +QT6OPCUA_LICENSE = \
>> +	GPL-2.0 or GPL-3.0 or LGPL-3.0, \
>> +	GPL-3.0 WITH Qt-GPL-exception-1.0 (tools), \
> 
> The tools are also under "GPL-2.0 or GPL-3.0 or LGPL-3.0" as far I can
> see, so I dropped this line.

Thanks for checking. And was not very confident in how to reliably get
this information. Basically I tried to reflect the contents of
licenseRule.json.


regards,
Andreas


> 
> Thanks!
> 
> Thomas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-22  8:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-17 19:48 [Buildroot] [PATCH 1/1] package/qt6/qt6opcua: new package Andreas Naumann
2024-07-17 20:59 ` Thomas Petazzoni via buildroot
2024-07-22  8:12   ` Andreas Naumann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.