From: Petr Vorel <pvorel@suse.cz>
To: Jens Axboe <axboe@kernel.dk>
Cc: ltp@lists.linux.it, linux-block@vger.kernel.org,
linux-btrfs@vger.kernel.org, linux-xfs@vger.kernel.org,
fstests@vger.kernel.org, Jan Kara <jack@suse.cz>,
David Sterba <dsterba@suse.com>,
Filipe Manana <fdmanana@suse.com>,
Amir Goldstein <amir73il@gmail.com>,
Cyril Hrubis <chrubis@suse.cz>,
Andrea Cervesato <andrea.cervesato@suse.com>,
Avinesh Kumar <akumar@suse.de>
Subject: Re: [RFC] Slow down of LTP tests aiodio_sparse.c and dio_sparse.c in kernel 6.6
Date: Fri, 19 Jul 2024 22:13:52 +0200 [thread overview]
Message-ID: <20240719201352.GA782769@pevik> (raw)
In-Reply-To: <a59b75dd-8e82-4508-a34e-230827557dcb@kernel.dk>
Hi Jens, all,
> On 7/19/24 11:43 AM, Petr Vorel wrote:
> > Hi all,
> > LTP AIO DIO tests aiodio_sparse.c [1] and dio_sparse.c [2] (using [3]) slowed
> > down on kernel 6.6 on Btrfs and XFS, when run with default parameters. These
> > tests create 100 MB sparse file and write zeros (using libaio or O_DIRECT) while
> > 16 other processes reads the buffer and check only zero is there.
> > Runtime of this particular setup (i.e. 100 MB file) on Btrfs and XFS on the
> > same system slowed down 9x (6.5: ~1 min 6.6: ~9 min). Ext4 is not affected.
> > (Non default parameter creates much smaller file, thus the change is not that
> > obvious).
> > Because the slowdown has been here for few kernel releases I suppose nobody
> > complained and the test is somehow artificial (nobody uses this in a real world).
> > But still it'd be good to double check the problem. I can bisect a particular
> > commit.
> > Because 2 filesystems affected, could be "Improve asynchronous iomap DIO
> > performance" [4] block layer change somehow related?
> No, because that got disabled before release for unrelated reasons. Why
> don't you just bisect it, since you have a simple test case?
Jens, thanks for info. Sure, I'll bisect next week and report.
The reason I reported before bisecting is because it wouldn't be the first time
the test was "artificial" and therefore reported problem was not fixed. If it's
a real problem I would expect it would be also caught by other people or even by
fstests.
Kind regards,
Petr
WARNING: multiple messages have this Message-ID (diff)
From: Petr Vorel <pvorel@suse.cz>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-xfs@vger.kernel.org, Jan Kara <jack@suse.cz>,
fstests@vger.kernel.org, linux-block@vger.kernel.org,
Filipe Manana <fdmanana@suse.com>,
ltp@lists.linux.it, David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [LTP] [RFC] Slow down of LTP tests aiodio_sparse.c and dio_sparse.c in kernel 6.6
Date: Fri, 19 Jul 2024 22:13:52 +0200 [thread overview]
Message-ID: <20240719201352.GA782769@pevik> (raw)
In-Reply-To: <a59b75dd-8e82-4508-a34e-230827557dcb@kernel.dk>
Hi Jens, all,
> On 7/19/24 11:43 AM, Petr Vorel wrote:
> > Hi all,
> > LTP AIO DIO tests aiodio_sparse.c [1] and dio_sparse.c [2] (using [3]) slowed
> > down on kernel 6.6 on Btrfs and XFS, when run with default parameters. These
> > tests create 100 MB sparse file and write zeros (using libaio or O_DIRECT) while
> > 16 other processes reads the buffer and check only zero is there.
> > Runtime of this particular setup (i.e. 100 MB file) on Btrfs and XFS on the
> > same system slowed down 9x (6.5: ~1 min 6.6: ~9 min). Ext4 is not affected.
> > (Non default parameter creates much smaller file, thus the change is not that
> > obvious).
> > Because the slowdown has been here for few kernel releases I suppose nobody
> > complained and the test is somehow artificial (nobody uses this in a real world).
> > But still it'd be good to double check the problem. I can bisect a particular
> > commit.
> > Because 2 filesystems affected, could be "Improve asynchronous iomap DIO
> > performance" [4] block layer change somehow related?
> No, because that got disabled before release for unrelated reasons. Why
> don't you just bisect it, since you have a simple test case?
Jens, thanks for info. Sure, I'll bisect next week and report.
The reason I reported before bisecting is because it wouldn't be the first time
the test was "artificial" and therefore reported problem was not fixed. If it's
a real problem I would expect it would be also caught by other people or even by
fstests.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-07-19 20:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 17:43 [RFC] Slow down of LTP tests aiodio_sparse.c and dio_sparse.c in kernel 6.6 Petr Vorel
2024-07-19 17:43 ` [LTP] " Petr Vorel
2024-07-19 18:36 ` Jens Axboe
2024-07-19 18:36 ` [LTP] " Jens Axboe
2024-07-19 20:13 ` Petr Vorel [this message]
2024-07-19 20:13 ` Petr Vorel
2024-07-19 20:21 ` Jens Axboe
2024-07-19 20:21 ` [LTP] " Jens Axboe
2024-07-22 9:00 ` Jan Kara
2024-07-22 9:00 ` [LTP] " Jan Kara
2024-07-22 13:13 ` Petr Vorel
2024-07-22 13:13 ` [LTP] " Petr Vorel
2024-07-24 13:18 ` Petr Vorel
2024-07-24 13:18 ` [LTP] " Petr Vorel
2024-07-24 16:29 ` Mike Galbraith
2024-07-24 16:29 ` [LTP] " Mike Galbraith via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240719201352.GA782769@pevik \
--to=pvorel@suse.cz \
--cc=akumar@suse.de \
--cc=amir73il@gmail.com \
--cc=andrea.cervesato@suse.com \
--cc=axboe@kernel.dk \
--cc=chrubis@suse.cz \
--cc=dsterba@suse.com \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.