All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Jan Kara <jack@suse.cz>
Cc: ltp@lists.linux.it, linux-block@vger.kernel.org,
	linux-btrfs@vger.kernel.org, linux-xfs@vger.kernel.org,
	fstests@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	David Sterba <dsterba@suse.com>,
	Filipe Manana <fdmanana@suse.com>,
	Amir Goldstein <amir73il@gmail.com>,
	Cyril Hrubis <chrubis@suse.cz>,
	Andrea Cervesato <andrea.cervesato@suse.com>,
	Avinesh Kumar <akumar@suse.de>
Subject: Re: [RFC] Slow down of LTP tests aiodio_sparse.c and dio_sparse.c in kernel 6.6
Date: Mon, 22 Jul 2024 15:13:54 +0200	[thread overview]
Message-ID: <20240722131354.GA858324@pevik> (raw)
In-Reply-To: <20240722090012.mlvkaenuxar2x3vr@quack3>

Hi Jan, all,

> Hi!

> On Fri 19-07-24 19:43:25, Petr Vorel wrote:
> > LTP AIO DIO tests aiodio_sparse.c [1] and dio_sparse.c [2] (using [3])
> > slowed down on kernel 6.6 on Btrfs and XFS, when run with default
> > parameters. These tests create 100 MB sparse file and write zeros (using
> > libaio or O_DIRECT) while 16 other processes reads the buffer and check
> > only zero is there.

> So the performance of this test is irrelevant because combining buffered
> reads with direct IO writes was always in "better don't do it" territory.
> Definitely not if you care about perfomance.

Thanks a lot for having a look, Jan!

> > Runtime of this particular setup (i.e. 100 MB file) on Btrfs and XFS on the
> > same system slowed down 9x (6.5: ~1 min 6.6: ~9 min). Ext4 is not affected.
> > (Non default parameter creates much smaller file, thus the change is not that
> > obvious).

> But still it's kind of curious what caused the 9x slow down. So I'd be
> curious to know the result of the bisection :). Thanks for report!

I'm already working on it, report soon.

Kind regards,
Petr

> 								Honza

WARNING: multiple messages have this Message-ID (diff)
From: Petr Vorel <pvorel@suse.cz>
To: Jan Kara <jack@suse.cz>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-xfs@vger.kernel.org, fstests@vger.kernel.org,
	linux-block@vger.kernel.org, Filipe Manana <fdmanana@suse.com>,
	ltp@lists.linux.it, David Sterba <dsterba@suse.com>,
	linux-btrfs@vger.kernel.org
Subject: Re: [LTP] [RFC] Slow down of LTP tests aiodio_sparse.c and dio_sparse.c in kernel 6.6
Date: Mon, 22 Jul 2024 15:13:54 +0200	[thread overview]
Message-ID: <20240722131354.GA858324@pevik> (raw)
In-Reply-To: <20240722090012.mlvkaenuxar2x3vr@quack3>

Hi Jan, all,

> Hi!

> On Fri 19-07-24 19:43:25, Petr Vorel wrote:
> > LTP AIO DIO tests aiodio_sparse.c [1] and dio_sparse.c [2] (using [3])
> > slowed down on kernel 6.6 on Btrfs and XFS, when run with default
> > parameters. These tests create 100 MB sparse file and write zeros (using
> > libaio or O_DIRECT) while 16 other processes reads the buffer and check
> > only zero is there.

> So the performance of this test is irrelevant because combining buffered
> reads with direct IO writes was always in "better don't do it" territory.
> Definitely not if you care about perfomance.

Thanks a lot for having a look, Jan!

> > Runtime of this particular setup (i.e. 100 MB file) on Btrfs and XFS on the
> > same system slowed down 9x (6.5: ~1 min 6.6: ~9 min). Ext4 is not affected.
> > (Non default parameter creates much smaller file, thus the change is not that
> > obvious).

> But still it's kind of curious what caused the 9x slow down. So I'd be
> curious to know the result of the bisection :). Thanks for report!

I'm already working on it, report soon.

Kind regards,
Petr

> 								Honza

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-07-22 13:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-19 17:43 [RFC] Slow down of LTP tests aiodio_sparse.c and dio_sparse.c in kernel 6.6 Petr Vorel
2024-07-19 17:43 ` [LTP] " Petr Vorel
2024-07-19 18:36 ` Jens Axboe
2024-07-19 18:36   ` [LTP] " Jens Axboe
2024-07-19 20:13   ` Petr Vorel
2024-07-19 20:13     ` [LTP] " Petr Vorel
2024-07-19 20:21     ` Jens Axboe
2024-07-19 20:21       ` [LTP] " Jens Axboe
2024-07-22  9:00 ` Jan Kara
2024-07-22  9:00   ` [LTP] " Jan Kara
2024-07-22 13:13   ` Petr Vorel [this message]
2024-07-22 13:13     ` Petr Vorel
2024-07-24 13:18   ` Petr Vorel
2024-07-24 13:18     ` [LTP] " Petr Vorel
2024-07-24 16:29     ` Mike Galbraith
2024-07-24 16:29       ` [LTP] " Mike Galbraith via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240722131354.GA858324@pevik \
    --to=pvorel@suse.cz \
    --cc=akumar@suse.de \
    --cc=amir73il@gmail.com \
    --cc=andrea.cervesato@suse.com \
    --cc=axboe@kernel.dk \
    --cc=chrubis@suse.cz \
    --cc=dsterba@suse.com \
    --cc=fdmanana@suse.com \
    --cc=fstests@vger.kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.