All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Wojciech Drewek <wojciech.drewek@intel.com>
Cc: netdev@vger.kernel.org, edumazet@google.com,
	anthony.l.nguyen@intel.com, kuba@kernel.org,
	intel-wired-lan@lists.osuosl.org, pabeni@redhat.com,
	przemyslaw.kitszel@intel.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Implement ethtool reset support
Date: Tue, 6 Aug 2024 15:55:31 +0100	[thread overview]
Message-ID: <20240806145531.GW2636630@kernel.org> (raw)
In-Reply-To: <20240805124651.125761-1-wojciech.drewek@intel.com>

On Mon, Aug 05, 2024 at 02:46:51PM +0200, Wojciech Drewek wrote:
> Enable ethtool reset support. Ethtool reset flags are mapped to the
> E810 reset type:
> PF reset:
>   $ ethtool --reset <ethX> irq dma filter offload
> CORE reset:
>   $ ethtool --reset <ethX> irq-shared dma-shared filter-shared \
>     offload-shared ram-shared
> GLOBAL reset:
>   $ ethtool --reset <ethX> irq-shared dma-shared filter-shared \
>     offload-shared mac-shared phy-shared ram-shared
> 
> Calling the same set of flags as in PF reset case on port representor
> triggers VF reset.
> 
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Reviewed-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> Signed-off-by: Wojciech Drewek <wojciech.drewek@intel.com>
> ---
>  .../device_drivers/ethernet/intel/ice.rst     | 28 +++++++
>  drivers/net/ethernet/intel/ice/ice_ethtool.c  | 77 +++++++++++++++++++
>  2 files changed, 105 insertions(+)
> 
> diff --git a/Documentation/networking/device_drivers/ethernet/intel/ice.rst b/Documentation/networking/device_drivers/ethernet/intel/ice.rst
> index 934752f675ba..c043164bfacc 100644
> --- a/Documentation/networking/device_drivers/ethernet/intel/ice.rst
> +++ b/Documentation/networking/device_drivers/ethernet/intel/ice.rst
> @@ -102,6 +102,34 @@ rx_bytes as "X", then ethtool (hardware statistics) will display rx_bytes as
>  "X+40" (4 bytes CRC x 10 packets).
>  
>  
> +ethtool reset
> +-------------
> +The driver supports 3 types of resets:
> +- PF reset - resets only components associated with the given PF, does not
> +  impact other PFs
> +- CORE reset - whole adapter is affected, reset all PFs
> +- GLOBAL reset - same as CORE but mac and phy components are also reinitialized

Hi Wojciech,

I'm not sure, but I think that Sphinx wants blank likes between these list
items.

Flagged by make: htmldocs SPHINXDIRS=networking

...

WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Wojciech Drewek <wojciech.drewek@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
	anthony.l.nguyen@intel.com, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, przemyslaw.kitszel@intel.com
Subject: Re: [PATCH iwl-next v2] ice: Implement ethtool reset support
Date: Tue, 6 Aug 2024 15:55:31 +0100	[thread overview]
Message-ID: <20240806145531.GW2636630@kernel.org> (raw)
In-Reply-To: <20240805124651.125761-1-wojciech.drewek@intel.com>

On Mon, Aug 05, 2024 at 02:46:51PM +0200, Wojciech Drewek wrote:
> Enable ethtool reset support. Ethtool reset flags are mapped to the
> E810 reset type:
> PF reset:
>   $ ethtool --reset <ethX> irq dma filter offload
> CORE reset:
>   $ ethtool --reset <ethX> irq-shared dma-shared filter-shared \
>     offload-shared ram-shared
> GLOBAL reset:
>   $ ethtool --reset <ethX> irq-shared dma-shared filter-shared \
>     offload-shared mac-shared phy-shared ram-shared
> 
> Calling the same set of flags as in PF reset case on port representor
> triggers VF reset.
> 
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Reviewed-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> Signed-off-by: Wojciech Drewek <wojciech.drewek@intel.com>
> ---
>  .../device_drivers/ethernet/intel/ice.rst     | 28 +++++++
>  drivers/net/ethernet/intel/ice/ice_ethtool.c  | 77 +++++++++++++++++++
>  2 files changed, 105 insertions(+)
> 
> diff --git a/Documentation/networking/device_drivers/ethernet/intel/ice.rst b/Documentation/networking/device_drivers/ethernet/intel/ice.rst
> index 934752f675ba..c043164bfacc 100644
> --- a/Documentation/networking/device_drivers/ethernet/intel/ice.rst
> +++ b/Documentation/networking/device_drivers/ethernet/intel/ice.rst
> @@ -102,6 +102,34 @@ rx_bytes as "X", then ethtool (hardware statistics) will display rx_bytes as
>  "X+40" (4 bytes CRC x 10 packets).
>  
>  
> +ethtool reset
> +-------------
> +The driver supports 3 types of resets:
> +- PF reset - resets only components associated with the given PF, does not
> +  impact other PFs
> +- CORE reset - whole adapter is affected, reset all PFs
> +- GLOBAL reset - same as CORE but mac and phy components are also reinitialized

Hi Wojciech,

I'm not sure, but I think that Sphinx wants blank likes between these list
items.

Flagged by make: htmldocs SPHINXDIRS=networking

...

  parent reply	other threads:[~2024-08-06 14:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-05 12:46 [Intel-wired-lan] [PATCH iwl-next v2] ice: Implement ethtool reset support Wojciech Drewek
2024-08-05 12:46 ` Wojciech Drewek
2024-08-05 13:49 ` [Intel-wired-lan] " Przemek Kitszel
2024-08-05 13:49   ` Przemek Kitszel
2024-08-05 21:01 ` [Intel-wired-lan] " Jakub Kicinski
2024-08-05 21:01   ` Jakub Kicinski
2024-08-06 14:55 ` Simon Horman [this message]
2024-08-06 14:55   ` Simon Horman
2024-08-07 10:42   ` [Intel-wired-lan] " Wojciech Drewek
2024-08-07 10:42     ` Wojciech Drewek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240806145531.GW2636630@kernel.org \
    --to=horms@kernel.org \
    --cc=anthony.l.nguyen@intel.com \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=wojciech.drewek@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.