* [kvm-unit-tests PATCH 0/3] riscv: 32-bit should use phys_addr_t @ 2024-08-07 15:16 ` Andrew Jones 0 siblings, 0 replies; 8+ messages in thread From: Andrew Jones @ 2024-08-07 15:16 UTC (permalink / raw) To: kvm-riscv We don't really expect to test 32-bit RISC-V with physical addresses larger than 32 bits (at least not any time too soon), but the spec says 32-bit RISC-V can have up to 34-bit wide physical addresses and the SBI testing wants to pretend like there's a chance the high words may be nonzero (since SBI calls require high words as parameters). This series ensures we use phys_addr_t where it makes sense to do so. The first couple patches are fixes for issues found while preparing the third. Thanks, drew Andrew Jones (3): riscv: Fix virt_to_phys again riscv: setup: Apply VA_BASE check to rv64 riscv: Support up to 34-bit physical addresses on rv32, sort of lib/riscv/asm/io.h | 4 ++-- lib/riscv/mmu.c | 32 ++++++++++++++++++++------------ lib/riscv/setup.c | 2 +- lib/riscv/smp.c | 7 ++++++- 4 files changed, 29 insertions(+), 16 deletions(-) -- 2.45.2 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [kvm-unit-tests PATCH 0/3] riscv: 32-bit should use phys_addr_t @ 2024-08-07 15:16 ` Andrew Jones 0 siblings, 0 replies; 8+ messages in thread From: Andrew Jones @ 2024-08-07 15:16 UTC (permalink / raw) To: kvm, kvm-riscv; +Cc: atishp, cade.richard, jamestiotio We don't really expect to test 32-bit RISC-V with physical addresses larger than 32 bits (at least not any time too soon), but the spec says 32-bit RISC-V can have up to 34-bit wide physical addresses and the SBI testing wants to pretend like there's a chance the high words may be nonzero (since SBI calls require high words as parameters). This series ensures we use phys_addr_t where it makes sense to do so. The first couple patches are fixes for issues found while preparing the third. Thanks, drew Andrew Jones (3): riscv: Fix virt_to_phys again riscv: setup: Apply VA_BASE check to rv64 riscv: Support up to 34-bit physical addresses on rv32, sort of lib/riscv/asm/io.h | 4 ++-- lib/riscv/mmu.c | 32 ++++++++++++++++++++------------ lib/riscv/setup.c | 2 +- lib/riscv/smp.c | 7 ++++++- 4 files changed, 29 insertions(+), 16 deletions(-) -- 2.45.2 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [kvm-unit-tests PATCH 1/3] riscv: Fix virt_to_phys again 2024-08-07 15:16 ` Andrew Jones @ 2024-08-07 15:16 ` Andrew Jones -1 siblings, 0 replies; 8+ messages in thread From: Andrew Jones @ 2024-08-07 15:16 UTC (permalink / raw) To: kvm-riscv The last fix was a bit hasty since we didn't double check that virt_to_phys() was the right place for the fix, rather than virt_to_pte_phys(), and of course it was the latter... All architectures add on the offset in virt_to_pte_phys() and then simply wrap virt_to_pte_phys() with virt_to_phys(), if they implement virt_to_phys() at all. RISCV shouldn't be different. Fixes: e1dd4ea76894 ("riscv: Fix virt_to_phys") Fixes: 23100d972705 ("riscv: Enable vmalloc") Signed-off-by: Andrew Jones <andrew.jones@linux.dev> --- lib/riscv/mmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/riscv/mmu.c b/lib/riscv/mmu.c index 165a7034bc69..2c9c4f376ac9 100644 --- a/lib/riscv/mmu.c +++ b/lib/riscv/mmu.c @@ -179,7 +179,7 @@ phys_addr_t virt_to_pte_phys(pgd_t *pgtable, void *virt) if (!pte_val(*ptep)) return 0; - return __pa(pteval_to_ptep(pte_val(*ptep))); + return __pa(pteval_to_ptep(pte_val(*ptep))) | offset_in_page(virt); } unsigned long virt_to_phys(volatile void *address) @@ -194,7 +194,7 @@ unsigned long virt_to_phys(volatile void *address) paddr = virt_to_pte_phys(pgtable, (void *)address); assert(sizeof(long) == 8 || !(paddr >> 32)); - return (unsigned long)paddr | offset_in_page(address); + return (unsigned long)paddr; } void *phys_to_virt(unsigned long address) -- 2.45.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [kvm-unit-tests PATCH 1/3] riscv: Fix virt_to_phys again @ 2024-08-07 15:16 ` Andrew Jones 0 siblings, 0 replies; 8+ messages in thread From: Andrew Jones @ 2024-08-07 15:16 UTC (permalink / raw) To: kvm, kvm-riscv; +Cc: atishp, cade.richard, jamestiotio The last fix was a bit hasty since we didn't double check that virt_to_phys() was the right place for the fix, rather than virt_to_pte_phys(), and of course it was the latter... All architectures add on the offset in virt_to_pte_phys() and then simply wrap virt_to_pte_phys() with virt_to_phys(), if they implement virt_to_phys() at all. RISCV shouldn't be different. Fixes: e1dd4ea76894 ("riscv: Fix virt_to_phys") Fixes: 23100d972705 ("riscv: Enable vmalloc") Signed-off-by: Andrew Jones <andrew.jones@linux.dev> --- lib/riscv/mmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/riscv/mmu.c b/lib/riscv/mmu.c index 165a7034bc69..2c9c4f376ac9 100644 --- a/lib/riscv/mmu.c +++ b/lib/riscv/mmu.c @@ -179,7 +179,7 @@ phys_addr_t virt_to_pte_phys(pgd_t *pgtable, void *virt) if (!pte_val(*ptep)) return 0; - return __pa(pteval_to_ptep(pte_val(*ptep))); + return __pa(pteval_to_ptep(pte_val(*ptep))) | offset_in_page(virt); } unsigned long virt_to_phys(volatile void *address) @@ -194,7 +194,7 @@ unsigned long virt_to_phys(volatile void *address) paddr = virt_to_pte_phys(pgtable, (void *)address); assert(sizeof(long) == 8 || !(paddr >> 32)); - return (unsigned long)paddr | offset_in_page(address); + return (unsigned long)paddr; } void *phys_to_virt(unsigned long address) -- 2.45.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [kvm-unit-tests PATCH 2/3] riscv: setup: Apply VA_BASE check to rv64 2024-08-07 15:16 ` Andrew Jones @ 2024-08-07 15:16 ` Andrew Jones -1 siblings, 0 replies; 8+ messages in thread From: Andrew Jones @ 2024-08-07 15:16 UTC (permalink / raw) To: kvm-riscv The VA_BASE check in setup() also applies to rv64, as is clear from the later VA_BASE check in mem_allocator_init(), which ensures freemem_start < freemem_end < VA_BASE. Fixes: 6895ce6dc618 ("riscv: Populate memregions and switch to page allocator") Signed-off-by: Andrew Jones <andrew.jones@linux.dev> --- lib/riscv/setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/riscv/setup.c b/lib/riscv/setup.c index e0b5f6f7daf5..2c7792a5b0bd 100644 --- a/lib/riscv/setup.c +++ b/lib/riscv/setup.c @@ -193,7 +193,7 @@ void setup(const void *fdt, phys_addr_t freemem_start) const char *bootargs; int ret; - assert(sizeof(long) == 8 || freemem_start < VA_BASE); + assert(freemem_start < VA_BASE); freemem = __va(freemem_start); freemem_push_fdt(&freemem, fdt); -- 2.45.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [kvm-unit-tests PATCH 2/3] riscv: setup: Apply VA_BASE check to rv64 @ 2024-08-07 15:16 ` Andrew Jones 0 siblings, 0 replies; 8+ messages in thread From: Andrew Jones @ 2024-08-07 15:16 UTC (permalink / raw) To: kvm, kvm-riscv; +Cc: atishp, cade.richard, jamestiotio The VA_BASE check in setup() also applies to rv64, as is clear from the later VA_BASE check in mem_allocator_init(), which ensures freemem_start < freemem_end < VA_BASE. Fixes: 6895ce6dc618 ("riscv: Populate memregions and switch to page allocator") Signed-off-by: Andrew Jones <andrew.jones@linux.dev> --- lib/riscv/setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/riscv/setup.c b/lib/riscv/setup.c index e0b5f6f7daf5..2c7792a5b0bd 100644 --- a/lib/riscv/setup.c +++ b/lib/riscv/setup.c @@ -193,7 +193,7 @@ void setup(const void *fdt, phys_addr_t freemem_start) const char *bootargs; int ret; - assert(sizeof(long) == 8 || freemem_start < VA_BASE); + assert(freemem_start < VA_BASE); freemem = __va(freemem_start); freemem_push_fdt(&freemem, fdt); -- 2.45.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [kvm-unit-tests PATCH 3/3] riscv: Support up to 34-bit physical addresses on rv32, sort of 2024-08-07 15:16 ` Andrew Jones @ 2024-08-07 15:16 ` Andrew Jones -1 siblings, 0 replies; 8+ messages in thread From: Andrew Jones @ 2024-08-07 15:16 UTC (permalink / raw) To: kvm-riscv Change virt_to_phys() and phys_to_virt() to use phys_addr_t instead of unsigned long. This allows 32-bit builds to use physical addresses over 32 bits wide (the spec allows up to 34 bits). But, to keep things simple, we don't expect physical addresses wider than 32 bits in most the library code (and that's ensured by sprinkling around some asserts). IOW, the support is really only for unit tests which want to test with an additional high memory region. Signed-off-by: Andrew Jones <andrew.jones@linux.dev> --- lib/riscv/asm/io.h | 4 ++-- lib/riscv/mmu.c | 32 ++++++++++++++++++++------------ lib/riscv/smp.c | 7 ++++++- 3 files changed, 28 insertions(+), 15 deletions(-) diff --git a/lib/riscv/asm/io.h b/lib/riscv/asm/io.h index 37a130e533c9..a48a9aa654dd 100644 --- a/lib/riscv/asm/io.h +++ b/lib/riscv/asm/io.h @@ -77,10 +77,10 @@ static inline u64 __raw_readq(const volatile void __iomem *addr) void __iomem *ioremap(phys_addr_t phys_addr, size_t size); #define virt_to_phys virt_to_phys -unsigned long virt_to_phys(volatile void *address); +phys_addr_t virt_to_phys(volatile void *address); #define phys_to_virt phys_to_virt -void *phys_to_virt(unsigned long address); +void *phys_to_virt(phys_addr_t address); #include <asm-generic/io.h> diff --git a/lib/riscv/mmu.c b/lib/riscv/mmu.c index 2c9c4f376ac9..664e0aded404 100644 --- a/lib/riscv/mmu.c +++ b/lib/riscv/mmu.c @@ -18,9 +18,16 @@ static int pte_index(uintptr_t vaddr, int level) return (vaddr >> (PGDIR_BITS * level + PAGE_SHIFT)) & PGDIR_MASK; } +static phys_addr_t pteval_to_phys_addr(pteval_t pteval) +{ + return ((pteval & PTE_PPN) >> PPN_SHIFT) << PAGE_SHIFT; +} + static pte_t *pteval_to_ptep(pteval_t pteval) { - return (pte_t *)(((pteval & PTE_PPN) >> PPN_SHIFT) << PAGE_SHIFT); + phys_addr_t paddr = pteval_to_phys_addr(pteval); + assert(paddr == __pa(paddr)); + return (pte_t *)__pa(paddr); } static pteval_t ptep_to_pteval(pte_t *ptep) @@ -106,7 +113,7 @@ void __mmu_enable(unsigned long satp) void mmu_enable(unsigned long mode, pgd_t *pgtable) { - unsigned long ppn = (unsigned long)pgtable >> PAGE_SHIFT; + unsigned long ppn = __pa(pgtable) >> PAGE_SHIFT; unsigned long satp = mode | ppn; assert(!(ppn & ~SATP_PPN)); @@ -118,6 +125,9 @@ void *setup_mmu(phys_addr_t top, void *opaque) struct mem_region *r; pgd_t *pgtable; + /* The initial page table uses an identity mapping. */ + assert(sizeof(long) == 8 || !(top >> 32)); + if (!__initial_pgtable) __initial_pgtable = alloc_page(); pgtable = __initial_pgtable; @@ -146,7 +156,8 @@ void __iomem *ioremap(phys_addr_t phys_addr, size_t size) pgd_t *pgtable = current_pgtable(); bool flush = true; - assert(sizeof(long) == 8 || !(phys_addr >> 32)); + /* I/O is always identity mapped. */ + assert(sizeof(long) == 8 || !(end >> 32)); if (!pgtable) { if (!__initial_pgtable) @@ -158,7 +169,7 @@ void __iomem *ioremap(phys_addr_t phys_addr, size_t size) mmu_set_range_ptes(pgtable, start, start, end, __pgprot(_PAGE_READ | _PAGE_WRITE), flush); - return (void __iomem *)(unsigned long)phys_addr; + return (void __iomem *)__pa(phys_addr); } phys_addr_t virt_to_pte_phys(pgd_t *pgtable, void *virt) @@ -179,27 +190,24 @@ phys_addr_t virt_to_pte_phys(pgd_t *pgtable, void *virt) if (!pte_val(*ptep)) return 0; - return __pa(pteval_to_ptep(pte_val(*ptep))) | offset_in_page(virt); + return pteval_to_phys_addr(pte_val(*ptep)) | offset_in_page(virt); } -unsigned long virt_to_phys(volatile void *address) +phys_addr_t virt_to_phys(volatile void *address) { unsigned long satp = csr_read(CSR_SATP); pgd_t *pgtable = (pgd_t *)((satp & SATP_PPN) << PAGE_SHIFT); - phys_addr_t paddr; if ((satp >> SATP_MODE_SHIFT) == 0) return __pa(address); - paddr = virt_to_pte_phys(pgtable, (void *)address); - assert(sizeof(long) == 8 || !(paddr >> 32)); - - return (unsigned long)paddr; + return virt_to_pte_phys(pgtable, (void *)address); } -void *phys_to_virt(unsigned long address) +void *phys_to_virt(phys_addr_t address) { /* @address must have an identity mapping for this to work. */ + assert(address == __pa(address)); assert(virt_to_phys(__va(address)) == address); return __va(address); } diff --git a/lib/riscv/smp.c b/lib/riscv/smp.c index 7e4bb5b76903..4d373e0a29a8 100644 --- a/lib/riscv/smp.c +++ b/lib/riscv/smp.c @@ -8,6 +8,7 @@ #include <alloc_page.h> #include <cpumask.h> #include <asm/csr.h> +#include <asm/io.h> #include <asm/mmu.h> #include <asm/page.h> #include <asm/processor.h> @@ -36,6 +37,7 @@ secondary_func_t secondary_cinit(struct secondary_data *data) static void __smp_boot_secondary(int cpu, secondary_func_t func) { struct secondary_data *sp = alloc_pages(1) + SZ_8K - 16; + phys_addr_t sp_phys; struct sbiret ret; sp -= sizeof(struct secondary_data); @@ -43,7 +45,10 @@ static void __smp_boot_secondary(int cpu, secondary_func_t func) sp->stvec = csr_read(CSR_STVEC); sp->func = func; - ret = sbi_hart_start(cpus[cpu].hartid, (unsigned long)&secondary_entry, __pa(sp)); + sp_phys = virt_to_phys(sp); + assert(sp_phys == __pa(sp_phys)); + + ret = sbi_hart_start(cpus[cpu].hartid, (unsigned long)&secondary_entry, __pa(sp_phys)); assert(ret.error == SBI_SUCCESS); } -- 2.45.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [kvm-unit-tests PATCH 3/3] riscv: Support up to 34-bit physical addresses on rv32, sort of @ 2024-08-07 15:16 ` Andrew Jones 0 siblings, 0 replies; 8+ messages in thread From: Andrew Jones @ 2024-08-07 15:16 UTC (permalink / raw) To: kvm, kvm-riscv; +Cc: atishp, cade.richard, jamestiotio Change virt_to_phys() and phys_to_virt() to use phys_addr_t instead of unsigned long. This allows 32-bit builds to use physical addresses over 32 bits wide (the spec allows up to 34 bits). But, to keep things simple, we don't expect physical addresses wider than 32 bits in most the library code (and that's ensured by sprinkling around some asserts). IOW, the support is really only for unit tests which want to test with an additional high memory region. Signed-off-by: Andrew Jones <andrew.jones@linux.dev> --- lib/riscv/asm/io.h | 4 ++-- lib/riscv/mmu.c | 32 ++++++++++++++++++++------------ lib/riscv/smp.c | 7 ++++++- 3 files changed, 28 insertions(+), 15 deletions(-) diff --git a/lib/riscv/asm/io.h b/lib/riscv/asm/io.h index 37a130e533c9..a48a9aa654dd 100644 --- a/lib/riscv/asm/io.h +++ b/lib/riscv/asm/io.h @@ -77,10 +77,10 @@ static inline u64 __raw_readq(const volatile void __iomem *addr) void __iomem *ioremap(phys_addr_t phys_addr, size_t size); #define virt_to_phys virt_to_phys -unsigned long virt_to_phys(volatile void *address); +phys_addr_t virt_to_phys(volatile void *address); #define phys_to_virt phys_to_virt -void *phys_to_virt(unsigned long address); +void *phys_to_virt(phys_addr_t address); #include <asm-generic/io.h> diff --git a/lib/riscv/mmu.c b/lib/riscv/mmu.c index 2c9c4f376ac9..664e0aded404 100644 --- a/lib/riscv/mmu.c +++ b/lib/riscv/mmu.c @@ -18,9 +18,16 @@ static int pte_index(uintptr_t vaddr, int level) return (vaddr >> (PGDIR_BITS * level + PAGE_SHIFT)) & PGDIR_MASK; } +static phys_addr_t pteval_to_phys_addr(pteval_t pteval) +{ + return ((pteval & PTE_PPN) >> PPN_SHIFT) << PAGE_SHIFT; +} + static pte_t *pteval_to_ptep(pteval_t pteval) { - return (pte_t *)(((pteval & PTE_PPN) >> PPN_SHIFT) << PAGE_SHIFT); + phys_addr_t paddr = pteval_to_phys_addr(pteval); + assert(paddr == __pa(paddr)); + return (pte_t *)__pa(paddr); } static pteval_t ptep_to_pteval(pte_t *ptep) @@ -106,7 +113,7 @@ void __mmu_enable(unsigned long satp) void mmu_enable(unsigned long mode, pgd_t *pgtable) { - unsigned long ppn = (unsigned long)pgtable >> PAGE_SHIFT; + unsigned long ppn = __pa(pgtable) >> PAGE_SHIFT; unsigned long satp = mode | ppn; assert(!(ppn & ~SATP_PPN)); @@ -118,6 +125,9 @@ void *setup_mmu(phys_addr_t top, void *opaque) struct mem_region *r; pgd_t *pgtable; + /* The initial page table uses an identity mapping. */ + assert(sizeof(long) == 8 || !(top >> 32)); + if (!__initial_pgtable) __initial_pgtable = alloc_page(); pgtable = __initial_pgtable; @@ -146,7 +156,8 @@ void __iomem *ioremap(phys_addr_t phys_addr, size_t size) pgd_t *pgtable = current_pgtable(); bool flush = true; - assert(sizeof(long) == 8 || !(phys_addr >> 32)); + /* I/O is always identity mapped. */ + assert(sizeof(long) == 8 || !(end >> 32)); if (!pgtable) { if (!__initial_pgtable) @@ -158,7 +169,7 @@ void __iomem *ioremap(phys_addr_t phys_addr, size_t size) mmu_set_range_ptes(pgtable, start, start, end, __pgprot(_PAGE_READ | _PAGE_WRITE), flush); - return (void __iomem *)(unsigned long)phys_addr; + return (void __iomem *)__pa(phys_addr); } phys_addr_t virt_to_pte_phys(pgd_t *pgtable, void *virt) @@ -179,27 +190,24 @@ phys_addr_t virt_to_pte_phys(pgd_t *pgtable, void *virt) if (!pte_val(*ptep)) return 0; - return __pa(pteval_to_ptep(pte_val(*ptep))) | offset_in_page(virt); + return pteval_to_phys_addr(pte_val(*ptep)) | offset_in_page(virt); } -unsigned long virt_to_phys(volatile void *address) +phys_addr_t virt_to_phys(volatile void *address) { unsigned long satp = csr_read(CSR_SATP); pgd_t *pgtable = (pgd_t *)((satp & SATP_PPN) << PAGE_SHIFT); - phys_addr_t paddr; if ((satp >> SATP_MODE_SHIFT) == 0) return __pa(address); - paddr = virt_to_pte_phys(pgtable, (void *)address); - assert(sizeof(long) == 8 || !(paddr >> 32)); - - return (unsigned long)paddr; + return virt_to_pte_phys(pgtable, (void *)address); } -void *phys_to_virt(unsigned long address) +void *phys_to_virt(phys_addr_t address) { /* @address must have an identity mapping for this to work. */ + assert(address == __pa(address)); assert(virt_to_phys(__va(address)) == address); return __va(address); } diff --git a/lib/riscv/smp.c b/lib/riscv/smp.c index 7e4bb5b76903..4d373e0a29a8 100644 --- a/lib/riscv/smp.c +++ b/lib/riscv/smp.c @@ -8,6 +8,7 @@ #include <alloc_page.h> #include <cpumask.h> #include <asm/csr.h> +#include <asm/io.h> #include <asm/mmu.h> #include <asm/page.h> #include <asm/processor.h> @@ -36,6 +37,7 @@ secondary_func_t secondary_cinit(struct secondary_data *data) static void __smp_boot_secondary(int cpu, secondary_func_t func) { struct secondary_data *sp = alloc_pages(1) + SZ_8K - 16; + phys_addr_t sp_phys; struct sbiret ret; sp -= sizeof(struct secondary_data); @@ -43,7 +45,10 @@ static void __smp_boot_secondary(int cpu, secondary_func_t func) sp->stvec = csr_read(CSR_STVEC); sp->func = func; - ret = sbi_hart_start(cpus[cpu].hartid, (unsigned long)&secondary_entry, __pa(sp)); + sp_phys = virt_to_phys(sp); + assert(sp_phys == __pa(sp_phys)); + + ret = sbi_hart_start(cpus[cpu].hartid, (unsigned long)&secondary_entry, __pa(sp_phys)); assert(ret.error == SBI_SUCCESS); } -- 2.45.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-08-07 15:16 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-08-07 15:16 [kvm-unit-tests PATCH 0/3] riscv: 32-bit should use phys_addr_t Andrew Jones 2024-08-07 15:16 ` Andrew Jones 2024-08-07 15:16 ` [kvm-unit-tests PATCH 1/3] riscv: Fix virt_to_phys again Andrew Jones 2024-08-07 15:16 ` Andrew Jones 2024-08-07 15:16 ` [kvm-unit-tests PATCH 2/3] riscv: setup: Apply VA_BASE check to rv64 Andrew Jones 2024-08-07 15:16 ` Andrew Jones 2024-08-07 15:16 ` [kvm-unit-tests PATCH 3/3] riscv: Support up to 34-bit physical addresses on rv32, sort of Andrew Jones 2024-08-07 15:16 ` Andrew Jones
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.