All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Conor Dooley <conor@kernel.org>
Cc: Keguang Zhang <keguang.zhang@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v8 1/2] dt-bindings: mtd: Add Loongson-1 NAND Controller
Date: Wed, 14 Aug 2024 09:12:31 +0200	[thread overview]
Message-ID: <20240814091231.1d9525be@xps-13> (raw)
In-Reply-To: <20240809-smuggler-patrol-067003f0ba9b@spud>

Hi,

> > > When I first read "nfc" here I thought it was a copy-paste mistake, as
> > > "nfc" is a technology of it's own. I think it would make sense to rename
> > > to "loongson,ls1b-nand-controller" etc to remove that sort of confusion.
> > > These devices might not implement NFC, but what's to say that a future
> > > device will not?

I believe the nfc (also, nc) abbreviation pre-dates the NFC spec. But I
agree, it may be misleading. Even though I don't foresee any NAND
controller with NFC coming, it's probably bad for newcomers/people who
are not already deeply into the mtd details to use these confusing
letters, especially in a binding.

So, Ack.

> > Sorry for the confusion.
> > The string "loongson,ls1b-nand-controller" might be too long.  
> 
> It "might"? Why do you think it is too long?

Yeah, why would it be too long? Let's call a cat a cat. This is a
compatible for a NAND controller. So I expect the string to mention
it's a NAND controller because it's clearer. For quite some time there
has been a confusion between the NAND controller and the NAND
flash/chip, but these are two different hardware components.

> > May I rename it to "loongson,ls1b-nand"?  

For the above reason, no :)

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Conor Dooley <conor@kernel.org>
Cc: Keguang Zhang <keguang.zhang@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v8 1/2] dt-bindings: mtd: Add Loongson-1 NAND Controller
Date: Wed, 14 Aug 2024 09:12:31 +0200	[thread overview]
Message-ID: <20240814091231.1d9525be@xps-13> (raw)
In-Reply-To: <20240809-smuggler-patrol-067003f0ba9b@spud>

Hi,

> > > When I first read "nfc" here I thought it was a copy-paste mistake, as
> > > "nfc" is a technology of it's own. I think it would make sense to rename
> > > to "loongson,ls1b-nand-controller" etc to remove that sort of confusion.
> > > These devices might not implement NFC, but what's to say that a future
> > > device will not?

I believe the nfc (also, nc) abbreviation pre-dates the NFC spec. But I
agree, it may be misleading. Even though I don't foresee any NAND
controller with NFC coming, it's probably bad for newcomers/people who
are not already deeply into the mtd details to use these confusing
letters, especially in a binding.

So, Ack.

> > Sorry for the confusion.
> > The string "loongson,ls1b-nand-controller" might be too long.  
> 
> It "might"? Why do you think it is too long?

Yeah, why would it be too long? Let's call a cat a cat. This is a
compatible for a NAND controller. So I expect the string to mention
it's a NAND controller because it's clearer. For quite some time there
has been a confusion between the NAND controller and the NAND
flash/chip, but these are two different hardware components.

> > May I rename it to "loongson,ls1b-nand"?  

For the above reason, no :)

Thanks,
Miquèl

  reply	other threads:[~2024-08-14  7:12 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-08 11:22 [PATCH v8 0/2] Add support for Loongson-1 NAND Keguang Zhang
2024-08-08 11:22 ` Keguang Zhang via B4 Relay
2024-08-08 11:22 ` Keguang Zhang via B4 Relay
2024-08-08 11:22 ` [PATCH v8 1/2] dt-bindings: mtd: Add Loongson-1 NAND Controller Keguang Zhang
2024-08-08 11:22   ` Keguang Zhang via B4 Relay
2024-08-08 11:22   ` Keguang Zhang via B4 Relay
2024-08-08 15:37   ` Conor Dooley
2024-08-08 15:37     ` Conor Dooley
2024-08-09  6:47     ` Keguang Zhang
2024-08-09  6:47       ` Keguang Zhang
2024-08-09 14:49       ` Conor Dooley
2024-08-09 14:49         ` Conor Dooley
2024-08-14  7:12         ` Miquel Raynal [this message]
2024-08-14  7:12           ` Miquel Raynal
2024-08-14 14:23           ` Conor Dooley
2024-08-14 14:23             ` Conor Dooley
2024-08-14 14:48             ` Miquel Raynal
2024-08-14 14:48               ` Miquel Raynal
2024-08-19  2:51           ` Keguang Zhang
2024-08-19  2:51             ` Keguang Zhang
2024-08-08 11:22 ` [PATCH v8 2/2] mtd: rawnand: Add Loongson-1 NAND Controller driver Keguang Zhang
2024-08-08 11:22   ` Keguang Zhang via B4 Relay
2024-08-08 11:22   ` Keguang Zhang via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240814091231.1d9525be@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=keguang.zhang@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.