From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v1 0/5] usb drivers use devm_clk_get_enabled() helpers
Date: Thu, 22 Aug 2024 12:27:26 +0800 [thread overview]
Message-ID: <2024082210-stadium-sly-cf06@gregkh> (raw)
In-Reply-To: <20240822040734.29412-1-liulei.rjpt@vivo.com>
On Thu, Aug 22, 2024 at 12:07:25PM +0800, Lei Liu wrote:
> The devm_clk_get_enabled() helpers:
> - call devm_clk_get()
> - call clk_prepare_enable() and register what is needed in order to
> call clk_disable_unprepare() when needed, as a managed resource.
>
> This simplifies the code and avoids calls to clk_disable_unprepare().
>
> ---
> The files ux500.c, mpfs.c, and pxa27x_udc.c have incorrect usage of
> certain interfaces due to the lack of synchronization during the
> commit updates. These issues have been corrected in the v1 version.
>
> version 1 changes
> 1.ux500: Incorrect usage of clk_prepare_enable() should be corrected to
> devm_clk_get_enabled().
> 2.mpfs: Incorrect usage of devm_clk_get_enable() should be corrected to
> devm_clk_get_enabled().
> 3.pxa27x_udc: Incorrect usage of clk_prepare_enable() should be
> corrected to devm_clk_get_enabled().
Patch versions start at 1, this should be 2, right?
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Lei Liu <liulei.rjpt@vivo.com>
Cc: "Neal Liu" <neal_liu@aspeedtech.com>,
"Joel Stanley" <joel@jms.id.au>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Daniel Mack" <daniel@zonque.org>,
"Haojian Zhuang" <haojian.zhuang@gmail.com>,
"Robert Jarzmik" <robert.jarzmik@free.fr>,
"Conor Dooley" <conor.dooley@microchip.com>,
"Daire McNamara" <daire.mcnamara@microchip.com>,
"Bin Liu" <b-liu@ti.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-aspeed@lists.ozlabs.org, linux-usb@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
opensource.kernel@vivo.com
Subject: Re: [PATCH v1 0/5] usb drivers use devm_clk_get_enabled() helpers
Date: Thu, 22 Aug 2024 12:27:26 +0800 [thread overview]
Message-ID: <2024082210-stadium-sly-cf06@gregkh> (raw)
In-Reply-To: <20240822040734.29412-1-liulei.rjpt@vivo.com>
On Thu, Aug 22, 2024 at 12:07:25PM +0800, Lei Liu wrote:
> The devm_clk_get_enabled() helpers:
> - call devm_clk_get()
> - call clk_prepare_enable() and register what is needed in order to
> call clk_disable_unprepare() when needed, as a managed resource.
>
> This simplifies the code and avoids calls to clk_disable_unprepare().
>
> ---
> The files ux500.c, mpfs.c, and pxa27x_udc.c have incorrect usage of
> certain interfaces due to the lack of synchronization during the
> commit updates. These issues have been corrected in the v1 version.
>
> version 1 changes
> 1.ux500: Incorrect usage of clk_prepare_enable() should be corrected to
> devm_clk_get_enabled().
> 2.mpfs: Incorrect usage of devm_clk_get_enable() should be corrected to
> devm_clk_get_enabled().
> 3.pxa27x_udc: Incorrect usage of clk_prepare_enable() should be
> corrected to devm_clk_get_enabled().
Patch versions start at 1, this should be 2, right?
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Lei Liu <liulei.rjpt@vivo.com>
Cc: "Neal Liu" <neal_liu@aspeedtech.com>,
"Joel Stanley" <joel@jms.id.au>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Daniel Mack" <daniel@zonque.org>,
"Haojian Zhuang" <haojian.zhuang@gmail.com>,
"Robert Jarzmik" <robert.jarzmik@free.fr>,
"Conor Dooley" <conor.dooley@microchip.com>,
"Daire McNamara" <daire.mcnamara@microchip.com>,
"Bin Liu" <b-liu@ti.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-aspeed@lists.ozlabs.org, linux-usb@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
opensource.kernel@vivo.com
Subject: Re: [PATCH v1 0/5] usb drivers use devm_clk_get_enabled() helpers
Date: Thu, 22 Aug 2024 12:27:26 +0800 [thread overview]
Message-ID: <2024082210-stadium-sly-cf06@gregkh> (raw)
In-Reply-To: <20240822040734.29412-1-liulei.rjpt@vivo.com>
On Thu, Aug 22, 2024 at 12:07:25PM +0800, Lei Liu wrote:
> The devm_clk_get_enabled() helpers:
> - call devm_clk_get()
> - call clk_prepare_enable() and register what is needed in order to
> call clk_disable_unprepare() when needed, as a managed resource.
>
> This simplifies the code and avoids calls to clk_disable_unprepare().
>
> ---
> The files ux500.c, mpfs.c, and pxa27x_udc.c have incorrect usage of
> certain interfaces due to the lack of synchronization during the
> commit updates. These issues have been corrected in the v1 version.
>
> version 1 changes
> 1.ux500: Incorrect usage of clk_prepare_enable() should be corrected to
> devm_clk_get_enabled().
> 2.mpfs: Incorrect usage of devm_clk_get_enable() should be corrected to
> devm_clk_get_enabled().
> 3.pxa27x_udc: Incorrect usage of clk_prepare_enable() should be
> corrected to devm_clk_get_enabled().
Patch versions start at 1, this should be 2, right?
next prev parent reply other threads:[~2024-08-22 4:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 4:07 [PATCH v1 0/5] usb drivers use devm_clk_get_enabled() helpers Lei Liu
2024-08-22 4:07 ` Lei Liu
2024-08-22 4:07 ` Lei Liu
2024-08-22 4:07 ` [PATCH v1 1/5] usb: aspeed_udc: Use " Lei Liu
2024-08-22 4:07 ` Lei Liu
2024-08-22 4:07 ` Lei Liu
2024-08-22 4:07 ` [PATCH v1 2/5] usb: pxa27x_udc: " Lei Liu
2024-08-22 4:07 ` Lei Liu
2024-08-22 4:07 ` Lei Liu
2024-08-22 4:07 ` [PATCH v1 3/5] usb: r8a66597-udc: " Lei Liu
2024-08-22 4:07 ` Lei Liu
2024-08-22 4:07 ` Lei Liu
2024-08-22 4:07 ` [PATCH v1 4/5] usb: mpfs: " Lei Liu
2024-08-22 4:07 ` Lei Liu
2024-08-22 4:07 ` Lei Liu
2024-08-22 4:07 ` [PATCH v1 5/5] usb: ux500: " Lei Liu
2024-08-22 4:07 ` Lei Liu
2024-08-22 4:07 ` Lei Liu
2024-08-22 4:27 ` Greg Kroah-Hartman [this message]
2024-08-22 4:27 ` [PATCH v1 0/5] usb drivers use " Greg Kroah-Hartman
2024-08-22 4:27 ` Greg Kroah-Hartman
2024-08-22 4:46 ` Lei Liu
2024-08-22 4:46 ` Lei Liu
2024-08-22 4:46 ` Lei Liu
2024-08-22 5:14 ` Greg Kroah-Hartman
2024-08-22 5:14 ` Greg Kroah-Hartman
2024-08-22 5:14 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024082210-stadium-sly-cf06@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.