All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] docs: Fix incorrect and potentially confusing language and minor formatting
@ 2024-09-06  1:37 Glenn Washburn
  2024-09-06  2:12 ` Andrew Hamilton
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Glenn Washburn @ 2024-09-06  1:37 UTC (permalink / raw)
  To: The development of GNU GRUB, Daniel Kiper; +Cc: Andrew Hamilton, Glenn Washburn

Signed-off-by: Glenn Washburn <development@efficientek.com>
---
 docs/grub.texi | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/docs/grub.texi b/docs/grub.texi
index 63e796a3a738..e6e5efa05e6c 100644
--- a/docs/grub.texi
+++ b/docs/grub.texi
@@ -4538,11 +4538,12 @@ files.
 
 @node emunet_module
 @section emunet
-This module provides support for an emulated network card in GRUB.
+This module provides support for networking in GRUB on the emu platform.
 
 @node emupci_module
 @section emupci
-This module provides support for an emulated PCI bus in GRUB.
+This module provides support for accessing the PCI bus in GRUB on the emu
+platform.
 
 @node erofs_module
 @section erofs
@@ -4784,8 +4785,8 @@ image support, and icon support.
 
 @node gfxterm_module
 @section gfxterm
-This module provides support for displaying a graphical terminal interface from
-GRUB.
+This module provides support for displaying a terminal and menu interface from
+GRUB using graphics mode.
 
 @node gfxterm_background_module
 @section gfxterm_background
@@ -5105,8 +5106,7 @@ at the time of writing.
 @node memdisk_module
 @section memdisk
 This module provides support for a memdisk device. A memdisk is a memory mapped
-emulated disk likely only possible in legacy environment such as with a legacy
-BIOS operating in 16-bit mode.
+emulated disk.
 
 @node memrw_module
 @section memrw
@@ -5475,8 +5475,7 @@ like interface to some GRUB internal data.
 
 @node progress_module
 @section progress
-This module provides support for showing file loading progress to the
-terminal.
+This module provides support for showing file loading progress to the terminal.
 
 @node pxe_module
 @section pxe
-- 
2.34.1


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] docs: Fix incorrect and potentially confusing language and minor formatting
  2024-09-06  1:37 [PATCH] docs: Fix incorrect and potentially confusing language and minor formatting Glenn Washburn
@ 2024-09-06  2:12 ` Andrew Hamilton
  2024-09-06  2:56 ` Vladimir 'phcoder' Serbinenko
  2024-11-08 19:07 ` Glenn Washburn
  2 siblings, 0 replies; 5+ messages in thread
From: Andrew Hamilton @ 2024-09-06  2:12 UTC (permalink / raw)
  To: Glenn Washburn; +Cc: The development of GNU GRUB, Daniel Kiper


[-- Attachment #1.1: Type: text/plain, Size: 2102 bytes --]

Thanks for fixing these, I’m not an official maintainer but looks good to
me!

Sincerely,
Andrew Hamilton

On Thu, Sep 5, 2024 at 8:37 PM Glenn Washburn <development@efficientek.com>
wrote:

> Signed-off-by: Glenn Washburn <development@efficientek.com>
> ---
>  docs/grub.texi | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/docs/grub.texi b/docs/grub.texi
> index 63e796a3a738..e6e5efa05e6c 100644
> --- a/docs/grub.texi
> +++ b/docs/grub.texi
> @@ -4538,11 +4538,12 @@ files.
>
>  @node emunet_module
>  @section emunet
> -This module provides support for an emulated network card in GRUB.
> +This module provides support for networking in GRUB on the emu platform.
>
>  @node emupci_module
>  @section emupci
> -This module provides support for an emulated PCI bus in GRUB.
> +This module provides support for accessing the PCI bus in GRUB on the emu
> +platform.
>
>  @node erofs_module
>  @section erofs
> @@ -4784,8 +4785,8 @@ image support, and icon support.
>
>  @node gfxterm_module
>  @section gfxterm
> -This module provides support for displaying a graphical terminal
> interface from
> -GRUB.
> +This module provides support for displaying a terminal and menu interface
> from
> +GRUB using graphics mode.
>
>  @node gfxterm_background_module
>  @section gfxterm_background
> @@ -5105,8 +5106,7 @@ at the time of writing.
>  @node memdisk_module
>  @section memdisk
>  This module provides support for a memdisk device. A memdisk is a memory
> mapped
> -emulated disk likely only possible in legacy environment such as with a
> legacy
> -BIOS operating in 16-bit mode.
> +emulated disk.
>
>  @node memrw_module
>  @section memrw
> @@ -5475,8 +5475,7 @@ like interface to some GRUB internal data.
>
>  @node progress_module
>  @section progress
> -This module provides support for showing file loading progress to the
> -terminal.
> +This module provides support for showing file loading progress to the
> terminal.
>
>  @node pxe_module
>  @section pxe
> --
> 2.34.1
>
>

[-- Attachment #1.2: Type: text/html, Size: 2702 bytes --]

[-- Attachment #2: Type: text/plain, Size: 141 bytes --]

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] docs: Fix incorrect and potentially confusing language and minor formatting
  2024-09-06  1:37 [PATCH] docs: Fix incorrect and potentially confusing language and minor formatting Glenn Washburn
  2024-09-06  2:12 ` Andrew Hamilton
@ 2024-09-06  2:56 ` Vladimir 'phcoder' Serbinenko
  2024-11-08 19:07 ` Glenn Washburn
  2 siblings, 0 replies; 5+ messages in thread
From: Vladimir 'phcoder' Serbinenko @ 2024-09-06  2:56 UTC (permalink / raw)
  To: The development of GNU GRUB


[-- Attachment #1.1: Type: text/plain, Size: 2177 bytes --]

Reviewed-by: phcoder@gmail.com

Le ven. 6 sept. 2024, 04:38, Glenn Washburn <development@efficientek.com> a
écrit :

> Signed-off-by: Glenn Washburn <development@efficientek.com>
> ---
>  docs/grub.texi | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/docs/grub.texi b/docs/grub.texi
> index 63e796a3a738..e6e5efa05e6c 100644
> --- a/docs/grub.texi
> +++ b/docs/grub.texi
> @@ -4538,11 +4538,12 @@ files.
>
>  @node emunet_module
>  @section emunet
> -This module provides support for an emulated network card in GRUB.
> +This module provides support for networking in GRUB on the emu platform.
>
>  @node emupci_module
>  @section emupci
> -This module provides support for an emulated PCI bus in GRUB.
> +This module provides support for accessing the PCI bus in GRUB on the emu
> +platform.
>
>  @node erofs_module
>  @section erofs
> @@ -4784,8 +4785,8 @@ image support, and icon support.
>
>  @node gfxterm_module
>  @section gfxterm
> -This module provides support for displaying a graphical terminal
> interface from
> -GRUB.
> +This module provides support for displaying a terminal and menu interface
> from
> +GRUB using graphics mode.
>
>  @node gfxterm_background_module
>  @section gfxterm_background
> @@ -5105,8 +5106,7 @@ at the time of writing.
>  @node memdisk_module
>  @section memdisk
>  This module provides support for a memdisk device. A memdisk is a memory
> mapped
> -emulated disk likely only possible in legacy environment such as with a
> legacy
> -BIOS operating in 16-bit mode.
> +emulated disk.
>
>  @node memrw_module
>  @section memrw
> @@ -5475,8 +5475,7 @@ like interface to some GRUB internal data.
>
>  @node progress_module
>  @section progress
> -This module provides support for showing file loading progress to the
> -terminal.
> +This module provides support for showing file loading progress to the
> terminal.
>
>  @node pxe_module
>  @section pxe
> --
> 2.34.1
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>

[-- Attachment #1.2: Type: text/html, Size: 2891 bytes --]

[-- Attachment #2: Type: text/plain, Size: 141 bytes --]

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] docs: Fix incorrect and potentially confusing language and minor formatting
  2024-09-06  1:37 [PATCH] docs: Fix incorrect and potentially confusing language and minor formatting Glenn Washburn
  2024-09-06  2:12 ` Andrew Hamilton
  2024-09-06  2:56 ` Vladimir 'phcoder' Serbinenko
@ 2024-11-08 19:07 ` Glenn Washburn
  2024-11-12 16:00   ` Daniel Kiper
  2 siblings, 1 reply; 5+ messages in thread
From: Glenn Washburn @ 2024-11-08 19:07 UTC (permalink / raw)
  To: The development of GNU GRUB, Daniel Kiper; +Cc: Andrew Hamilton, Daniel Kiper

Ping. Wondering what might be holding this up from being merged?

Glenn

On Thu,  5 Sep 2024 20:37:11 -0500
Glenn Washburn <development@efficientek.com> wrote:

> Signed-off-by: Glenn Washburn <development@efficientek.com>
> ---
>  docs/grub.texi | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/docs/grub.texi b/docs/grub.texi
> index 63e796a3a738..e6e5efa05e6c 100644
> --- a/docs/grub.texi
> +++ b/docs/grub.texi
> @@ -4538,11 +4538,12 @@ files.
>  
>  @node emunet_module
>  @section emunet
> -This module provides support for an emulated network card in GRUB.
> +This module provides support for networking in GRUB on the emu platform.
>  
>  @node emupci_module
>  @section emupci
> -This module provides support for an emulated PCI bus in GRUB.
> +This module provides support for accessing the PCI bus in GRUB on the emu
> +platform.
>  
>  @node erofs_module
>  @section erofs
> @@ -4784,8 +4785,8 @@ image support, and icon support.
>  
>  @node gfxterm_module
>  @section gfxterm
> -This module provides support for displaying a graphical terminal interface from
> -GRUB.
> +This module provides support for displaying a terminal and menu interface from
> +GRUB using graphics mode.
>  
>  @node gfxterm_background_module
>  @section gfxterm_background
> @@ -5105,8 +5106,7 @@ at the time of writing.
>  @node memdisk_module
>  @section memdisk
>  This module provides support for a memdisk device. A memdisk is a memory mapped
> -emulated disk likely only possible in legacy environment such as with a legacy
> -BIOS operating in 16-bit mode.
> +emulated disk.
>  
>  @node memrw_module
>  @section memrw
> @@ -5475,8 +5475,7 @@ like interface to some GRUB internal data.
>  
>  @node progress_module
>  @section progress
> -This module provides support for showing file loading progress to the
> -terminal.
> +This module provides support for showing file loading progress to the terminal.
>  
>  @node pxe_module
>  @section pxe

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] docs: Fix incorrect and potentially confusing language and minor formatting
  2024-11-08 19:07 ` Glenn Washburn
@ 2024-11-12 16:00   ` Daniel Kiper
  0 siblings, 0 replies; 5+ messages in thread
From: Daniel Kiper @ 2024-11-12 16:00 UTC (permalink / raw)
  To: Glenn Washburn; +Cc: The development of GNU GRUB, Andrew Hamilton

On Fri, Nov 08, 2024 at 01:07:45PM -0600, Glenn Washburn wrote:
> Ping. Wondering what might be holding this up from being merged?

Well, fell of my radar. Sorry about that. Added to the queue.

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-11-12 16:02 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-06  1:37 [PATCH] docs: Fix incorrect and potentially confusing language and minor formatting Glenn Washburn
2024-09-06  2:12 ` Andrew Hamilton
2024-09-06  2:56 ` Vladimir 'phcoder' Serbinenko
2024-11-08 19:07 ` Glenn Washburn
2024-11-12 16:00   ` Daniel Kiper

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.