* Re: [PATCH net] selftests: net: enable bind tests
2024-09-04 6:12 [PATCH net] selftests: net: enable bind tests Jamie Bainbridge
@ 2024-09-04 13:06 ` Eric Dumazet
2024-09-04 17:45 ` Kuniyuki Iwashima
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Eric Dumazet @ 2024-09-04 13:06 UTC (permalink / raw)
To: Jamie Bainbridge
Cc: David S. Miller, Jakub Kicinski, Paolo Abeni, Shuah Khan,
Kuniyuki Iwashima, Joanne Koong, netdev, linux-kselftest,
linux-kernel
On Wed, Sep 4, 2024 at 8:12 AM Jamie Bainbridge
<jamie.bainbridge@gmail.com> wrote:
>
> bind_wildcard is compiled but not run, bind_timewait is not compiled.
>
> These two tests complete in a very short time, use the test harness
> properly, and seem reasonable to enable.
>
> The author of the tests confirmed via email that these were
> intended to be run.
>
> Enable these two tests.
>
> Fixes: 13715acf8ab5 ("selftest: Add test for bind() conflicts.")
> Fixes: 2c042e8e54ef ("tcp: Add selftest for bind() and TIME_WAIT.")
> Signed-off-by: Jamie Bainbridge <jamie.bainbridge@gmail.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net] selftests: net: enable bind tests
2024-09-04 6:12 [PATCH net] selftests: net: enable bind tests Jamie Bainbridge
2024-09-04 13:06 ` Eric Dumazet
@ 2024-09-04 17:45 ` Kuniyuki Iwashima
2024-09-05 22:10 ` patchwork-bot+netdevbpf
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Kuniyuki Iwashima @ 2024-09-04 17:45 UTC (permalink / raw)
To: jamie.bainbridge
Cc: davem, edumazet, joannelkoong, kuba, kuniyu, linux-kernel,
linux-kselftest, netdev, pabeni, shuah
From: Jamie Bainbridge <jamie.bainbridge@gmail.com>
Date: Wed, 4 Sep 2024 16:12:26 +1000
> bind_wildcard is compiled but not run, bind_timewait is not compiled.
>
> These two tests complete in a very short time, use the test harness
> properly, and seem reasonable to enable.
>
> The author of the tests confirmed via email that these were
> intended to be run.
>
> Enable these two tests.
>
> Fixes: 13715acf8ab5 ("selftest: Add test for bind() conflicts.")
> Fixes: 2c042e8e54ef ("tcp: Add selftest for bind() and TIME_WAIT.")
> Signed-off-by: Jamie Bainbridge <jamie.bainbridge@gmail.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Thanks!
> ---
> tools/testing/selftests/net/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
> index 8eaffd7a641c5d6bb5c63e3015fdd9f32c114550..9d5aa817411b653ac130a1a581d933180a597ce5 100644
> --- a/tools/testing/selftests/net/Makefile
> +++ b/tools/testing/selftests/net/Makefile
> @@ -85,7 +85,8 @@ TEST_GEN_PROGS += so_incoming_cpu
> TEST_PROGS += sctp_vrf.sh
> TEST_GEN_FILES += sctp_hello
> TEST_GEN_FILES += ip_local_port_range
> -TEST_GEN_FILES += bind_wildcard
> +TEST_GEN_PROGS += bind_wildcard
> +TEST_GEN_PROGS += bind_timewait
> TEST_PROGS += test_vxlan_mdb.sh
> TEST_PROGS += test_bridge_neigh_suppress.sh
> TEST_PROGS += test_vxlan_nolocalbypass.sh
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net] selftests: net: enable bind tests
2024-09-04 6:12 [PATCH net] selftests: net: enable bind tests Jamie Bainbridge
2024-09-04 13:06 ` Eric Dumazet
2024-09-04 17:45 ` Kuniyuki Iwashima
@ 2024-09-05 22:10 ` patchwork-bot+netdevbpf
2024-09-06 13:53 ` Matthieu Baerts (NGI0)
2024-09-06 13:58 ` [PATCH net v2] " Matthieu Baerts (NGI0)
4 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-09-05 22:10 UTC (permalink / raw)
To: Jamie Bainbridge
Cc: davem, edumazet, kuba, pabeni, shuah, kuniyu, joannelkoong,
netdev, linux-kselftest, linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 4 Sep 2024 16:12:26 +1000 you wrote:
> bind_wildcard is compiled but not run, bind_timewait is not compiled.
>
> These two tests complete in a very short time, use the test harness
> properly, and seem reasonable to enable.
>
> The author of the tests confirmed via email that these were
> intended to be run.
>
> [...]
Here is the summary with links:
- [net] selftests: net: enable bind tests
https://git.kernel.org/netdev/net/c/e4af74a53b7a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH net] selftests: net: enable bind tests
2024-09-04 6:12 [PATCH net] selftests: net: enable bind tests Jamie Bainbridge
` (2 preceding siblings ...)
2024-09-05 22:10 ` patchwork-bot+netdevbpf
@ 2024-09-06 13:53 ` Matthieu Baerts (NGI0)
2024-09-06 13:58 ` [PATCH net v2] " Matthieu Baerts (NGI0)
4 siblings, 0 replies; 6+ messages in thread
From: Matthieu Baerts (NGI0) @ 2024-09-06 13:53 UTC (permalink / raw)
To: patches
From: Jamie Bainbridge <jamie.bainbridge@gmail.com>
========= Please ignore, this is a test for b4 shazam =========
Link: https://lore.kernel.org/r/5a009b26cf5fb1ad1512d89c61b37e2fac702323.1725430322.git.jamie.bainbridge@gmail.com
Signed-off-by: Jamie Bainbridge <jamie.bainbridge@gmail.com>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 7b60eb103c5d..e1fa1b98a034 100644
--- a/Makefile
+++ b/Makefile
@@ -3,7 +3,7 @@ VERSION = 6
PATCHLEVEL = 11
SUBLEVEL = 0
EXTRAVERSION = -rc5
-NAME = Baby Opossum Posse
+NAME = B4 rocks
# *DOCUMENTATION*
# To see a list of typical targets execute "make help"
--
2.45.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH net v2] selftests: net: enable bind tests
2024-09-04 6:12 [PATCH net] selftests: net: enable bind tests Jamie Bainbridge
` (3 preceding siblings ...)
2024-09-06 13:53 ` Matthieu Baerts (NGI0)
@ 2024-09-06 13:58 ` Matthieu Baerts (NGI0)
4 siblings, 0 replies; 6+ messages in thread
From: Matthieu Baerts (NGI0) @ 2024-09-06 13:58 UTC (permalink / raw)
To: patches
From: Jamie Bainbridge <jamie.bainbridge@gmail.com>
========= Please ignore, this is a test for b4 shazam =========
Link: https://lore.kernel.org/r/5a009b26cf5fb1ad1512d89c61b37e2fac702323.1725430322.git.jamie.bainbridge@gmail.com
Signed-off-by: Jamie Bainbridge <jamie.bainbridge@gmail.com>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 7b60eb103c5d..e1fa1b98a034 100644
--- a/Makefile
+++ b/Makefile
@@ -3,7 +3,7 @@ VERSION = 6
PATCHLEVEL = 11
SUBLEVEL = 0
EXTRAVERSION = -rc5
-NAME = Baby Opossum Posse
+NAME = B4 rocks
# *DOCUMENTATION*
# To see a list of typical targets execute "make help"
--
2.45.2
^ permalink raw reply related [flat|nested] 6+ messages in thread