All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Md Sadre Alam <quic_mdalam@quicinc.com>
Cc: <broonie@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>, <andersson@kernel.org>,
	<konradybcio@kernel.org>, <richard@nod.at>, <vigneshr@ti.com>,
	<manivannan.sadhasivam@linaro.org>, <esben@geanix.com>,
	<linux-arm-msm@vger.kernel.org>, <linux-spi@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-mtd@lists.infradead.org>
Subject: Re: [PATCH v8 0/8] Add QPIC SPI NAND driver
Date: Tue, 10 Sep 2024 09:41:20 +0200	[thread overview]
Message-ID: <20240910094120.19348fea@xps-13> (raw)
In-Reply-To: <bb1397c3-2327-e211-f7eb-cac4b126424e@quicinc.com>

Hi,

> >>>    >>       I have addressed your comments to v6 and further posted till v8.  
> >>       Could you please let me know if this is fine.
> >>       and how to get this merged ?  
> > 
> > There are still kernel test robot reports, so this means there are
> > issues in your code that I don't need to point out explicitly, but I am
> > actively waiting for them to be fixed.  
> 
> I have fixed most of the sparse warnings after converting __le32 to u32.
> However am not able to address the following sparse warnings
> 
> 	drivers/mtd/nand/raw/qcom_nandc.c:1401:29: sparse: warning: cast to restricted __le32
> 	drivers/mtd/nand/raw/qcom_nandc.c:1587:30: sparse: warning: cast to restricted __le32
> 	drivers/mtd/nand/raw/qcom_nandc.c:1588:31: sparse: warning: cast to restricted __le32
> 	drivers/mtd/nand/raw/qcom_nandc.c:1589:34: sparse: warning: cast to restricted __le32
> 	drivers/mtd/nand/raw/qcom_nandc.c:2479:47: sparse:    got restricted __le32 [usertype]
> 	drivers/mtd/nand/raw/qcom_nandc.c:2480:47: sparse:    got restricted __le32 [usertype]
> 	drivers/mtd/nand/raw/qcom_nandc.c:2616:25: sparse: warning: cast to restricted __le32
> 	drivers/mtd/nand/raw/qcom_nandc.c:2672:32: sparse: warning: cast to restricted __le32

The rule is: you cannot add new warnings.

For existing warnings in the driver, I'd anyway advise to solve them.
Without the actual code I cannot help.

Thanks,
Miquèl

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Md Sadre Alam <quic_mdalam@quicinc.com>
Cc: <broonie@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>, <andersson@kernel.org>,
	<konradybcio@kernel.org>, <richard@nod.at>, <vigneshr@ti.com>,
	<manivannan.sadhasivam@linaro.org>, <esben@geanix.com>,
	<linux-arm-msm@vger.kernel.org>, <linux-spi@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-mtd@lists.infradead.org>
Subject: Re: [PATCH v8 0/8] Add QPIC SPI NAND driver
Date: Tue, 10 Sep 2024 09:41:20 +0200	[thread overview]
Message-ID: <20240910094120.19348fea@xps-13> (raw)
In-Reply-To: <bb1397c3-2327-e211-f7eb-cac4b126424e@quicinc.com>

Hi,

> >>>    >>       I have addressed your comments to v6 and further posted till v8.  
> >>       Could you please let me know if this is fine.
> >>       and how to get this merged ?  
> > 
> > There are still kernel test robot reports, so this means there are
> > issues in your code that I don't need to point out explicitly, but I am
> > actively waiting for them to be fixed.  
> 
> I have fixed most of the sparse warnings after converting __le32 to u32.
> However am not able to address the following sparse warnings
> 
> 	drivers/mtd/nand/raw/qcom_nandc.c:1401:29: sparse: warning: cast to restricted __le32
> 	drivers/mtd/nand/raw/qcom_nandc.c:1587:30: sparse: warning: cast to restricted __le32
> 	drivers/mtd/nand/raw/qcom_nandc.c:1588:31: sparse: warning: cast to restricted __le32
> 	drivers/mtd/nand/raw/qcom_nandc.c:1589:34: sparse: warning: cast to restricted __le32
> 	drivers/mtd/nand/raw/qcom_nandc.c:2479:47: sparse:    got restricted __le32 [usertype]
> 	drivers/mtd/nand/raw/qcom_nandc.c:2480:47: sparse:    got restricted __le32 [usertype]
> 	drivers/mtd/nand/raw/qcom_nandc.c:2616:25: sparse: warning: cast to restricted __le32
> 	drivers/mtd/nand/raw/qcom_nandc.c:2672:32: sparse: warning: cast to restricted __le32

The rule is: you cannot add new warnings.

For existing warnings in the driver, I'd anyway advise to solve them.
Without the actual code I cannot help.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2024-09-10  7:41 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-20 10:42 [PATCH v8 0/8] Add QPIC SPI NAND driver Md Sadre Alam
2024-08-20 10:42 ` Md Sadre Alam
2024-08-20 10:42 ` [PATCH v8 1/8] spi: dt-bindings: Introduce qcom,spi-qpic-snand Md Sadre Alam
2024-08-20 10:42   ` Md Sadre Alam
2024-08-20 10:42 ` [PATCH v8 2/8] mtd: rawnand: qcom: cleanup qcom_nandc driver Md Sadre Alam
2024-08-20 10:42   ` Md Sadre Alam
2024-08-22  2:10   ` kernel test robot
2024-08-22  2:10     ` kernel test robot
2024-08-20 10:42 ` [PATCH v8 3/8] mtd: rawnand: qcom: Add qcom prefix to common api Md Sadre Alam
2024-08-20 10:42   ` Md Sadre Alam
2024-08-20 10:42 ` [PATCH v8 4/8] mtd: nand: Add qpic_common API file Md Sadre Alam
2024-08-20 10:42   ` Md Sadre Alam
2024-08-20 10:42 ` [PATCH v8 5/8] mtd: rawnand: qcom: use FIELD_PREP and GENMASK Md Sadre Alam
2024-08-20 10:42   ` Md Sadre Alam
2024-08-22  8:25   ` kernel test robot
2024-08-22  8:25     ` kernel test robot
2024-08-20 10:42 ` [PATCH v8 6/8] spi: spi-qpic: add driver for QCOM SPI NAND flash Interface Md Sadre Alam
2024-08-20 10:42   ` Md Sadre Alam
2024-08-21  0:35   ` kernel test robot
2024-08-21  0:35     ` kernel test robot
2024-08-20 10:42 ` [PATCH v8 7/8] arm64: dts: qcom: ipq9574: Add SPI nand support Md Sadre Alam
2024-08-20 10:42   ` Md Sadre Alam
2024-08-20 10:42 ` [PATCH v8 8/8] arm64: dts: qcom: ipq9574: Disable eMMC node Md Sadre Alam
2024-08-20 10:42   ` Md Sadre Alam
2024-09-03  9:15 ` [PATCH v8 0/8] Add QPIC SPI NAND driver Md Sadre Alam
2024-09-03  9:15   ` Md Sadre Alam
2024-09-03 13:08   ` Miquel Raynal
2024-09-03 13:08     ` Miquel Raynal
2024-09-03 14:20     ` Md Sadre Alam
2024-09-03 14:20       ` Md Sadre Alam
2024-09-10  6:21     ` Md Sadre Alam
2024-09-10  6:21       ` Md Sadre Alam
2024-09-10  7:41       ` Miquel Raynal [this message]
2024-09-10  7:41         ` Miquel Raynal
2024-09-12  6:18         ` Md Sadre Alam
2024-09-12  6:18           ` Md Sadre Alam
2024-09-03 13:44   ` Krzysztof Kozlowski
2024-09-03 13:44     ` Krzysztof Kozlowski
2024-09-03 14:22     ` Md Sadre Alam
2024-09-03 14:22       ` Md Sadre Alam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240910094120.19348fea@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=andersson@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=esben@geanix.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=quic_mdalam@quicinc.com \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.