From: Krzysztof Kozlowski <krzk@kernel.org>
To: Md Sadre Alam <quic_mdalam@quicinc.com>,
broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andersson@kernel.org,
konradybcio@kernel.org, miquel.raynal@bootlin.com,
richard@nod.at, vigneshr@ti.com,
manivannan.sadhasivam@linaro.org, esben@geanix.com,
linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH v8 0/8] Add QPIC SPI NAND driver
Date: Tue, 3 Sep 2024 15:44:41 +0200 [thread overview]
Message-ID: <fed18a8f-446f-4d61-a9ce-4c5e09bf0aaa@kernel.org> (raw)
In-Reply-To: <5169761b-422d-70ab-ba53-a898cb7bfa2f@quicinc.com>
On 03/09/2024 11:15, Md Sadre Alam wrote:
> Hi Miquel,
>
> On 8/20/2024 4:12 PM, Md Sadre Alam wrote:
>> v8:
>> * Fixed compilation warning reported by kernel test robot
>> * Added "chip" description in nandc_set_read_loc_first()
>> * Added "chip" description" in nandc_set_read_loc_last()
>> * Changed data type of read_location0, read_location1,
>> read_location2, read_location3, addr0, addr1, cmd, cfg0,
>> cfg1, ecc_bch_cfg, ecc_buf_cfg, clrflashstatus, clrreadstatus,
>> orig_cmd1, orig_vld to __le32 to fix compilation warning.
>> * Included bitfield.h header file in spi-qpic-snand.c to
>> fix compilation warning
>> * Removed unused variable "steps" variable from
>> qcom_spi_ecc_init_ctx_pipelined()
>>
> I have addressed your comments to v6 and further posted till v8.
> Could you please let me know if this is fine.
> and how to get this merged ?
Two weeks ago you received reports that your code does not build
properly. So no, it is not fine. Please respond to the reports and/or
send corrected code.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Md Sadre Alam <quic_mdalam@quicinc.com>,
broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andersson@kernel.org,
konradybcio@kernel.org, miquel.raynal@bootlin.com,
richard@nod.at, vigneshr@ti.com,
manivannan.sadhasivam@linaro.org, esben@geanix.com,
linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH v8 0/8] Add QPIC SPI NAND driver
Date: Tue, 3 Sep 2024 15:44:41 +0200 [thread overview]
Message-ID: <fed18a8f-446f-4d61-a9ce-4c5e09bf0aaa@kernel.org> (raw)
In-Reply-To: <5169761b-422d-70ab-ba53-a898cb7bfa2f@quicinc.com>
On 03/09/2024 11:15, Md Sadre Alam wrote:
> Hi Miquel,
>
> On 8/20/2024 4:12 PM, Md Sadre Alam wrote:
>> v8:
>> * Fixed compilation warning reported by kernel test robot
>> * Added "chip" description in nandc_set_read_loc_first()
>> * Added "chip" description" in nandc_set_read_loc_last()
>> * Changed data type of read_location0, read_location1,
>> read_location2, read_location3, addr0, addr1, cmd, cfg0,
>> cfg1, ecc_bch_cfg, ecc_buf_cfg, clrflashstatus, clrreadstatus,
>> orig_cmd1, orig_vld to __le32 to fix compilation warning.
>> * Included bitfield.h header file in spi-qpic-snand.c to
>> fix compilation warning
>> * Removed unused variable "steps" variable from
>> qcom_spi_ecc_init_ctx_pipelined()
>>
> I have addressed your comments to v6 and further posted till v8.
> Could you please let me know if this is fine.
> and how to get this merged ?
Two weeks ago you received reports that your code does not build
properly. So no, it is not fine. Please respond to the reports and/or
send corrected code.
Best regards,
Krzysztof
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2024-09-03 13:44 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 10:42 [PATCH v8 0/8] Add QPIC SPI NAND driver Md Sadre Alam
2024-08-20 10:42 ` Md Sadre Alam
2024-08-20 10:42 ` [PATCH v8 1/8] spi: dt-bindings: Introduce qcom,spi-qpic-snand Md Sadre Alam
2024-08-20 10:42 ` Md Sadre Alam
2024-08-20 10:42 ` [PATCH v8 2/8] mtd: rawnand: qcom: cleanup qcom_nandc driver Md Sadre Alam
2024-08-20 10:42 ` Md Sadre Alam
2024-08-22 2:10 ` kernel test robot
2024-08-22 2:10 ` kernel test robot
2024-08-20 10:42 ` [PATCH v8 3/8] mtd: rawnand: qcom: Add qcom prefix to common api Md Sadre Alam
2024-08-20 10:42 ` Md Sadre Alam
2024-08-20 10:42 ` [PATCH v8 4/8] mtd: nand: Add qpic_common API file Md Sadre Alam
2024-08-20 10:42 ` Md Sadre Alam
2024-08-20 10:42 ` [PATCH v8 5/8] mtd: rawnand: qcom: use FIELD_PREP and GENMASK Md Sadre Alam
2024-08-20 10:42 ` Md Sadre Alam
2024-08-22 8:25 ` kernel test robot
2024-08-22 8:25 ` kernel test robot
2024-08-20 10:42 ` [PATCH v8 6/8] spi: spi-qpic: add driver for QCOM SPI NAND flash Interface Md Sadre Alam
2024-08-20 10:42 ` Md Sadre Alam
2024-08-21 0:35 ` kernel test robot
2024-08-21 0:35 ` kernel test robot
2024-08-20 10:42 ` [PATCH v8 7/8] arm64: dts: qcom: ipq9574: Add SPI nand support Md Sadre Alam
2024-08-20 10:42 ` Md Sadre Alam
2024-08-20 10:42 ` [PATCH v8 8/8] arm64: dts: qcom: ipq9574: Disable eMMC node Md Sadre Alam
2024-08-20 10:42 ` Md Sadre Alam
2024-09-03 9:15 ` [PATCH v8 0/8] Add QPIC SPI NAND driver Md Sadre Alam
2024-09-03 9:15 ` Md Sadre Alam
2024-09-03 13:08 ` Miquel Raynal
2024-09-03 13:08 ` Miquel Raynal
2024-09-03 14:20 ` Md Sadre Alam
2024-09-03 14:20 ` Md Sadre Alam
2024-09-10 6:21 ` Md Sadre Alam
2024-09-10 6:21 ` Md Sadre Alam
2024-09-10 7:41 ` Miquel Raynal
2024-09-10 7:41 ` Miquel Raynal
2024-09-12 6:18 ` Md Sadre Alam
2024-09-12 6:18 ` Md Sadre Alam
2024-09-03 13:44 ` Krzysztof Kozlowski [this message]
2024-09-03 13:44 ` Krzysztof Kozlowski
2024-09-03 14:22 ` Md Sadre Alam
2024-09-03 14:22 ` Md Sadre Alam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fed18a8f-446f-4d61-a9ce-4c5e09bf0aaa@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=esben@geanix.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=miquel.raynal@bootlin.com \
--cc=quic_mdalam@quicinc.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.