From: kernel test robot <lkp@intel.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v14 2/3] i2c: aspeed: support AST2600 i2c new register mode driver
Date: Sat, 5 Oct 2024 15:36:16 +0800 [thread overview]
Message-ID: <202410051547.vOL3qMOc-lkp@intel.com> (raw)
In-Reply-To: <20241002070213.1165263-3-ryan_chen@aspeedtech.com>
Hi Ryan,
kernel test robot noticed the following build errors:
[auto build test ERROR on v6.11]
[cannot apply to andi-shyti/i2c/i2c-host v6.12-rc1 linus/master next-20241004]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Ryan-Chen/dt-bindings-i2c-aspeed-support-for-AST2600-i2cv2/20241002-150410
base: v6.11
patch link: https://lore.kernel.org/r/20241002070213.1165263-3-ryan_chen%40aspeedtech.com
patch subject: [PATCH v14 2/3] i2c: aspeed: support AST2600 i2c new register mode driver
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20241005/202410051547.vOL3qMOc-lkp at intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241005/202410051547.vOL3qMOc-lkp at intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410051547.vOL3qMOc-lkp at intel.com/
All errors (new ones prefixed by >>):
drivers/i2c/busses/i2c-ast2600.c: In function 'ast2600_i2c_setup_buff_tx':
>> drivers/i2c/busses/i2c-ast2600.c:437:41: error: implicit declaration of function 'get_unaligned_le16'; did you mean 'get_unalign_ctl'? [-Wimplicit-function-declaration]
437 | get_unaligned_le16(&msg->buf[i2c_bus->master_xfer_cnt + i]);
| ^~~~~~~~~~~~~~~~~~
| get_unalign_ctl
>> drivers/i2c/busses/i2c-ast2600.c:441:41: error: implicit declaration of function 'get_unaligned_le24'; did you mean 'get_unalign_ctl'? [-Wimplicit-function-declaration]
441 | get_unaligned_le24(&msg->buf[i2c_bus->master_xfer_cnt + i]);
| ^~~~~~~~~~~~~~~~~~
| get_unalign_ctl
>> drivers/i2c/busses/i2c-ast2600.c:445:41: error: implicit declaration of function 'get_unaligned_le32'; did you mean 'get_unalign_ctl'? [-Wimplicit-function-declaration]
445 | get_unaligned_le32(&msg->buf[i2c_bus->master_xfer_cnt + i]);
| ^~~~~~~~~~~~~~~~~~
| get_unalign_ctl
vim +437 drivers/i2c/busses/i2c-ast2600.c
405
406 static int ast2600_i2c_setup_buff_tx(u32 cmd, struct ast2600_i2c_bus *i2c_bus)
407 {
408 struct i2c_msg *msg = &i2c_bus->msgs[i2c_bus->msgs_index];
409 u32 wbuf_dword;
410 int xfer_len;
411 int i;
412
413 cmd |= AST2600_I2CM_PKT_EN;
414 xfer_len = msg->len - i2c_bus->master_xfer_cnt;
415 if (xfer_len > i2c_bus->buf_size)
416 xfer_len = i2c_bus->buf_size;
417 else if (i2c_bus->msgs_index + 1 == i2c_bus->msgs_count)
418 cmd |= AST2600_I2CM_STOP_CMD;
419
420 if (cmd & AST2600_I2CM_START_CMD)
421 cmd |= AST2600_I2CM_PKT_ADDR(msg->addr);
422
423 if (xfer_len) {
424 cmd |= AST2600_I2CM_TX_BUFF_EN | AST2600_I2CM_TX_CMD;
425 /*
426 * The controller's buffer register supports dword writes only.
427 * Therefore, write dwords to the buffer register in a 4-byte aligned,
428 * and write the remaining unaligned data at the end.
429 */
430 for (i = 0; i < xfer_len; i += 4) {
431 switch (min(xfer_len - i, 4) % 4) {
432 case 1:
433 wbuf_dword = msg->buf[i2c_bus->master_xfer_cnt + i];
434 break;
435 case 2:
436 wbuf_dword =
> 437 get_unaligned_le16(&msg->buf[i2c_bus->master_xfer_cnt + i]);
438 break;
439 case 3:
440 wbuf_dword =
> 441 get_unaligned_le24(&msg->buf[i2c_bus->master_xfer_cnt + i]);
442 break;
443 default:
444 wbuf_dword =
> 445 get_unaligned_le32(&msg->buf[i2c_bus->master_xfer_cnt + i]);
446 break;
447 }
448 writel(wbuf_dword, i2c_bus->buf_base + i);
449 }
450 writel(AST2600_I2CC_SET_TX_BUF_LEN(xfer_len),
451 i2c_bus->reg_base + AST2600_I2CC_BUFF_CTRL);
452 }
453
454 writel(cmd, i2c_bus->reg_base + AST2600_I2CM_CMD_STS);
455
456 return 0;
457 }
458
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Ryan Chen <ryan_chen@aspeedtech.com>,
brendan.higgins@linux.dev, benh@kernel.crashing.org,
joel@jms.id.au, andi.shyti@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
andrew@codeconstruct.com.au, p.zabel@pengutronix.de,
andriy.shevchenko@linux.intel.com, linux-i2c@vger.kernel.org,
openbmc@lists.ozlabs.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH v14 2/3] i2c: aspeed: support AST2600 i2c new register mode driver
Date: Sat, 5 Oct 2024 15:36:16 +0800 [thread overview]
Message-ID: <202410051547.vOL3qMOc-lkp@intel.com> (raw)
In-Reply-To: <20241002070213.1165263-3-ryan_chen@aspeedtech.com>
Hi Ryan,
kernel test robot noticed the following build errors:
[auto build test ERROR on v6.11]
[cannot apply to andi-shyti/i2c/i2c-host v6.12-rc1 linus/master next-20241004]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Ryan-Chen/dt-bindings-i2c-aspeed-support-for-AST2600-i2cv2/20241002-150410
base: v6.11
patch link: https://lore.kernel.org/r/20241002070213.1165263-3-ryan_chen%40aspeedtech.com
patch subject: [PATCH v14 2/3] i2c: aspeed: support AST2600 i2c new register mode driver
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20241005/202410051547.vOL3qMOc-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241005/202410051547.vOL3qMOc-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410051547.vOL3qMOc-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/i2c/busses/i2c-ast2600.c: In function 'ast2600_i2c_setup_buff_tx':
>> drivers/i2c/busses/i2c-ast2600.c:437:41: error: implicit declaration of function 'get_unaligned_le16'; did you mean 'get_unalign_ctl'? [-Wimplicit-function-declaration]
437 | get_unaligned_le16(&msg->buf[i2c_bus->master_xfer_cnt + i]);
| ^~~~~~~~~~~~~~~~~~
| get_unalign_ctl
>> drivers/i2c/busses/i2c-ast2600.c:441:41: error: implicit declaration of function 'get_unaligned_le24'; did you mean 'get_unalign_ctl'? [-Wimplicit-function-declaration]
441 | get_unaligned_le24(&msg->buf[i2c_bus->master_xfer_cnt + i]);
| ^~~~~~~~~~~~~~~~~~
| get_unalign_ctl
>> drivers/i2c/busses/i2c-ast2600.c:445:41: error: implicit declaration of function 'get_unaligned_le32'; did you mean 'get_unalign_ctl'? [-Wimplicit-function-declaration]
445 | get_unaligned_le32(&msg->buf[i2c_bus->master_xfer_cnt + i]);
| ^~~~~~~~~~~~~~~~~~
| get_unalign_ctl
vim +437 drivers/i2c/busses/i2c-ast2600.c
405
406 static int ast2600_i2c_setup_buff_tx(u32 cmd, struct ast2600_i2c_bus *i2c_bus)
407 {
408 struct i2c_msg *msg = &i2c_bus->msgs[i2c_bus->msgs_index];
409 u32 wbuf_dword;
410 int xfer_len;
411 int i;
412
413 cmd |= AST2600_I2CM_PKT_EN;
414 xfer_len = msg->len - i2c_bus->master_xfer_cnt;
415 if (xfer_len > i2c_bus->buf_size)
416 xfer_len = i2c_bus->buf_size;
417 else if (i2c_bus->msgs_index + 1 == i2c_bus->msgs_count)
418 cmd |= AST2600_I2CM_STOP_CMD;
419
420 if (cmd & AST2600_I2CM_START_CMD)
421 cmd |= AST2600_I2CM_PKT_ADDR(msg->addr);
422
423 if (xfer_len) {
424 cmd |= AST2600_I2CM_TX_BUFF_EN | AST2600_I2CM_TX_CMD;
425 /*
426 * The controller's buffer register supports dword writes only.
427 * Therefore, write dwords to the buffer register in a 4-byte aligned,
428 * and write the remaining unaligned data at the end.
429 */
430 for (i = 0; i < xfer_len; i += 4) {
431 switch (min(xfer_len - i, 4) % 4) {
432 case 1:
433 wbuf_dword = msg->buf[i2c_bus->master_xfer_cnt + i];
434 break;
435 case 2:
436 wbuf_dword =
> 437 get_unaligned_le16(&msg->buf[i2c_bus->master_xfer_cnt + i]);
438 break;
439 case 3:
440 wbuf_dword =
> 441 get_unaligned_le24(&msg->buf[i2c_bus->master_xfer_cnt + i]);
442 break;
443 default:
444 wbuf_dword =
> 445 get_unaligned_le32(&msg->buf[i2c_bus->master_xfer_cnt + i]);
446 break;
447 }
448 writel(wbuf_dword, i2c_bus->buf_base + i);
449 }
450 writel(AST2600_I2CC_SET_TX_BUF_LEN(xfer_len),
451 i2c_bus->reg_base + AST2600_I2CC_BUFF_CTRL);
452 }
453
454 writel(cmd, i2c_bus->reg_base + AST2600_I2CM_CMD_STS);
455
456 return 0;
457 }
458
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-10-05 7:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 7:02 [PATCH v14 0/3] Add ASPEED AST2600 I2Cv2 controller driver Ryan Chen
2024-10-02 7:02 ` Ryan Chen
2024-10-02 7:02 ` [PATCH v14 1/3] dt-bindings: i2c: aspeed: support for AST2600-i2cv2 Ryan Chen
2024-10-02 7:02 ` Ryan Chen
2024-10-02 7:02 ` [PATCH v14 2/3] i2c: aspeed: support AST2600 i2c new register mode driver Ryan Chen
2024-10-02 7:02 ` Ryan Chen
2024-10-05 7:36 ` kernel test robot [this message]
2024-10-05 7:36 ` kernel test robot
2024-10-10 13:40 ` Andy Shevchenko
2024-10-10 13:40 ` Andy Shevchenko
2024-10-10 13:40 ` Andy Shevchenko
2024-10-11 0:16 ` Ryan Chen
2024-10-11 0:16 ` Ryan Chen
2024-10-11 0:16 ` Ryan Chen
2024-10-05 10:00 ` kernel test robot
2024-10-05 10:00 ` kernel test robot
2024-10-02 7:02 ` [PATCH v14 3/3] i2c: aspeed: support AST2600 i2c new register slave " Ryan Chen
2024-10-02 7:02 ` Ryan Chen
2024-10-02 14:35 ` [PATCH v14 0/3] Add ASPEED AST2600 I2Cv2 controller driver Andy Shevchenko
2024-10-02 14:35 ` Andy Shevchenko
2024-10-02 14:35 ` Andy Shevchenko
2024-10-03 3:41 ` Ryan Chen
2024-10-03 3:41 ` Ryan Chen
2024-10-03 3:41 ` Ryan Chen
2024-10-03 10:15 ` Andy Shevchenko
2024-10-03 10:15 ` Andy Shevchenko
2024-10-03 10:15 ` Andy Shevchenko
2024-10-03 12:20 ` Andi Shyti
2024-10-03 12:20 ` Andi Shyti
2024-10-03 12:20 ` Andi Shyti
2024-10-03 12:39 ` Andy Shevchenko
2024-10-03 12:39 ` Andy Shevchenko
2024-10-03 12:39 ` Andy Shevchenko
2024-10-04 6:58 ` Ryan Chen
2024-10-04 6:58 ` Ryan Chen
2024-10-04 6:58 ` Ryan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202410051547.vOL3qMOc-lkp@intel.com \
--to=lkp@intel.com \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.