All of lore.kernel.org
 help / color / mirror / Atom feed
From: Billy Tsai <billy_tsai@aspeedtech.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v7 3/7] gpio: aspeed: Change the macro to support deferred probe
Date: Tue, 8 Oct 2024 16:14:46 +0800	[thread overview]
Message-ID: <20241008081450.1490955-4-billy_tsai@aspeedtech.com> (raw)
In-Reply-To: <20241008081450.1490955-1-billy_tsai@aspeedtech.com>

Use module_platform_driver() to replace module_platform_driver_probe().
The former utilizes platform_driver_register(), which allows the driver to
defer probing when it doesn't acquire the necessary resources due to probe
order. In contrast, the latter uses __platform_driver_probe(), which
includes the comment "Note that this is incompatible with deferred
probing." Since our GPIO driver requires access to the clock resource, the
former is more suitable.

Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
---
 drivers/gpio/gpio-aspeed.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
index ea40ad43a79b..c49c55ae962b 100644
--- a/drivers/gpio/gpio-aspeed.c
+++ b/drivers/gpio/gpio-aspeed.c
@@ -1169,7 +1169,7 @@ static const struct of_device_id aspeed_gpio_of_table[] = {
 };
 MODULE_DEVICE_TABLE(of, aspeed_gpio_of_table);
 
-static int __init aspeed_gpio_probe(struct platform_device *pdev)
+static int aspeed_gpio_probe(struct platform_device *pdev)
 {
 	const struct of_device_id *gpio_id;
 	struct gpio_irq_chip *girq;
@@ -1270,13 +1270,14 @@ static int __init aspeed_gpio_probe(struct platform_device *pdev)
 }
 
 static struct platform_driver aspeed_gpio_driver = {
+	.probe = aspeed_gpio_probe,
 	.driver = {
 		.name = KBUILD_MODNAME,
 		.of_match_table = aspeed_gpio_of_table,
 	},
 };
 
-module_platform_driver_probe(aspeed_gpio_driver, aspeed_gpio_probe);
+module_platform_driver(aspeed_gpio_driver);
 
 MODULE_DESCRIPTION("Aspeed GPIO Driver");
 MODULE_LICENSE("GPL");
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Billy Tsai <billy_tsai@aspeedtech.com>
To: <linus.walleij@linaro.org>, <brgl@bgdev.pl>, <robh@kernel.org>,
	<krzk+dt@kernel.org>, <conor+dt@kernel.org>, <joel@jms.id.au>,
	<andrew@codeconstruct.com.au>, <linux-gpio@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-aspeed@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
	<BMC-SW@aspeedtech.com>, <Peter.Yin@quantatw.com>,
	<Jay_Zhang@wiwynn.com>
Subject: [PATCH v7 3/7] gpio: aspeed: Change the macro to support deferred probe
Date: Tue, 8 Oct 2024 16:14:46 +0800	[thread overview]
Message-ID: <20241008081450.1490955-4-billy_tsai@aspeedtech.com> (raw)
In-Reply-To: <20241008081450.1490955-1-billy_tsai@aspeedtech.com>

Use module_platform_driver() to replace module_platform_driver_probe().
The former utilizes platform_driver_register(), which allows the driver to
defer probing when it doesn't acquire the necessary resources due to probe
order. In contrast, the latter uses __platform_driver_probe(), which
includes the comment "Note that this is incompatible with deferred
probing." Since our GPIO driver requires access to the clock resource, the
former is more suitable.

Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
---
 drivers/gpio/gpio-aspeed.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
index ea40ad43a79b..c49c55ae962b 100644
--- a/drivers/gpio/gpio-aspeed.c
+++ b/drivers/gpio/gpio-aspeed.c
@@ -1169,7 +1169,7 @@ static const struct of_device_id aspeed_gpio_of_table[] = {
 };
 MODULE_DEVICE_TABLE(of, aspeed_gpio_of_table);
 
-static int __init aspeed_gpio_probe(struct platform_device *pdev)
+static int aspeed_gpio_probe(struct platform_device *pdev)
 {
 	const struct of_device_id *gpio_id;
 	struct gpio_irq_chip *girq;
@@ -1270,13 +1270,14 @@ static int __init aspeed_gpio_probe(struct platform_device *pdev)
 }
 
 static struct platform_driver aspeed_gpio_driver = {
+	.probe = aspeed_gpio_probe,
 	.driver = {
 		.name = KBUILD_MODNAME,
 		.of_match_table = aspeed_gpio_of_table,
 	},
 };
 
-module_platform_driver_probe(aspeed_gpio_driver, aspeed_gpio_probe);
+module_platform_driver(aspeed_gpio_driver);
 
 MODULE_DESCRIPTION("Aspeed GPIO Driver");
 MODULE_LICENSE("GPL");
-- 
2.25.1


  parent reply	other threads:[~2024-10-08  8:14 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-08  8:14 [PATCH v7 0/7] Add Aspeed G7 gpio support Billy Tsai
2024-10-08  8:14 ` Billy Tsai
2024-10-08  8:14 ` [PATCH v7 1/7] gpio: aspeed: Add the flush write to ensure the write complete Billy Tsai
2024-10-08  8:14   ` Billy Tsai
2024-10-08  8:14 ` [PATCH v7 2/7] gpio: aspeed: Use devm_clk api to manage clock source Billy Tsai
2024-10-08  8:14   ` Billy Tsai
2024-10-08  8:14 ` Billy Tsai [this message]
2024-10-08  8:14   ` [PATCH v7 3/7] gpio: aspeed: Change the macro to support deferred probe Billy Tsai
2024-10-08  8:14 ` [PATCH v7 4/7] gpio: aspeed: Remove the name for bank array Billy Tsai
2024-10-08  8:14   ` Billy Tsai
2024-10-08  8:14 ` [PATCH v7 5/7] gpio: aspeed: Create llops to handle hardware access Billy Tsai
2024-10-08  8:14   ` Billy Tsai
2024-10-09  1:57   ` Andrew Jeffery
2024-10-09  1:57     ` Andrew Jeffery
2024-10-08  8:14 ` [PATCH v7 6/7] dt-bindings: gpio: aspeed,ast2400-gpio: Support ast2700 Billy Tsai
2024-10-08  8:14   ` Billy Tsai
2024-10-08  8:14 ` [PATCH v7 7/7] gpio: aspeed: Support G7 Aspeed gpio controller Billy Tsai
2024-10-08  8:14   ` Billy Tsai
2024-10-09  2:12   ` Andrew Jeffery
2024-10-09  2:12     ` Andrew Jeffery
2024-10-09  2:28     ` Billy Tsai
2024-10-09  2:28       ` Billy Tsai
2024-10-09  6:47       ` Andrew Jeffery
2024-10-09  6:47         ` Andrew Jeffery
2024-10-08 14:02 ` (subset) [PATCH v7 0/7] Add Aspeed G7 gpio support Bartosz Golaszewski
2024-10-08 14:02   ` Bartosz Golaszewski
2024-10-08 14:04 ` Bartosz Golaszewski
2024-10-08 14:04   ` Bartosz Golaszewski
2024-10-14  7:04 ` (subset) " Bartosz Golaszewski
2024-10-14  7:04   ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241008081450.1490955-4-billy_tsai@aspeedtech.com \
    --to=billy_tsai@aspeedtech.com \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.