All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v7 5/7] gpio: aspeed: Create llops to handle hardware access
Date: Wed, 09 Oct 2024 12:27:01 +1030	[thread overview]
Message-ID: <38c72aa9f4cbd3d4a6dc9f8baac20e9bd87db644.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20241008081450.1490955-6-billy_tsai@aspeedtech.com>

On Tue, 2024-10-08 at 16:14 +0800, Billy Tsai wrote:
> Add low-level operations (llops) to abstract the register access for GPIO
> registers and the coprocessor request/release. With this abstraction
> layer, the driver can separate the hardware and software logic, making it
> easier to extend the driver to support different hardware register
> layouts.
> 
> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>

Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>

I've applied the series to here and booted it on a AST2600. I did some
brief testing with a logic analyzer and gpio{get,set} and didn't see
anything surprising, so:

Tested-by: Andrew Jeffery <andrew@codeconstruct.com.au> # AST2600

Thanks Billy!

Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Billy Tsai <billy_tsai@aspeedtech.com>,
	linus.walleij@linaro.org,  brgl@bgdev.pl, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,  joel@jms.id.au,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org,  linux-kernel@vger.kernel.org,
	BMC-SW@aspeedtech.com, Peter.Yin@quantatw.com,
	 Jay_Zhang@wiwynn.com
Subject: Re: [PATCH v7 5/7] gpio: aspeed: Create llops to handle hardware access
Date: Wed, 09 Oct 2024 12:27:01 +1030	[thread overview]
Message-ID: <38c72aa9f4cbd3d4a6dc9f8baac20e9bd87db644.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20241008081450.1490955-6-billy_tsai@aspeedtech.com>

On Tue, 2024-10-08 at 16:14 +0800, Billy Tsai wrote:
> Add low-level operations (llops) to abstract the register access for GPIO
> registers and the coprocessor request/release. With this abstraction
> layer, the driver can separate the hardware and software logic, making it
> easier to extend the driver to support different hardware register
> layouts.
> 
> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>

Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>

I've applied the series to here and booted it on a AST2600. I did some
brief testing with a logic analyzer and gpio{get,set} and didn't see
anything surprising, so:

Tested-by: Andrew Jeffery <andrew@codeconstruct.com.au> # AST2600

Thanks Billy!

Andrew

  reply	other threads:[~2024-10-09  1:57 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-08  8:14 [PATCH v7 0/7] Add Aspeed G7 gpio support Billy Tsai
2024-10-08  8:14 ` Billy Tsai
2024-10-08  8:14 ` [PATCH v7 1/7] gpio: aspeed: Add the flush write to ensure the write complete Billy Tsai
2024-10-08  8:14   ` Billy Tsai
2024-10-08  8:14 ` [PATCH v7 2/7] gpio: aspeed: Use devm_clk api to manage clock source Billy Tsai
2024-10-08  8:14   ` Billy Tsai
2024-10-08  8:14 ` [PATCH v7 3/7] gpio: aspeed: Change the macro to support deferred probe Billy Tsai
2024-10-08  8:14   ` Billy Tsai
2024-10-08  8:14 ` [PATCH v7 4/7] gpio: aspeed: Remove the name for bank array Billy Tsai
2024-10-08  8:14   ` Billy Tsai
2024-10-08  8:14 ` [PATCH v7 5/7] gpio: aspeed: Create llops to handle hardware access Billy Tsai
2024-10-08  8:14   ` Billy Tsai
2024-10-09  1:57   ` Andrew Jeffery [this message]
2024-10-09  1:57     ` Andrew Jeffery
2024-10-08  8:14 ` [PATCH v7 6/7] dt-bindings: gpio: aspeed,ast2400-gpio: Support ast2700 Billy Tsai
2024-10-08  8:14   ` Billy Tsai
2024-10-08  8:14 ` [PATCH v7 7/7] gpio: aspeed: Support G7 Aspeed gpio controller Billy Tsai
2024-10-08  8:14   ` Billy Tsai
2024-10-09  2:12   ` Andrew Jeffery
2024-10-09  2:12     ` Andrew Jeffery
2024-10-09  2:28     ` Billy Tsai
2024-10-09  2:28       ` Billy Tsai
2024-10-09  6:47       ` Andrew Jeffery
2024-10-09  6:47         ` Andrew Jeffery
2024-10-08 14:02 ` (subset) [PATCH v7 0/7] Add Aspeed G7 gpio support Bartosz Golaszewski
2024-10-08 14:02   ` Bartosz Golaszewski
2024-10-08 14:04 ` Bartosz Golaszewski
2024-10-08 14:04   ` Bartosz Golaszewski
2024-10-14  7:04 ` (subset) " Bartosz Golaszewski
2024-10-14  7:04   ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38c72aa9f4cbd3d4a6dc9f8baac20e9bd87db644.camel@codeconstruct.com.au \
    --to=andrew@codeconstruct.com.au \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.