From: Florian Westphal <fw@strlen.de>
To: Florian Westphal <fw@strlen.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 2/2] debug: include kernel set information on cache fill
Date: Thu, 21 Nov 2024 10:24:27 +0100 [thread overview]
Message-ID: <20241121092427.GA12619@breakpoint.cc> (raw)
In-Reply-To: <20241120233854.GB31921@breakpoint.cc>
Florian Westphal <fw@strlen.de> wrote:
> > set y {
> > type ipv4_addr
> > size 256 # count 128
> > ...
> >
> > We have to exposed the number of elements counter. I think this can be
> > exposed if set declaration provides size (or default size is used).
>
> OK, I will update libnftl then because this means it will need
> proper getter for nft sake.
There is a problem with this, shell tests break:
W: [DUMP FAIL] 9/430 tests/shell/testcases/sets/0057set_create_fails_0
cat /tmp/nft-test.latest.root/test-tests-shell-testcases-sets-0057set_create_fails_0.11/ruleset-diff
--- tests/shell/testcases/sets/dumps/0057set_create_fails_0.nft 2024-11-21 09:46:16.888431831 +0100
+++ /tmp/nft-test.20241121-101956.182.zWvUOZ/test-tests-shell-testcases-sets-0057set_create_fails_0.11/ruleset-after 2024-11-21 10:20:00.046431831 +0100
@@ -1,7 +1,7 @@
table inet filter {
set test {
type ipv4_addr
- size 65535
+ size 65535 # count 1
elements = { 1.1.1.1 }
}
As shell tests coud run on old kernel, regen dump file won't work.
Only options I see is to add a feature test file for this support,
and then either disabling dump validation if it failed or adding
additonal/alternative dump file.
next prev parent reply other threads:[~2024-11-21 9:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 10:02 [PATCH nft 1/2] tests/py: prepare for set debug change Florian Westphal
2024-11-20 10:02 ` [PATCH nft 2/2] debug: include kernel set information on cache fill Florian Westphal
2024-11-20 23:29 ` Pablo Neira Ayuso
2024-11-20 23:38 ` Florian Westphal
2024-11-21 9:24 ` Florian Westphal [this message]
2024-11-21 10:00 ` Pablo Neira Ayuso
2024-11-21 12:02 ` Florian Westphal
2024-11-21 15:12 ` Pablo Neira Ayuso
2024-11-21 17:19 ` Florian Westphal
2024-11-22 13:35 ` Pablo Neira Ayuso
2024-11-22 13:43 ` Florian Westphal
2024-11-22 14:01 ` Pablo Neira Ayuso
2024-11-22 14:38 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241121092427.GA12619@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.