From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 2/2] debug: include kernel set information on cache fill
Date: Thu, 21 Nov 2024 18:19:57 +0100 [thread overview]
Message-ID: <20241121171957.GA25690@breakpoint.cc> (raw)
In-Reply-To: <Zz9N4CmuiLxQpaAH@calendula>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > AFAICS we only need to update < 10 dump files,
> > so churn is not too bad.
> >
> > Alternative is to always store postprocessed
> > dumps and then always run sed before diff, but I think
> > its better to do the extra mile.
>
> rbtree going leaks a raw count of independent interval values which is
> going to be awkward to the user.
Sure, wasn't that the reason why you iniitially wanted to restrict this to
--netlink=debug? What made you change your mind?
Maybe apply the simpler, existing v1 patches only, i.e. no exposure?
I can just send a v2 with the new attribute names and no getter for
libnftnl.
next prev parent reply other threads:[~2024-11-21 17:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 10:02 [PATCH nft 1/2] tests/py: prepare for set debug change Florian Westphal
2024-11-20 10:02 ` [PATCH nft 2/2] debug: include kernel set information on cache fill Florian Westphal
2024-11-20 23:29 ` Pablo Neira Ayuso
2024-11-20 23:38 ` Florian Westphal
2024-11-21 9:24 ` Florian Westphal
2024-11-21 10:00 ` Pablo Neira Ayuso
2024-11-21 12:02 ` Florian Westphal
2024-11-21 15:12 ` Pablo Neira Ayuso
2024-11-21 17:19 ` Florian Westphal [this message]
2024-11-22 13:35 ` Pablo Neira Ayuso
2024-11-22 13:43 ` Florian Westphal
2024-11-22 14:01 ` Pablo Neira Ayuso
2024-11-22 14:38 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241121171957.GA25690@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.