From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 2/2] debug: include kernel set information on cache fill
Date: Thu, 21 Nov 2024 00:29:44 +0100 [thread overview]
Message-ID: <Zz5w6NPQ2XsJrpHG@calendula> (raw)
In-Reply-To: <20241120100221.11001-2-fw@strlen.de>
Hi Florian,
On Wed, Nov 20, 2024 at 11:02:16AM +0100, Florian Westphal wrote:
> Honor --debug=netlink flag also when doing initial set dump
> from the kernel.
>
> With recent libnftnl update this will include the chosen
> set backend name that is used by the kernel.
>
> Because set names are scoped by table and protocol family,
> also include the family protocol number.
>
> Dumping this information breaks tests/py as the recorded
> debug output no longer matches, this is fixed in previous
> change.
table ip x {
set y {
type ipv4_addr
size 256 # count 128
...
We have to exposed the number of elements counter. I think this can be
exposed if set declaration provides size (or default size is used).
And update nftables manpage:
"When listing the set, the element count is larger than the listed
number of elements for sets: the number of elements in the set is
updated when elements added/deleted to the set and periodically when
the garbage collector evicts the timed out elements."
P.S: Yes, I changed my mind on this :)
next prev parent reply other threads:[~2024-11-20 23:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 10:02 [PATCH nft 1/2] tests/py: prepare for set debug change Florian Westphal
2024-11-20 10:02 ` [PATCH nft 2/2] debug: include kernel set information on cache fill Florian Westphal
2024-11-20 23:29 ` Pablo Neira Ayuso [this message]
2024-11-20 23:38 ` Florian Westphal
2024-11-21 9:24 ` Florian Westphal
2024-11-21 10:00 ` Pablo Neira Ayuso
2024-11-21 12:02 ` Florian Westphal
2024-11-21 15:12 ` Pablo Neira Ayuso
2024-11-21 17:19 ` Florian Westphal
2024-11-22 13:35 ` Pablo Neira Ayuso
2024-11-22 13:43 ` Florian Westphal
2024-11-22 14:01 ` Pablo Neira Ayuso
2024-11-22 14:38 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zz5w6NPQ2XsJrpHG@calendula \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.