* [f2fs-dev] [PATCH 1/3] f2fs/005: update commit id in _fixed_by_kernel_commit line
@ 2024-12-02 11:41 ` Chao Yu via Linux-f2fs-devel
0 siblings, 0 replies; 10+ messages in thread
From: Chao Yu via Linux-f2fs-devel @ 2024-12-02 11:41 UTC (permalink / raw)
To: Zorro Lang, fstests; +Cc: jaegeuk, linux-f2fs-devel
The bug related to this regression testcase has been fixed by commit
d5c367ef8287 ("f2fs: fix f2fs_bug_on when uninstalling filesystem call
f2fs_evict_inode."), let's update commit id in _fixed_by_kernel_commit
line.
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Chao Yu <chao@kernel.org>
---
tests/f2fs/005 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/f2fs/005 b/tests/f2fs/005
index a817d51a..33d4fdb9 100755
--- a/tests/f2fs/005
+++ b/tests/f2fs/005
@@ -11,7 +11,7 @@
. ./common/preamble
_begin_fstest auto quick
-_fixed_by_kernel_commit xxxxxxxxxxxx \
+_fixed_by_kernel_commit d5c367ef8287 \
"f2fs: fix f2fs_bug_on when uninstalling filesystem call f2fs_evict_inode."
_require_scratch
--
2.40.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 2/3] f2fs/006: update commit id in _fixed_by_kernel_commit line
2024-12-02 11:41 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
@ 2024-12-02 11:41 ` Chao Yu via Linux-f2fs-devel
-1 siblings, 0 replies; 10+ messages in thread
From: Chao Yu @ 2024-12-02 11:41 UTC (permalink / raw)
To: Zorro Lang, fstests; +Cc: jaegeuk, linux-f2fs-devel, Chao Yu
The bug related to this regression testcase has been fixed by commit
1acd73edbbfe ("f2fs: fix to account dirty data in __get_secs_required()"),
let's update commit id in _fixed_by_kernel_commit line.
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Chao Yu <chao@kernel.org>
---
tests/f2fs/006 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/f2fs/006 b/tests/f2fs/006
index a9c823c1..c1f8d4ff 100755
--- a/tests/f2fs/006
+++ b/tests/f2fs/006
@@ -16,7 +16,7 @@
. ./common/preamble
_begin_fstest auto quick
-_fixed_by_kernel_commit xxxxxxxxxxxx \
+_fixed_by_kernel_commit 1acd73edbbfe \
"f2fs: fix to account dirty data in __get_secs_required()"
_require_scratch
--
2.40.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [f2fs-dev] [PATCH 2/3] f2fs/006: update commit id in _fixed_by_kernel_commit line
@ 2024-12-02 11:41 ` Chao Yu via Linux-f2fs-devel
0 siblings, 0 replies; 10+ messages in thread
From: Chao Yu via Linux-f2fs-devel @ 2024-12-02 11:41 UTC (permalink / raw)
To: Zorro Lang, fstests; +Cc: jaegeuk, linux-f2fs-devel
The bug related to this regression testcase has been fixed by commit
1acd73edbbfe ("f2fs: fix to account dirty data in __get_secs_required()"),
let's update commit id in _fixed_by_kernel_commit line.
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Chao Yu <chao@kernel.org>
---
tests/f2fs/006 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/f2fs/006 b/tests/f2fs/006
index a9c823c1..c1f8d4ff 100755
--- a/tests/f2fs/006
+++ b/tests/f2fs/006
@@ -16,7 +16,7 @@
. ./common/preamble
_begin_fstest auto quick
-_fixed_by_kernel_commit xxxxxxxxxxxx \
+_fixed_by_kernel_commit 1acd73edbbfe \
"f2fs: fix to account dirty data in __get_secs_required()"
_require_scratch
--
2.40.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/3] f2fs/007: update commit id in _fixed_by_kernel_commit line
2024-12-02 11:41 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
@ 2024-12-02 11:41 ` Chao Yu via Linux-f2fs-devel
-1 siblings, 0 replies; 10+ messages in thread
From: Chao Yu @ 2024-12-02 11:41 UTC (permalink / raw)
To: Zorro Lang, fstests; +Cc: jaegeuk, linux-f2fs-devel, Chao Yu
The bug related to this regression testcase has been fixed by commit
26413ce18e85 ("f2fs: compress: fix inconsistent update of i_blocks in
release_compress_blocks and reserve_compress_blocks"), let's update
commit id in _fixed_by_kernel_commit line.
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Chao Yu <chao@kernel.org>
---
tests/f2fs/007 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/f2fs/007 b/tests/f2fs/007
index 6451d4b4..37388433 100755
--- a/tests/f2fs/007
+++ b/tests/f2fs/007
@@ -11,7 +11,7 @@
. ./common/preamble
_begin_fstest auto quick rw compress
-_fixed_by_kernel_commit xxxxxxxxxxxx \
+_fixed_by_kernel_commit 26413ce18e85 \
"f2fs: compress: fix inconsistent update of i_blocks in release_compress_blocks and reserve_compress_blocks"
_require_scratch
--
2.40.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [f2fs-dev] [PATCH 3/3] f2fs/007: update commit id in _fixed_by_kernel_commit line
@ 2024-12-02 11:41 ` Chao Yu via Linux-f2fs-devel
0 siblings, 0 replies; 10+ messages in thread
From: Chao Yu via Linux-f2fs-devel @ 2024-12-02 11:41 UTC (permalink / raw)
To: Zorro Lang, fstests; +Cc: jaegeuk, linux-f2fs-devel
The bug related to this regression testcase has been fixed by commit
26413ce18e85 ("f2fs: compress: fix inconsistent update of i_blocks in
release_compress_blocks and reserve_compress_blocks"), let's update
commit id in _fixed_by_kernel_commit line.
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Chao Yu <chao@kernel.org>
---
tests/f2fs/007 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/f2fs/007 b/tests/f2fs/007
index 6451d4b4..37388433 100755
--- a/tests/f2fs/007
+++ b/tests/f2fs/007
@@ -11,7 +11,7 @@
. ./common/preamble
_begin_fstest auto quick rw compress
-_fixed_by_kernel_commit xxxxxxxxxxxx \
+_fixed_by_kernel_commit 26413ce18e85 \
"f2fs: compress: fix inconsistent update of i_blocks in release_compress_blocks and reserve_compress_blocks"
_require_scratch
--
2.40.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] f2fs/005: update commit id in _fixed_by_kernel_commit line
2024-12-02 11:41 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
@ 2024-12-02 19:28 ` Zorro Lang
-1 siblings, 0 replies; 10+ messages in thread
From: Zorro Lang @ 2024-12-02 19:28 UTC (permalink / raw)
To: Chao Yu; +Cc: Zorro Lang, fstests, jaegeuk, linux-f2fs-devel
On Mon, Dec 02, 2024 at 07:41:47PM +0800, Chao Yu wrote:
> The bug related to this regression testcase has been fixed by commit
> d5c367ef8287 ("f2fs: fix f2fs_bug_on when uninstalling filesystem call
> f2fs_evict_inode."), let's update commit id in _fixed_by_kernel_commit
> line.
>
> Cc: Jaegeuk Kim <jaegeuk@kernel.org>
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
> tests/f2fs/005 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/f2fs/005 b/tests/f2fs/005
> index a817d51a..33d4fdb9 100755
> --- a/tests/f2fs/005
> +++ b/tests/f2fs/005
> @@ -11,7 +11,7 @@
> . ./common/preamble
> _begin_fstest auto quick
>
> -_fixed_by_kernel_commit xxxxxxxxxxxx \
> +_fixed_by_kernel_commit d5c367ef8287 \
> "f2fs: fix f2fs_bug_on when uninstalling filesystem call f2fs_evict_inode."
I think we don't need to use 3 patches. As you just add missed commit id number,
just merge them into one and named "f2fs: add commit id to _fixed_by_kernel_commit".
Or if you hope I can do that when I merge it, feel free to tell me :)
Others look good to me, with above change:
Reviewed-by: Zorro Lang <zlang@redhat.com>
>
> _require_scratch
> --
> 2.40.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [f2fs-dev] [PATCH 1/3] f2fs/005: update commit id in _fixed_by_kernel_commit line
@ 2024-12-02 19:28 ` Zorro Lang
0 siblings, 0 replies; 10+ messages in thread
From: Zorro Lang @ 2024-12-02 19:28 UTC (permalink / raw)
To: Chao Yu; +Cc: jaegeuk, Zorro Lang, fstests, linux-f2fs-devel
On Mon, Dec 02, 2024 at 07:41:47PM +0800, Chao Yu wrote:
> The bug related to this regression testcase has been fixed by commit
> d5c367ef8287 ("f2fs: fix f2fs_bug_on when uninstalling filesystem call
> f2fs_evict_inode."), let's update commit id in _fixed_by_kernel_commit
> line.
>
> Cc: Jaegeuk Kim <jaegeuk@kernel.org>
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
> tests/f2fs/005 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/f2fs/005 b/tests/f2fs/005
> index a817d51a..33d4fdb9 100755
> --- a/tests/f2fs/005
> +++ b/tests/f2fs/005
> @@ -11,7 +11,7 @@
> . ./common/preamble
> _begin_fstest auto quick
>
> -_fixed_by_kernel_commit xxxxxxxxxxxx \
> +_fixed_by_kernel_commit d5c367ef8287 \
> "f2fs: fix f2fs_bug_on when uninstalling filesystem call f2fs_evict_inode."
I think we don't need to use 3 patches. As you just add missed commit id number,
just merge them into one and named "f2fs: add commit id to _fixed_by_kernel_commit".
Or if you hope I can do that when I merge it, feel free to tell me :)
Others look good to me, with above change:
Reviewed-by: Zorro Lang <zlang@redhat.com>
>
> _require_scratch
> --
> 2.40.1
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 1/3] f2fs/005: update commit id in _fixed_by_kernel_commit line
2024-12-02 19:28 ` [f2fs-dev] " Zorro Lang
@ 2024-12-03 11:29 ` Chao Yu via Linux-f2fs-devel
-1 siblings, 0 replies; 10+ messages in thread
From: Chao Yu @ 2024-12-03 11:29 UTC (permalink / raw)
To: Zorro Lang; +Cc: Chao Yu, Zorro Lang, fstests, jaegeuk, linux-f2fs-devel
On 2024/12/3 3:28, Zorro Lang wrote:
> On Mon, Dec 02, 2024 at 07:41:47PM +0800, Chao Yu wrote:
>> The bug related to this regression testcase has been fixed by commit
>> d5c367ef8287 ("f2fs: fix f2fs_bug_on when uninstalling filesystem call
>> f2fs_evict_inode."), let's update commit id in _fixed_by_kernel_commit
>> line.
>>
>> Cc: Jaegeuk Kim <jaegeuk@kernel.org>
>> Signed-off-by: Chao Yu <chao@kernel.org>
>> ---
>> tests/f2fs/005 | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/f2fs/005 b/tests/f2fs/005
>> index a817d51a..33d4fdb9 100755
>> --- a/tests/f2fs/005
>> +++ b/tests/f2fs/005
>> @@ -11,7 +11,7 @@
>> . ./common/preamble
>> _begin_fstest auto quick
>>
>> -_fixed_by_kernel_commit xxxxxxxxxxxx \
>> +_fixed_by_kernel_commit d5c367ef8287 \
>> "f2fs: fix f2fs_bug_on when uninstalling filesystem call f2fs_evict_inode."
>
> I think we don't need to use 3 patches. As you just add missed commit id number,
> just merge them into one and named "f2fs: add commit id to _fixed_by_kernel_commit".
> Or if you hope I can do that when I merge it, feel free to tell me :)
Zorro,
I've sent a new patch, can you please help to review it? thank you.
Thanks,
>
> Others look good to me, with above change:
>
> Reviewed-by: Zorro Lang <zlang@redhat.com>
>
>>
>> _require_scratch
>> --
>> 2.40.1
>>
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [f2fs-dev] [PATCH 1/3] f2fs/005: update commit id in _fixed_by_kernel_commit line
@ 2024-12-03 11:29 ` Chao Yu via Linux-f2fs-devel
0 siblings, 0 replies; 10+ messages in thread
From: Chao Yu via Linux-f2fs-devel @ 2024-12-03 11:29 UTC (permalink / raw)
To: Zorro Lang; +Cc: jaegeuk, Zorro Lang, fstests, linux-f2fs-devel
On 2024/12/3 3:28, Zorro Lang wrote:
> On Mon, Dec 02, 2024 at 07:41:47PM +0800, Chao Yu wrote:
>> The bug related to this regression testcase has been fixed by commit
>> d5c367ef8287 ("f2fs: fix f2fs_bug_on when uninstalling filesystem call
>> f2fs_evict_inode."), let's update commit id in _fixed_by_kernel_commit
>> line.
>>
>> Cc: Jaegeuk Kim <jaegeuk@kernel.org>
>> Signed-off-by: Chao Yu <chao@kernel.org>
>> ---
>> tests/f2fs/005 | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/f2fs/005 b/tests/f2fs/005
>> index a817d51a..33d4fdb9 100755
>> --- a/tests/f2fs/005
>> +++ b/tests/f2fs/005
>> @@ -11,7 +11,7 @@
>> . ./common/preamble
>> _begin_fstest auto quick
>>
>> -_fixed_by_kernel_commit xxxxxxxxxxxx \
>> +_fixed_by_kernel_commit d5c367ef8287 \
>> "f2fs: fix f2fs_bug_on when uninstalling filesystem call f2fs_evict_inode."
>
> I think we don't need to use 3 patches. As you just add missed commit id number,
> just merge them into one and named "f2fs: add commit id to _fixed_by_kernel_commit".
> Or if you hope I can do that when I merge it, feel free to tell me :)
Zorro,
I've sent a new patch, can you please help to review it? thank you.
Thanks,
>
> Others look good to me, with above change:
>
> Reviewed-by: Zorro Lang <zlang@redhat.com>
>
>>
>> _require_scratch
>> --
>> 2.40.1
>>
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 10+ messages in thread