* sound/soc/amd/acp/acp70.c:217 acp70_pcm_resume() error: we previously assumed 'stream' could be null (see line 218)
@ 2024-12-05 13:17 kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2024-12-05 13:17 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Syed Saba Kareem <Syed.SabaKareem@amd.com>
CC: Mark Brown <broonie@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: feffde684ac29a3b7aec82d2df850fbdbdee55e4
commit: d3534684ada99ef8c0899eb28c62b4462483ee19 ASoC: amd: acp: add Kconfig options for acp7.0 based platform driver
date: 1 year, 1 month ago
:::::: branch date: 2 days ago
:::::: commit date: 1 year, 1 month ago
config: x86_64-randconfig-161-20241205 (https://download.01.org/0day-ci/archive/20241205/202412052149.HYbkQDxc-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202412052149.HYbkQDxc-lkp@intel.com/
smatch warnings:
sound/soc/amd/acp/acp70.c:217 acp70_pcm_resume() error: we previously assumed 'stream' could be null (see line 218)
vim +/stream +217 sound/soc/amd/acp/acp70.c
e84db124cb2158b Syed Saba Kareem 2023-10-21 207
e84db124cb2158b Syed Saba Kareem 2023-10-21 208 static int __maybe_unused acp70_pcm_resume(struct device *dev)
e84db124cb2158b Syed Saba Kareem 2023-10-21 209 {
e84db124cb2158b Syed Saba Kareem 2023-10-21 210 struct acp_dev_data *adata = dev_get_drvdata(dev);
e84db124cb2158b Syed Saba Kareem 2023-10-21 211 struct acp_stream *stream;
e84db124cb2158b Syed Saba Kareem 2023-10-21 212 struct snd_pcm_substream *substream;
e84db124cb2158b Syed Saba Kareem 2023-10-21 213 snd_pcm_uframes_t buf_in_frames;
e84db124cb2158b Syed Saba Kareem 2023-10-21 214 u64 buf_size;
e84db124cb2158b Syed Saba Kareem 2023-10-21 215
e84db124cb2158b Syed Saba Kareem 2023-10-21 216 spin_lock(&adata->acp_lock);
e84db124cb2158b Syed Saba Kareem 2023-10-21 @217 list_for_each_entry(stream, &adata->stream_list, list) {
e84db124cb2158b Syed Saba Kareem 2023-10-21 @218 if (stream) {
e84db124cb2158b Syed Saba Kareem 2023-10-21 219 substream = stream->substream;
e84db124cb2158b Syed Saba Kareem 2023-10-21 220 if (substream && substream->runtime) {
e84db124cb2158b Syed Saba Kareem 2023-10-21 221 buf_in_frames = (substream->runtime->buffer_size);
e84db124cb2158b Syed Saba Kareem 2023-10-21 222 buf_size = frames_to_bytes(substream->runtime, buf_in_frames);
e84db124cb2158b Syed Saba Kareem 2023-10-21 223 config_pte_for_stream(adata, stream);
e84db124cb2158b Syed Saba Kareem 2023-10-21 224 config_acp_dma(adata, stream, buf_size);
e84db124cb2158b Syed Saba Kareem 2023-10-21 225 if (stream->dai_id)
e84db124cb2158b Syed Saba Kareem 2023-10-21 226 restore_acp_i2s_params(substream, adata, stream);
e84db124cb2158b Syed Saba Kareem 2023-10-21 227 else
e84db124cb2158b Syed Saba Kareem 2023-10-21 228 restore_acp_pdm_params(substream, adata);
e84db124cb2158b Syed Saba Kareem 2023-10-21 229 }
e84db124cb2158b Syed Saba Kareem 2023-10-21 230 }
e84db124cb2158b Syed Saba Kareem 2023-10-21 231 }
e84db124cb2158b Syed Saba Kareem 2023-10-21 232 spin_unlock(&adata->acp_lock);
e84db124cb2158b Syed Saba Kareem 2023-10-21 233 return 0;
e84db124cb2158b Syed Saba Kareem 2023-10-21 234 }
e84db124cb2158b Syed Saba Kareem 2023-10-21 235
:::::: The code at line 217 was first introduced by commit
:::::: e84db124cb2158b538820f31f641c28b86fb3ca3 ASoC: amd: acp: Add pci legacy driver support for acp7.0 platform
:::::: TO: Syed Saba Kareem <Syed.SabaKareem@amd.com>
:::::: CC: Mark Brown <broonie@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 6+ messages in thread* sound/soc/amd/acp/acp70.c:217 acp70_pcm_resume() error: we previously assumed 'stream' could be null (see line 218)
@ 2024-12-15 1:15 kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2024-12-15 1:15 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Syed Saba Kareem <Syed.SabaKareem@amd.com>
CC: Mark Brown <broonie@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: a0e3919a2df29b373b19a8fbd6e4c4c38fc10d87
commit: d3534684ada99ef8c0899eb28c62b4462483ee19 ASoC: amd: acp: add Kconfig options for acp7.0 based platform driver
date: 1 year, 1 month ago
:::::: branch date: 8 hours ago
:::::: commit date: 1 year, 1 month ago
config: x86_64-randconfig-161-20241205 (https://download.01.org/0day-ci/archive/20241215/202412150955.tg0Byjyq-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202412150955.tg0Byjyq-lkp@intel.com/
smatch warnings:
sound/soc/amd/acp/acp70.c:217 acp70_pcm_resume() error: we previously assumed 'stream' could be null (see line 218)
vim +/stream +217 sound/soc/amd/acp/acp70.c
e84db124cb2158b Syed Saba Kareem 2023-10-21 207
e84db124cb2158b Syed Saba Kareem 2023-10-21 208 static int __maybe_unused acp70_pcm_resume(struct device *dev)
e84db124cb2158b Syed Saba Kareem 2023-10-21 209 {
e84db124cb2158b Syed Saba Kareem 2023-10-21 210 struct acp_dev_data *adata = dev_get_drvdata(dev);
e84db124cb2158b Syed Saba Kareem 2023-10-21 211 struct acp_stream *stream;
e84db124cb2158b Syed Saba Kareem 2023-10-21 212 struct snd_pcm_substream *substream;
e84db124cb2158b Syed Saba Kareem 2023-10-21 213 snd_pcm_uframes_t buf_in_frames;
e84db124cb2158b Syed Saba Kareem 2023-10-21 214 u64 buf_size;
e84db124cb2158b Syed Saba Kareem 2023-10-21 215
e84db124cb2158b Syed Saba Kareem 2023-10-21 216 spin_lock(&adata->acp_lock);
e84db124cb2158b Syed Saba Kareem 2023-10-21 @217 list_for_each_entry(stream, &adata->stream_list, list) {
e84db124cb2158b Syed Saba Kareem 2023-10-21 @218 if (stream) {
e84db124cb2158b Syed Saba Kareem 2023-10-21 219 substream = stream->substream;
e84db124cb2158b Syed Saba Kareem 2023-10-21 220 if (substream && substream->runtime) {
e84db124cb2158b Syed Saba Kareem 2023-10-21 221 buf_in_frames = (substream->runtime->buffer_size);
e84db124cb2158b Syed Saba Kareem 2023-10-21 222 buf_size = frames_to_bytes(substream->runtime, buf_in_frames);
e84db124cb2158b Syed Saba Kareem 2023-10-21 223 config_pte_for_stream(adata, stream);
e84db124cb2158b Syed Saba Kareem 2023-10-21 224 config_acp_dma(adata, stream, buf_size);
e84db124cb2158b Syed Saba Kareem 2023-10-21 225 if (stream->dai_id)
e84db124cb2158b Syed Saba Kareem 2023-10-21 226 restore_acp_i2s_params(substream, adata, stream);
e84db124cb2158b Syed Saba Kareem 2023-10-21 227 else
e84db124cb2158b Syed Saba Kareem 2023-10-21 228 restore_acp_pdm_params(substream, adata);
e84db124cb2158b Syed Saba Kareem 2023-10-21 229 }
e84db124cb2158b Syed Saba Kareem 2023-10-21 230 }
e84db124cb2158b Syed Saba Kareem 2023-10-21 231 }
e84db124cb2158b Syed Saba Kareem 2023-10-21 232 spin_unlock(&adata->acp_lock);
e84db124cb2158b Syed Saba Kareem 2023-10-21 233 return 0;
e84db124cb2158b Syed Saba Kareem 2023-10-21 234 }
e84db124cb2158b Syed Saba Kareem 2023-10-21 235
:::::: The code at line 217 was first introduced by commit
:::::: e84db124cb2158b538820f31f641c28b86fb3ca3 ASoC: amd: acp: Add pci legacy driver support for acp7.0 platform
:::::: TO: Syed Saba Kareem <Syed.SabaKareem@amd.com>
:::::: CC: Mark Brown <broonie@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 6+ messages in thread* sound/soc/amd/acp/acp70.c:217 acp70_pcm_resume() error: we previously assumed 'stream' could be null (see line 218)
@ 2024-12-12 7:34 kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2024-12-12 7:34 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Syed Saba Kareem <Syed.SabaKareem@amd.com>
CC: Mark Brown <broonie@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 231825b2e1ff6ba799c5eaf396d3ab2354e37c6b
commit: d3534684ada99ef8c0899eb28c62b4462483ee19 ASoC: amd: acp: add Kconfig options for acp7.0 based platform driver
date: 1 year, 1 month ago
:::::: branch date: 9 hours ago
:::::: commit date: 1 year, 1 month ago
config: x86_64-randconfig-161-20241205 (https://download.01.org/0day-ci/archive/20241212/202412121543.kK53XEct-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202412121543.kK53XEct-lkp@intel.com/
smatch warnings:
sound/soc/amd/acp/acp70.c:217 acp70_pcm_resume() error: we previously assumed 'stream' could be null (see line 218)
vim +/stream +217 sound/soc/amd/acp/acp70.c
e84db124cb2158b Syed Saba Kareem 2023-10-21 207
e84db124cb2158b Syed Saba Kareem 2023-10-21 208 static int __maybe_unused acp70_pcm_resume(struct device *dev)
e84db124cb2158b Syed Saba Kareem 2023-10-21 209 {
e84db124cb2158b Syed Saba Kareem 2023-10-21 210 struct acp_dev_data *adata = dev_get_drvdata(dev);
e84db124cb2158b Syed Saba Kareem 2023-10-21 211 struct acp_stream *stream;
e84db124cb2158b Syed Saba Kareem 2023-10-21 212 struct snd_pcm_substream *substream;
e84db124cb2158b Syed Saba Kareem 2023-10-21 213 snd_pcm_uframes_t buf_in_frames;
e84db124cb2158b Syed Saba Kareem 2023-10-21 214 u64 buf_size;
e84db124cb2158b Syed Saba Kareem 2023-10-21 215
e84db124cb2158b Syed Saba Kareem 2023-10-21 216 spin_lock(&adata->acp_lock);
e84db124cb2158b Syed Saba Kareem 2023-10-21 @217 list_for_each_entry(stream, &adata->stream_list, list) {
e84db124cb2158b Syed Saba Kareem 2023-10-21 @218 if (stream) {
e84db124cb2158b Syed Saba Kareem 2023-10-21 219 substream = stream->substream;
e84db124cb2158b Syed Saba Kareem 2023-10-21 220 if (substream && substream->runtime) {
e84db124cb2158b Syed Saba Kareem 2023-10-21 221 buf_in_frames = (substream->runtime->buffer_size);
e84db124cb2158b Syed Saba Kareem 2023-10-21 222 buf_size = frames_to_bytes(substream->runtime, buf_in_frames);
e84db124cb2158b Syed Saba Kareem 2023-10-21 223 config_pte_for_stream(adata, stream);
e84db124cb2158b Syed Saba Kareem 2023-10-21 224 config_acp_dma(adata, stream, buf_size);
e84db124cb2158b Syed Saba Kareem 2023-10-21 225 if (stream->dai_id)
e84db124cb2158b Syed Saba Kareem 2023-10-21 226 restore_acp_i2s_params(substream, adata, stream);
e84db124cb2158b Syed Saba Kareem 2023-10-21 227 else
e84db124cb2158b Syed Saba Kareem 2023-10-21 228 restore_acp_pdm_params(substream, adata);
e84db124cb2158b Syed Saba Kareem 2023-10-21 229 }
e84db124cb2158b Syed Saba Kareem 2023-10-21 230 }
e84db124cb2158b Syed Saba Kareem 2023-10-21 231 }
e84db124cb2158b Syed Saba Kareem 2023-10-21 232 spin_unlock(&adata->acp_lock);
e84db124cb2158b Syed Saba Kareem 2023-10-21 233 return 0;
e84db124cb2158b Syed Saba Kareem 2023-10-21 234 }
e84db124cb2158b Syed Saba Kareem 2023-10-21 235
:::::: The code at line 217 was first introduced by commit
:::::: e84db124cb2158b538820f31f641c28b86fb3ca3 ASoC: amd: acp: Add pci legacy driver support for acp7.0 platform
:::::: TO: Syed Saba Kareem <Syed.SabaKareem@amd.com>
:::::: CC: Mark Brown <broonie@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 6+ messages in thread* sound/soc/amd/acp/acp70.c:217 acp70_pcm_resume() error: we previously assumed 'stream' could be null (see line 218)
@ 2024-12-09 4:44 kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2024-12-09 4:44 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Syed Saba Kareem <Syed.SabaKareem@amd.com>
CC: Mark Brown <broonie@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 7503345ac5f5e82fd9a36d6e6b447c016376403a
commit: d3534684ada99ef8c0899eb28c62b4462483ee19 ASoC: amd: acp: add Kconfig options for acp7.0 based platform driver
date: 1 year, 1 month ago
:::::: branch date: 13 hours ago
:::::: commit date: 1 year, 1 month ago
config: x86_64-randconfig-161-20241205 (https://download.01.org/0day-ci/archive/20241208/202412081508.YbgfomqS-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202412081508.YbgfomqS-lkp@intel.com/
smatch warnings:
sound/soc/amd/acp/acp70.c:217 acp70_pcm_resume() error: we previously assumed 'stream' could be null (see line 218)
vim +/stream +217 sound/soc/amd/acp/acp70.c
e84db124cb2158b Syed Saba Kareem 2023-10-21 207
e84db124cb2158b Syed Saba Kareem 2023-10-21 208 static int __maybe_unused acp70_pcm_resume(struct device *dev)
e84db124cb2158b Syed Saba Kareem 2023-10-21 209 {
e84db124cb2158b Syed Saba Kareem 2023-10-21 210 struct acp_dev_data *adata = dev_get_drvdata(dev);
e84db124cb2158b Syed Saba Kareem 2023-10-21 211 struct acp_stream *stream;
e84db124cb2158b Syed Saba Kareem 2023-10-21 212 struct snd_pcm_substream *substream;
e84db124cb2158b Syed Saba Kareem 2023-10-21 213 snd_pcm_uframes_t buf_in_frames;
e84db124cb2158b Syed Saba Kareem 2023-10-21 214 u64 buf_size;
e84db124cb2158b Syed Saba Kareem 2023-10-21 215
e84db124cb2158b Syed Saba Kareem 2023-10-21 216 spin_lock(&adata->acp_lock);
e84db124cb2158b Syed Saba Kareem 2023-10-21 @217 list_for_each_entry(stream, &adata->stream_list, list) {
e84db124cb2158b Syed Saba Kareem 2023-10-21 @218 if (stream) {
e84db124cb2158b Syed Saba Kareem 2023-10-21 219 substream = stream->substream;
e84db124cb2158b Syed Saba Kareem 2023-10-21 220 if (substream && substream->runtime) {
e84db124cb2158b Syed Saba Kareem 2023-10-21 221 buf_in_frames = (substream->runtime->buffer_size);
e84db124cb2158b Syed Saba Kareem 2023-10-21 222 buf_size = frames_to_bytes(substream->runtime, buf_in_frames);
e84db124cb2158b Syed Saba Kareem 2023-10-21 223 config_pte_for_stream(adata, stream);
e84db124cb2158b Syed Saba Kareem 2023-10-21 224 config_acp_dma(adata, stream, buf_size);
e84db124cb2158b Syed Saba Kareem 2023-10-21 225 if (stream->dai_id)
e84db124cb2158b Syed Saba Kareem 2023-10-21 226 restore_acp_i2s_params(substream, adata, stream);
e84db124cb2158b Syed Saba Kareem 2023-10-21 227 else
e84db124cb2158b Syed Saba Kareem 2023-10-21 228 restore_acp_pdm_params(substream, adata);
e84db124cb2158b Syed Saba Kareem 2023-10-21 229 }
e84db124cb2158b Syed Saba Kareem 2023-10-21 230 }
e84db124cb2158b Syed Saba Kareem 2023-10-21 231 }
e84db124cb2158b Syed Saba Kareem 2023-10-21 232 spin_unlock(&adata->acp_lock);
e84db124cb2158b Syed Saba Kareem 2023-10-21 233 return 0;
e84db124cb2158b Syed Saba Kareem 2023-10-21 234 }
e84db124cb2158b Syed Saba Kareem 2023-10-21 235
:::::: The code at line 217 was first introduced by commit
:::::: e84db124cb2158b538820f31f641c28b86fb3ca3 ASoC: amd: acp: Add pci legacy driver support for acp7.0 platform
:::::: TO: Syed Saba Kareem <Syed.SabaKareem@amd.com>
:::::: CC: Mark Brown <broonie@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 6+ messages in thread* sound/soc/amd/acp/acp70.c:217 acp70_pcm_resume() error: we previously assumed 'stream' could be null (see line 218)
@ 2024-12-05 13:34 Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2024-12-05 13:34 UTC (permalink / raw)
To: oe-kbuild, Syed Saba Kareem; +Cc: lkp, oe-kbuild-all, linux-kernel, Mark Brown
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: feffde684ac29a3b7aec82d2df850fbdbdee55e4
commit: d3534684ada99ef8c0899eb28c62b4462483ee19 ASoC: amd: acp: add Kconfig options for acp7.0 based platform driver
config: x86_64-randconfig-161-20241205 (https://download.01.org/0day-ci/archive/20241205/202412052149.HYbkQDxc-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202412052149.HYbkQDxc-lkp@intel.com/
smatch warnings:
sound/soc/amd/acp/acp70.c:217 acp70_pcm_resume() error: we previously assumed 'stream' could be null (see line 218)
vim +/stream +217 sound/soc/amd/acp/acp70.c
e84db124cb2158b Syed Saba Kareem 2023-10-21 208 static int __maybe_unused acp70_pcm_resume(struct device *dev)
e84db124cb2158b Syed Saba Kareem 2023-10-21 209 {
e84db124cb2158b Syed Saba Kareem 2023-10-21 210 struct acp_dev_data *adata = dev_get_drvdata(dev);
e84db124cb2158b Syed Saba Kareem 2023-10-21 211 struct acp_stream *stream;
e84db124cb2158b Syed Saba Kareem 2023-10-21 212 struct snd_pcm_substream *substream;
e84db124cb2158b Syed Saba Kareem 2023-10-21 213 snd_pcm_uframes_t buf_in_frames;
e84db124cb2158b Syed Saba Kareem 2023-10-21 214 u64 buf_size;
e84db124cb2158b Syed Saba Kareem 2023-10-21 215
e84db124cb2158b Syed Saba Kareem 2023-10-21 216 spin_lock(&adata->acp_lock);
e84db124cb2158b Syed Saba Kareem 2023-10-21 @217 list_for_each_entry(stream, &adata->stream_list, list) {
e84db124cb2158b Syed Saba Kareem 2023-10-21 @218 if (stream) {
The list iterator can't be NULL so this check isn't required.
e84db124cb2158b Syed Saba Kareem 2023-10-21 219 substream = stream->substream;
e84db124cb2158b Syed Saba Kareem 2023-10-21 220 if (substream && substream->runtime) {
e84db124cb2158b Syed Saba Kareem 2023-10-21 221 buf_in_frames = (substream->runtime->buffer_size);
e84db124cb2158b Syed Saba Kareem 2023-10-21 222 buf_size = frames_to_bytes(substream->runtime, buf_in_frames);
e84db124cb2158b Syed Saba Kareem 2023-10-21 223 config_pte_for_stream(adata, stream);
e84db124cb2158b Syed Saba Kareem 2023-10-21 224 config_acp_dma(adata, stream, buf_size);
e84db124cb2158b Syed Saba Kareem 2023-10-21 225 if (stream->dai_id)
e84db124cb2158b Syed Saba Kareem 2023-10-21 226 restore_acp_i2s_params(substream, adata, stream);
e84db124cb2158b Syed Saba Kareem 2023-10-21 227 else
e84db124cb2158b Syed Saba Kareem 2023-10-21 228 restore_acp_pdm_params(substream, adata);
e84db124cb2158b Syed Saba Kareem 2023-10-21 229 }
e84db124cb2158b Syed Saba Kareem 2023-10-21 230 }
e84db124cb2158b Syed Saba Kareem 2023-10-21 231 }
e84db124cb2158b Syed Saba Kareem 2023-10-21 232 spin_unlock(&adata->acp_lock);
e84db124cb2158b Syed Saba Kareem 2023-10-21 233 return 0;
e84db124cb2158b Syed Saba Kareem 2023-10-21 234 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 6+ messages in thread* sound/soc/amd/acp/acp70.c:217 acp70_pcm_resume() error: we previously assumed 'stream' could be null (see line 218)
@ 2024-11-17 7:02 kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2024-11-17 7:02 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Syed Saba Kareem <Syed.SabaKareem@amd.com>
CC: Mark Brown <broonie@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 4a5df37964673effcd9f84041f7423206a5ae5f2
commit: d3534684ada99ef8c0899eb28c62b4462483ee19 ASoC: amd: acp: add Kconfig options for acp7.0 based platform driver
date: 1 year ago
:::::: branch date: 7 hours ago
:::::: commit date: 1 year ago
config: i386-randconfig-141-20241115 (https://download.01.org/0day-ci/archive/20241117/202411171413.RwH20B3k-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202411171413.RwH20B3k-lkp@intel.com/
smatch warnings:
sound/soc/amd/acp/acp70.c:217 acp70_pcm_resume() error: we previously assumed 'stream' could be null (see line 218)
vim +/stream +217 sound/soc/amd/acp/acp70.c
e84db124cb2158 Syed Saba Kareem 2023-10-21 207
e84db124cb2158 Syed Saba Kareem 2023-10-21 208 static int __maybe_unused acp70_pcm_resume(struct device *dev)
e84db124cb2158 Syed Saba Kareem 2023-10-21 209 {
e84db124cb2158 Syed Saba Kareem 2023-10-21 210 struct acp_dev_data *adata = dev_get_drvdata(dev);
e84db124cb2158 Syed Saba Kareem 2023-10-21 211 struct acp_stream *stream;
e84db124cb2158 Syed Saba Kareem 2023-10-21 212 struct snd_pcm_substream *substream;
e84db124cb2158 Syed Saba Kareem 2023-10-21 213 snd_pcm_uframes_t buf_in_frames;
e84db124cb2158 Syed Saba Kareem 2023-10-21 214 u64 buf_size;
e84db124cb2158 Syed Saba Kareem 2023-10-21 215
e84db124cb2158 Syed Saba Kareem 2023-10-21 216 spin_lock(&adata->acp_lock);
e84db124cb2158 Syed Saba Kareem 2023-10-21 @217 list_for_each_entry(stream, &adata->stream_list, list) {
e84db124cb2158 Syed Saba Kareem 2023-10-21 @218 if (stream) {
e84db124cb2158 Syed Saba Kareem 2023-10-21 219 substream = stream->substream;
e84db124cb2158 Syed Saba Kareem 2023-10-21 220 if (substream && substream->runtime) {
e84db124cb2158 Syed Saba Kareem 2023-10-21 221 buf_in_frames = (substream->runtime->buffer_size);
e84db124cb2158 Syed Saba Kareem 2023-10-21 222 buf_size = frames_to_bytes(substream->runtime, buf_in_frames);
e84db124cb2158 Syed Saba Kareem 2023-10-21 223 config_pte_for_stream(adata, stream);
e84db124cb2158 Syed Saba Kareem 2023-10-21 224 config_acp_dma(adata, stream, buf_size);
e84db124cb2158 Syed Saba Kareem 2023-10-21 225 if (stream->dai_id)
e84db124cb2158 Syed Saba Kareem 2023-10-21 226 restore_acp_i2s_params(substream, adata, stream);
e84db124cb2158 Syed Saba Kareem 2023-10-21 227 else
e84db124cb2158 Syed Saba Kareem 2023-10-21 228 restore_acp_pdm_params(substream, adata);
e84db124cb2158 Syed Saba Kareem 2023-10-21 229 }
e84db124cb2158 Syed Saba Kareem 2023-10-21 230 }
e84db124cb2158 Syed Saba Kareem 2023-10-21 231 }
e84db124cb2158 Syed Saba Kareem 2023-10-21 232 spin_unlock(&adata->acp_lock);
e84db124cb2158 Syed Saba Kareem 2023-10-21 233 return 0;
e84db124cb2158 Syed Saba Kareem 2023-10-21 234 }
e84db124cb2158 Syed Saba Kareem 2023-10-21 235
:::::: The code at line 217 was first introduced by commit
:::::: e84db124cb2158b538820f31f641c28b86fb3ca3 ASoC: amd: acp: Add pci legacy driver support for acp7.0 platform
:::::: TO: Syed Saba Kareem <Syed.SabaKareem@amd.com>
:::::: CC: Mark Brown <broonie@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-12-15 1:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-05 13:17 sound/soc/amd/acp/acp70.c:217 acp70_pcm_resume() error: we previously assumed 'stream' could be null (see line 218) kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2024-12-15 1:15 kernel test robot
2024-12-12 7:34 kernel test robot
2024-12-09 4:44 kernel test robot
2024-12-05 13:34 Dan Carpenter
2024-11-17 7:02 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.